RE: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER

From: "Alice Guo (OSS)" <alice.guo@oss.nxp.com>
To: Dominique MARTINET <dominique.martinet@atmark-techno.com>,
	"Alice Guo (OSS)" <alice.guo@oss.nxp.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"rafael@kernel.org" <rafael@kernel.org>,
	Horia Geanta <horia.geanta@nxp.com>,
	Aymen Sghaier <aymen.sghaier@nxp.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"tony@atomide.com" <tony@atomide.com>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"peter.ujfalusi@gmail.com" <peter.ujfalusi@gmail.com>,
	"a.hajda@samsung.com" <a.hajda@samsung.com>,
	"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"robert.foss@linaro.org" <robert.foss@linaro.org>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"khilman@baylibre.com" <khilman@baylibre.com>,
	"tomba@kernel.org" <tomba@kernel.org>,
	"jyri.sarha@iki.fi" <jyri.sarha@iki.fi>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"will@kernel.org" <will@kernel.org>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"kishon@ti.com" <kishon@ti.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	Leo Li <leoyang.li@nxp.com>,
	"ssantosh@kernel.org" <ssantosh@kernel.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"edubezval@gmail.com" <edubezval@gmail.com>,
	"j-keerthy@ti.com" <j-keerthy@ti.com>,
	"balbi@kernel.org" <balbi@kernel.org>,
	"linux@prisktech.co.nz" <linux@prisktech.co.nz>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-amlogic@lists.infradead.org" 
	<linux-amlogic@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
	"linux-mediatek@lists.infradead.org" 
	<linux-mediatek@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match returning -EPROBE_DEFER
Date: Mon, 19 Apr 2021 06:40:46 +0000	[thread overview]
Message-ID: <AM6PR04MB60536416D5467486837FC673E2499@AM6PR04MB6053.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <YH0Lwy2AYpXaJIex@atmark-techno.com>

> -----Original Message-----
> From: Dominique MARTINET <dominique.martinet@atmark-techno.com>
> Sent: 2021年4月19日 12:49
> To: Alice Guo (OSS) <alice.guo@oss.nxp.com>
> Cc: gregkh@linuxfoundation.org; rafael@kernel.org; Horia Geanta
> <horia.geanta@nxp.com>; Aymen Sghaier <aymen.sghaier@nxp.com>;
> herbert@gondor.apana.org.au; davem@davemloft.net; tony@atomide.com;
> geert+renesas@glider.be; mturquette@baylibre.com; sboyd@kernel.org;
> vkoul@kernel.org; peter.ujfalusi@gmail.com; a.hajda@samsung.com;
> narmstrong@baylibre.com; robert.foss@linaro.org; airlied@linux.ie;
> daniel@ffwll.ch; khilman@baylibre.com; tomba@kernel.org; jyri.sarha@iki.fi;
> joro@8bytes.org; will@kernel.org; mchehab@kernel.org;
> ulf.hansson@linaro.org; adrian.hunter@intel.com; kishon@ti.com;
> kuba@kernel.org; linus.walleij@linaro.org; Roy Pledge <roy.pledge@nxp.com>;
> Leo Li <leoyang.li@nxp.com>; ssantosh@kernel.org; matthias.bgg@gmail.com;
> edubezval@gmail.com; j-keerthy@ti.com; balbi@kernel.org;
> linux@prisktech.co.nz; stern@rowland.harvard.edu; wim@linux-watchdog.org;
> linux@roeck-us.net; linux-kernel@vger.kernel.org; linux-crypto@vger.kernel.org;
> linux-omap@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> linux-clk@vger.kernel.org; dmaengine@vger.kernel.org;
> dri-devel@lists.freedesktop.org; linux-amlogic@lists.infradead.org;
> linux-arm-kernel@lists.infradead.org; iommu@lists.linux-foundation.org;
> linux-media@vger.kernel.org; linux-mmc@vger.kernel.org;
> netdev@vger.kernel.org; linux-phy@lists.infradead.org;
> linux-gpio@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> linux-staging@lists.linux.dev; linux-mediatek@lists.infradead.org;
> linux-pm@vger.kernel.org; linux-usb@vger.kernel.org;
> linux-watchdog@vger.kernel.org
> Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match
> returning -EPROBE_DEFER
> 
> First comment overall for the whole serie:
> Since it is the solution I had suggested when I reported the problem[1] I have no
> qualm on the approach, comments for individual patches follow.
> 
> [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/VU@atmark-techno.com
> 
> 
> Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800:
> > From: Alice Guo <alice.guo@nxp.com>
> >
> > In i.MX8M boards, the registration of SoC device is later than caam
> > driver which needs it. Caam driver needs soc_device_match to provide
> > -EPROBE_DEFER when no SoC device is registered and no
> > early_soc_dev_attr.
> 
> This patch should be last in the set: you can't have soc_device_match return an
> error before its callers handle it.
> 
> > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> 
> As the one who reported the problem I would have been appreciated being at
> least added to Ccs... I only happened to notice you posted this by chance.

Sorry. I will Cc you next time.

> There is also not a single Fixes tag -- I believe this commit should have Fixes:
> 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure
> how such tags should be handled in case of multiple patches fixing something.

I only mentioned "soc: imx8m: change to use platform driver" in cover letter.
If it is acceptable to make such a modification, I will send non-RFC and add Fixes tag.

Best Regards,
Alice

> --
> Dominique