From: Joy Zou <joy.zou@nxp.com>
To: Frank Li <frank.li@nxp.com>
Cc: Peng Fan <peng.fan@nxp.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
Date: Thu, 18 Apr 2024 01:38:16 +0000 [thread overview]
Message-ID: <AS4PR04MB93862A14E6FAD42A2B5F6301E10E2@AS4PR04MB9386.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <Zh/fQFdxHHxC5iXF@lizhi-Precision-Tower-5810>
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年4月17日 22:40
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>; vkoul@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; imx@lists.linux.dev;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH v4 1/2] dmaengine: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible string
> > diff --git a/drivers/dma/fsl-edma-common.c
> > b/drivers/dma/fsl-edma-common.c index f9144b015439..ed93e01282d5
> > 100644
> > --- a/drivers/dma/fsl-edma-common.c
> > +++ b/drivers/dma/fsl-edma-common.c
> > @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct
> > fsl_edma_chan *fsl_chan)
> >
> > flags = fsl_edma_drvflags(fsl_chan);
> > val = edma_readl_chreg(fsl_chan, ch_sbr);
> > - /* Remote/local swapped wrongly on iMX8 QM Audio edma */
> > - if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {
>
> You forget remove FSL_EDMA_DRV_QUIRK_SWAPPED in fsl-edma-common.h
Thanks your comments!
Yeah, will remove it in next version.
BR
Joy Zou
>
> Frank
>
next prev parent reply other threads:[~2024-04-18 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 3:26 [PATCH v4 0/2] clean up unused "fsl,imx8qm-adma" compatible string Joy Zou
2024-04-17 3:26 ` [PATCH v4 1/2] dmaengine: fsl-edma: " Joy Zou
2024-04-17 14:40 ` Frank Li
2024-04-18 1:38 ` Joy Zou [this message]
2024-04-17 3:26 ` [PATCH v4 2/2] dt-bindings: fsl-dma: " Joy Zou
2024-04-17 14:45 ` Frank Li
2024-04-18 1:40 ` Joy Zou
2024-04-17 18:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS4PR04MB93862A14E6FAD42A2B5F6301E10E2@AS4PR04MB9386.eurprd04.prod.outlook.com \
--to=joy.zou@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.