From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mcnamara, John" Subject: Re: [PATCH v3 02/20] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Date: Wed, 14 Oct 2015 16:28:28 +0000 Message-ID: References: <1444667120-12891-1-git-send-email-bernard.iremonger@intel.com> <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: "Iremonger, Bernard" , "dev@dpdk.org" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 98DDFA6A for ; Wed, 14 Oct 2015 18:28:31 +0200 (CEST) In-Reply-To: <1444667120-12891-3-git-send-email-bernard.iremonger@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Monday, October 12, 2015 5:25 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 02/20] librte_ether: add fields from > ... > > lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > + uint32_t dev_flags; /**< Flags controlling handling of device. */ > + enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > + int numa_node; > + const char *drv_name; > }; >=20 Should the last two members have doxygen comments as well?