From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v1 1/1] example/ip_pipeline: fix memcpy issue
Date: Tue, 8 Dec 2015 16:59:31 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2023FEDE3@IRSMSX103.ger.corp.intel.com>
References: <1449584208-24987-1-git-send-email-piotrx.t.azarewicz@intel.com>
 <B27915DBBA3421428155699D51E4CFE2023FEA7F@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Mcnamara, John" <john.mcnamara@intel.com>, "Azarewicz, PiotrX T"
 <piotrx.t.azarewicz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 00269567E
 for <dev@dpdk.org>; Tue,  8 Dec 2015 17:59:35 +0100 (CET)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023FEA7F@IRSMSX103.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, December 8, 2015 2:47 PM
> To: Azarewicz, PiotrX T; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> issue
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Piotr Azarewicz
> > Sent: Tuesday, December 8, 2015 2:17 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v1 1/1] example/ip_pipeline: fix memcpy
> > issue
> >
> > The cmds and thread_cmds both are the arrays of cmdline_parse_ctx_t.
> > So the goal is to copy elements size of cmdline_parse_ctx_t not
> > cmdline_parse_ctx_t*.
> >
> > Coverity issue: 120412
> > Fixes: b4aee0fb9c6d ("examples/ip_pipeline: reconfigure thread binding
> > dynamically")
> >
> > Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
>=20
> Acked-by: John McNamara <john.mcnamara@intel.com>

Hi Piotr,

This issue occurs copy and pasted in two other locations as well:

    examples/ip_pipeline/pipeline/pipeline_common_fe.c
    1295:           n_cmds * sizeof(cmdline_parse_ctx_t *));

    examples/ip_pipeline/thread_fe.c
    340:            n_cmds * sizeof(cmdline_parse_ctx_t *));

    examples/ip_pipeline/init.c
    1475:           n_cmds * sizeof(cmdline_parse_ctx_t *));

Perhaps you could fix those in the same patch.

Thanks,

John