From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Takuya ASADA <syuu@cloudius-systems.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [RFC PATCHv3 7/7] doc: Add Getting Started Guide for OSv
Date: Thu, 18 Jun 2015 14:09:14 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2F47640@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1428346691-14894-8-git-send-email-syuu@cloudius-systems.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Takuya ASADA
> Sent: Monday, April 6, 2015 7:58 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC PATCHv3 7/7] doc: Add Getting Started Guide for
> OSv
>
> Described how to build DPDK for OSv, using "Capstan".
Hi,
A few minor issues:
* The patch has some whitespace issues.
* The introduction could make it a little clearer what OSv is.
* The introduction mentions a handbook but there isn't a link.
* The OSv guide should follow the FreeBSD guide in the index.rst file.
* "make doc-guides-html" generates the following warnings due to conflict with the FreeBSD docs. Unique labels should be provided.
WARNING: duplicate label building_from_source
WARNING: duplicate label compiling_sample_apps
John
next prev parent reply other threads:[~2015-06-18 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 18:58 [RFC PATCHv3 0/7] add OSv support Takuya ASADA
[not found] ` <1428346691-14894-1-git-send-email-syuu-RmZWMc9puTNJc61us3aD9laTQe2KTcn/@public.gmane.org>
2015-04-06 18:58 ` [RFC PATCHv3 1/7] mk: support compiling C++ code Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 2/7] eal: Add extern C on eal_hugepages.h Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 3/7] eal: Add extern C on eal_thread.h Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 4/7] eal: Add extern C on eal_private.h Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 5/7] add OSv support Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 6/7] app/test: support OSv Takuya ASADA
2015-04-06 18:58 ` [RFC PATCHv3 7/7] doc: Add Getting Started Guide for OSv Takuya ASADA
2015-06-18 14:09 ` Mcnamara, John [this message]
2015-04-20 18:37 ` [RFC PATCHv3 0/7] add OSv support Takuya ASADA
2015-07-08 23:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2F47640@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=syuu@cloudius-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.