From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Liang-min" Subject: Re: [PATCH v9 2/5] ixgbe: add ops to support ethtool ops Date: Sat, 27 Jun 2015 02:39:26 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-1-git-send-email-liang-min.wang@intel.com> <1435367948-20240-3-git-send-email-liang-min.wang@intel.com> <20150626183403.6a3dc4fb@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Stephen Hemminger Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 98D22CA6E for ; Sat, 27 Jun 2015 04:39:28 +0200 (CEST) In-Reply-To: <20150626183403.6a3dc4fb@urahara> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, June 26, 2015 9:34 PM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool = ops >=20 > On Fri, 26 Jun 2015 21:19:05 -0400 > Liang-Min Larry Wang wrote: >=20 > > + reg_group =3D reg_set[g_ind++]; > > + while (reg_group) { > > + count +=3D ixgbe_regs_group_count(reg_group); > > + reg_group =3D reg_set[g_ind++]; > > + } >=20 > I don't care what checkpatch says, this an example of a loop > which reads better as: >=20 > while ((reg_group =3D reg_set[g_ind++])) > count +=3D ixgbe_regs_group_count(reg_group); There is no specific guideline on which to follow besides running checkpatc= h. Maybe this type of exception should be listed on dpdk web-link. This suggestion is taken on v10.