From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Liang-min" Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 10:48:12 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <7196644.zbOgvuZnbg@xps13> <4907797.WMXsT5lYd9@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 36C515A0A for ; Wed, 15 Jul 2015 12:48:15 +0200 (CEST) In-Reply-To: <4907797.WMXsT5lYd9@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 15, 2015 6:27 AM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support acces= s > device info >=20 > 2015-07-15 10:07, Wang, Liang-min: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > Please precise offset from which point? > > > Why offset is needed? > > > > > Is C always 0-base? > > The offset is introduced because one of the review requesting to suppor= t > partial register read, > > meaning reading single register or a set of registers. > > As comment in my reply, this implementation only supports total registe= r > dump, > > but the data structure design allows future expansion to support this > request. >=20 > OK, so the comment should be something like "Offset in register table" >=20 > > > What means magic? Is it always a device id? > > This field is the same as defined in kernel ethtool data structure. >=20 > Not an excellent argument :) > Actually you didn't answer. >=20 I could not speak for other devices. For igb and ixgbe, it's device id. Based upon literature search, this field is used by device driver to provid= e extra information. What would be your suggestion? > > > > --- a/lib/librte_ether/rte_ether_version.map > > > > +++ b/lib/librte_ether/rte_ether_version.map > > > > @@ -114,5 +114,11 @@ DPDK_2.1 { > > > > rte_eth_timesync_enable; > > > > rte_eth_timesync_read_rx_timestamp; > > > > rte_eth_timesync_read_tx_timestamp; > > > > + rte_eth_dev_default_mac_addr_set; > > > > + rte_eth_dev_reg_length; > > > > + rte_eth_dev_reg_info; > > > > + rte_eth_dev_eeprom_length; > > > > + rte_eth_dev_get_eeprom; > > > > + rte_eth_dev_set_eeprom; > > > > > > It is not in alphabetical order. > > Is there a document on such requirement? >=20 > No, only emails. > Every .map are alphabetically sorted. It's easier to check symbols. >=20 > > I'm asking this question because different API's are added at different > time. > > Does this comment apply on relative order or absolute order meaning > order relative to mainline code? >=20 > Relative to mainline. Conflicts are handled when applying.