From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Liang-min" Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 11:36:10 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <4907797.WMXsT5lYd9@xps13> <1436962741.PL5XZBfjSs@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C31065A6C for ; Wed, 15 Jul 2015 13:36:39 +0200 (CEST) In-Reply-To: <1436962741.PL5XZBfjSs@xps13> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, July 15, 2015 7:21 AM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v15 1/4] ethdev: add apis to support acces= s > device info >=20 > 2015-07-15 10:48, Wang, Liang-min: > > > > > What means magic? Is it always a device id? > > > > This field is the same as defined in kernel ethtool data structure. > > > > > > Not an excellent argument :) > > > Actually you didn't answer. > > > > > I could not speak for other devices. For igb and ixgbe, it's device id. > > Based upon literature search, this field is used by device driver to pr= ovide > extra information. > > What would be your suggestion? >=20 > I don't have any suggestion. > You are defining a new API in DPDK, so our concern must be to check > that it will be easily understood by users and PMD developers. > If you don't really know what this field will be for, others won't know. No, I meant it's device driver dependent.=20 If I keep the same naming convention following kernel ethtool defined, and adding comment like "device-specific magic key, such as device-id". Would that be acceptable from you? This data structure is defined to be compatible with kernel ethtool API, and magic key is device specific and known to ethtool API users.