From: Christian Hewitt <christianshewitt@gmail.com>
To: Gabriel Sanches <gabriel.sanches@prevas.dk>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] gateway: fix calculation of is_vpn6
Date: Fri, 14 Feb 2025 10:33:39 +0400 [thread overview]
Message-ID: <BFB720D7-E13D-44B8-A683-1467F9FCC187@gmail.com> (raw)
In-Reply-To: <DB6PR10MB1845EBB07DB785B580B3F6ECE1E02@DB6PR10MB1845.EURPRD10.PROD.OUTLOOK.COM>
> On 23 Jan 2025, at 3:38 pm, Gabriel Sanches <gabriel.sanches@prevas.dk> wrote:
>
> Fix is_vpn6 to use ipv6 variables not ipv4 variables. This stops
> the WireGuard plugin from faulting on startup.
>
> Fixes: commit 823d5a2a8cc4 ("connection: Refactor ‘__connman_connection_gateway_add’”)”
>
> Signed-of-by: Gabriel Sanches <gabriel.sanches@prevas.dk>
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
>
> ---
> src/gateway.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/gateway.c b/src/gateway.c
> index 16c87f83..b2c211e2 100644
> --- a/src/gateway.c
> +++ b/src/gateway.c
> @@ -3704,10 +3704,10 @@ int __connman_gateway_add(struct connman_service *service,
> is_gateway_config_vpn(
> new_gateway->ipv4_config);
>
> - is_vpn6 = do_ipv4 &&
> - new_gateway->ipv4_config &&
> + is_vpn6 = do_ipv6 &&
> + new_gateway->ipv6_config &&
> is_gateway_config_vpn(
> - new_gateway->ipv4_config);
> + new_gateway->ipv6_config);
>
> } else {
> if (do_ipv4 && new_gateway->ipv4_config)
> --
> 2.43.0
This fixes a complete breakage of the ConnMan plugin:
Tested-by: Christian Hewitt <christianshewitt@gmail.com>
next prev parent reply other threads:[~2025-02-14 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 11:38 [PATCH] gateway: fix calculation of is_vpn6 Gabriel Sanches
2025-01-24 13:20 ` daniel antoine
2025-02-14 6:33 ` Christian Hewitt [this message]
2025-02-14 16:02 ` Denis Kenzior
2025-02-21 16:15 ` Grant Erickson
2025-02-21 17:13 ` Grant Erickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BFB720D7-E13D-44B8-A683-1467F9FCC187@gmail.com \
--to=christianshewitt@gmail.com \
--cc=connman@lists.linux.dev \
--cc=gabriel.sanches@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.