From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel, Thomas" Subject: Re: [PATCH v4] drm/i915: Add soft-pinning API for execbuffer Date: Wed, 15 Jul 2015 15:41:49 +0000 Message-ID: References: <1425635047-25214-1-git-send-email-chris@chris-wilson.co.uk> <1435673593-28127-1-git-send-email-thomas.daniel@intel.com> <55A6745B.2000103@intel.com> <20150715150615.GJ9115@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B7F589CAC for ; Wed, 15 Jul 2015 08:41:52 -0700 (PDT) In-Reply-To: <20150715150615.GJ9115@nuc-i3427.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , "Goel, Akash" Cc: "Belgaumkar, Vinay" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IENocmlzIFdpbHNvbiBbbWFpbHRv OmNocmlzQGNocmlzLXdpbHNvbi5jby51a10KPiBTZW50OiBXZWRuZXNkYXksIEp1bHkgMTUsIDIw MTUgNDowNiBQTQo+IFRvOiBHb2VsLCBBa2FzaAo+IENjOiBEYW5pZWwsIFRob21hczsgaW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgQmVsZ2F1bWthciwgVmluYXk7Cj4gV2luaWFyc2tp LCBNaWNoYWw7IFpvdSwgTmFuaGFpCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NF0gZHJtL2k5MTU6 IEFkZCBzb2Z0LXBpbm5pbmcgQVBJIGZvciBleGVjYnVmZmVyCj4gCj4gT24gV2VkLCBKdWwgMTUs IDIwMTUgYXQgMDg6MjU6MjNQTSArMDUzMCwgR29lbCwgQWthc2ggd3JvdGU6Cj4gPiA+PitpbnQK PiA+ID4+K2k5MTVfZ2VtX2V2aWN0X2Zvcl92bWEoc3RydWN0IGk5MTVfdm1hICp0YXJnZXQpCj4g PiA+Pit7Cj4gPiA+PisJc3RydWN0IGRybV9tbV9ub2RlICpub2RlLCAqbmV4dDsKPiA+ID4+Kwo+ ID4gPj4rCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShub2RlLCBuZXh0LAo+ID4gPj4rCQkJJnRh cmdldC0+dm0tPm1tLmhlYWRfbm9kZS5ub2RlX2xpc3QsCj4gPiA+PisJCQlub2RlX2xpc3QpIHsK PiA+ID4+KwkJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gPiA+PisJCWludCByZXQ7Cj4gPiA+PisK PiA+ID4+KwkJaWYgKG5vZGUtPnN0YXJ0ICsgbm9kZS0+c2l6ZSA8PSB0YXJnZXQtPm5vZGUuc3Rh cnQpCj4gPiA+PisJCQljb250aW51ZTsKPiA+ID4+KwkJaWYgKG5vZGUtPnN0YXJ0ID49IHRhcmdl dC0+bm9kZS5zdGFydCArIHRhcmdldC0+bm9kZS5zaXplKQo+ID4gPj4rCQkJYnJlYWs7Cj4gPiA+ PisKPiA+ID4+KwkJdm1hID0gY29udGFpbmVyX29mKG5vZGUsIHR5cGVvZigqdm1hKSwgbm9kZSk7 Cj4gPiA+PisKPiA+ID4+KwkJaWYgKHZtYS0+cGluX2NvdW50KSB7Cj4gPiA+PisJCQkvKiBXZSBt YXkgbmVlZCB0byBldmljdCBhIGJ1ZmZlciBpbiB0aGUgc2FtZSBiYXRjaCAqLwo+ID4gPj4rCQkJ aWYgKCF2bWEtPmV4ZWNfZW50cnkpCj4gPiA+PisJCQkJcmV0dXJuIC1FQlVTWTsKPiA+ID4+Kwo+ ID4gPj4rCQkJaWYgKHZtYS0+ZXhlY19lbnRyeS0+ZmxhZ3MgJiBFWEVDX09CSkVDVF9QSU5ORUQp Cj4gPiA+PisJCQkJLyogT3ZlcmxhcHBpbmcgZml4ZWQgb2JqZWN0cyBpbiB0aGUgc2FtZSBiYXRj aAo+ID4gPj4qLwo+ID4gPj4rCQkJCXJldHVybiAtRUlOVkFMOwo+ID4gPj4rCj4gPiA+PisJCQly ZXR1cm4gLUVOT1NQQzsKPiA+Cj4gPiBDYW4gd2UgYWN0dWFsbHkgaGl0IHRoaXMgY29uZGl0aW9u LCBjb25zaWRlcmluZyB0aGUgc29mdCBwaW5uZWQKPiA+IG9iamVjdHMgYXJlIG5vdyBvbiB0aGUg ZnJvbnQgc2lkZSBvZiAnZWItPnZtYXMnIGxpc3QgPwo+ID4gSWYgd2UgZG8gZW5jb3VudGVyIHN1 Y2ggYSBjYXNlLCBpdCBwcm9iYWJseSBtZWFucyB0aGF0IHRoZQo+ID4gb3ZlcmxhcHBpbmcgb2Jq ZWN0IGlzIGFscmVhZHkgcGlubmVkIGZyb20gc29tZSBvdGhlciBwYXRoLgo+IAo+IE5vdGUgdGhh dCBzb2Z0cGlubmVkIG9iamVjdHMgYXJlIG9ubHkgZmlyc3Qgb24gdGhlIHNlY29uZCBwYXNzIHRo cm91Z2gKPiB0aGUgcmVzZXJ2YXRpb24uCkVoPyAgSSBtb2RpZmllZCBpOTE1X2dlbV9leGVjYnVm ZmVyX3Jlc2VydmUoKSB0byBhbHdheXMgcHV0IHRoZSBzb2Z0cGlubmVkIHZtYXMgZmlyc3Qgc28g dGhleSBzaG91bGQgbmV2ZXIgY29sbGlkZSB3aXRoIG9iamVjdHMgaW4gdGhlIHNhbWUgZXhlY2J1 ZmYuCgo+IAo+ID4gSXMgdGhlcmUgYSBzY29wZSBvZiBhbiBhZGRpdGlvbmFsIGNoZWNrIGhlcmUg Pwo+ID4gaS5lLiBpZiAodm1hLT5waW5fY291bnQpIGlzID4gMSwgdGhpcyBpbmRpY2F0ZXMgdGhh dCB0aGUgb2JqZWN0IGlzCj4gPiBub3Qgb25seSBwaW5uZWQgZHVlIHRvIGV4ZWNidWZmZXIsIGhl bmNlIGNhbm5vdCBiZSBldmljdGVkLCBzbwo+ID4gLUVCVVNZIGNhbiBiZSBzdHJhaWdodCBhd2F5 IHJldHVybmVkIHRvIFVzZXIuCj4gCj4gQ29uc2lkZXIgdGhpcyBpbnN0ZWFkOgo+IAo+IGludAo+ IGk5MTVfZ2VtX2V2aWN0X2Zvcl92bWEoc3RydWN0IGk5MTVfdm1hICp0YXJnZXQsIHVuc2lnbmVk IGZsYWdzKQo+IHsKPiAgICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgZXZpY3Rpb25fbGlzdDsKPiAg ICAgICAgIHN0cnVjdCBpbnRlcnZhbF90cmVlX25vZGUgKml0Owo+ICAgICAgICAgdTY0IGVuZCA9 IHRhcmdldC0+bm9kZS5zdGFydCArIHRhcmdldC0+bm9kZS5zaXplOwo+ICAgICAgICAgc3RydWN0 IGRybV9tbV9ub2RlICpub2RlOwo+ICAgICAgICAgc3RydWN0IGk5MTVfdm1hICp2bWEsICpuZXh0 Owo+ICAgICAgICAgaW50IHJldDsKPiAKPiAgICAgICAgIGl0ID0gaW50ZXJ2YWxfdHJlZV9pdGVy X2ZpcnN0KCZ0YXJnZXQtPnZtLT5tbS5pbnRlcnZhbF90cmVlLAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdGFyZ2V0LT5ub2RlLnN0YXJ0LCBlbmQgLTEpOwo+ICAgICAg ICAgaWYgKGl0ID09IE5VTEwpCj4gICAgICAgICAgICAgICAgIHJldHVybiAwOwo+IAo+ICAgICAg ICAgSU5JVF9MSVNUX0hFQUQoJmV2aWN0aW9uX2xpc3QpOwo+ICAgICAgICAgbm9kZSA9IGNvbnRh aW5lcl9vZihpdCwgdHlwZW9mKCpub2RlKSwgaXQpOwo+ICAgICAgICAgbGlzdF9mb3JfZWFjaF9l bnRyeV9mcm9tKG5vZGUsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnRhcmdl dC0+dm0tPm1tLmhlYWRfbm9kZS5ub2RlX2xpc3QsCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbm9kZV9saXN0KSB7Cj4gICAgICAgICAgICAgICAgIGlmIChub2RlLT5zdGFydCA+ PSBlbmQpCj4gICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gCj4gICAgICAgICAgICAg ICAgIHZtYSA9IGNvbnRhaW5lcl9vZihub2RlLCB0eXBlb2YoKnZtYSksIG5vZGUpOwo+ICAgICAg ICAgICAgICAgICBpZiAoZmxhZ3MgJiBQSU5fTk9OQkxPQ0sgJiYKPiAgICAgICAgICAgICAgICAg ICAgICh2bWEtPnBpbl9jb3VudCB8fCB2bWEtPmFjdGl2ZS5yZXF1ZXN0KSkgewo+ICAgICAgICAg ICAgICAgICAgICAgICAgIHJldCA9IC1FTk9TUEM7Cj4gICAgICAgICAgICAgICAgICAgICAgICAg YnJlYWs7Cj4gICAgICAgICAgICAgICAgIH0KPiAKPiAgICAgICAgICAgICAgICAgaWYgKHZtYS0+ ZXhlY19lbnRyeSAmJgo+ICAgICAgICAgICAgICAgICAgICAgdm1hLT5leGVjX2VudHJ5LT5mbGFn cyAmIEVYRUNfT0JKRUNUX1BJTk5FRCkgewo+ICAgICAgICAgICAgICAgICAgICAgICAgIC8qIE92 ZXJsYXBwaW5nIHBpbm5lZCBvYmplY3RzIGluIHRoZSBzYW1lIGJhdGNoICovCj4gICAgICAgICAg ICAgICAgICAgICAgICAgcmV0ID0gLUVJTlZBTDsKPiAgICAgICAgICAgICAgICAgICAgICAgICBi cmVhazsKPiAgICAgICAgICAgICAgICAgfQo+IAo+ICAgICAgICAgICAgICAgICBpZiAodm1hLT5w aW5fY291bnQpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAvKiBXZSBtYXkgbmVlZCB0byBl dmljdCBhbiBidWZmZXIgaW4gdGhlIHNhbWUgYmF0Y2ggKi8KPiAgICAgICAgICAgICAgICAgICAg ICAgICByZXQgPSB2bWEtPmV4ZWNfZW50cnkgPyAtRU5PU1BDIDogLUVCVVNZOwo+ICAgICAgICAg ICAgICAgICAgICAgICAgIGJyZWFrOwo+ICAgICAgICAgICAgICAgICB9Cj4gCj4gICAgICAgICAg ICAgICAgIGxpc3RfYWRkKCZ2bWEtPmV4ZWNfbGlzdCwgJmV2aWN0aW9uX2xpc3QpOwo+ICAgICAg ICAgICAgICAgICBkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2UoJnZtYS0+b2JqLT5iYXNlKTsKPiAg ICAgICAgIH0KPiAKPiAgICAgICAgIHJldCA9IDA7Cj4gICAgICAgICBsaXN0X2Zvcl9lYWNoX2Vu dHJ5X3NhZmUodm1hLCBuZXh0LCAmZXZpY3Rpb25fbGlzdCwgZXhlY19saXN0KSB7Cj4gICAgICAg ICAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmogPSB2bWEtPm9iajsKPiAg ICAgICAgICAgICAgICAgaWYgKHJldCA9PSAwKQo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJl dCA9IGk5MTVfdm1hX3VuYmluZCh2bWEpOwo+ICAgICAgICAgICAgICAgICBkcm1fZ2VtX29iamVj dF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgICAgICAgIH0KPiAKPiAgICAgICAgIHJldHVy biByZXQ7Cj4gfQo+IC1DaHJpcwpUaGlzIGNvbnRhaW5zIHNwZWNpYWwgc3R1ZmYgd2hpY2ggSSBk b24ndCBoYXZlIHZpc2liaWxpdHkgb2YgKG1tLmludGVydmFsX3RyZWUsIHZtYS5hY3RpdmUpLgoK VGhvbWFzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK