From: "Chen, Jiqian" <Jiqian.Chen@amd.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
"Huang, Ray" <Ray.Huang@amd.com>,
"Chen, Jiqian" <Jiqian.Chen@amd.com>
Subject: Re: [PATCH v8] vpci: Add resizable bar support
Date: Fri, 14 Feb 2025 03:32:00 +0000 [thread overview]
Message-ID: <BL1PR12MB5849CF146DFA8BD2761D1F4EE7FE2@BL1PR12MB5849.namprd12.prod.outlook.com> (raw)
In-Reply-To: <Z6sWnK1BYxArBq--@macbook.local>
On 2025/2/11 17:21, Roger Pau Monné wrote:
> On Tue, Feb 11, 2025 at 10:22:57AM +0800, Jiqian Chen wrote:
>> Some devices, like AMDGPU, support resizable bar capability,
>> but vpci of Xen doesn't support this feature, so they fail
>> to resize bars and then cause probing failure.
>>
>> According to PCIe spec, each bar that supports resizing has
>> two registers, PCI_REBAR_CAP and PCI_REBAR_CTRL. So, add
>> handlers to support resizing the size of BARs.
>>
>> Note that Xen will only trap PCI_REBAR_CTRL, as PCI_REBAR_CAP
>> is read-only register and the hardware domain already gets
>> access to it without needing any setup.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@amd.com>
>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thank you!
May I know whether this can be merged in Xen version 4.20?
>
>> ---
>> Hi all,
>> v7->v8 changes:
>> * Modified commit message and some comments.
>> * Deleted unused function vpci_hw_write32.
>>
>> Best regards,
>> Jiqian Chen.
>> ---
>> xen/drivers/vpci/Makefile | 2 +-
>> xen/drivers/vpci/rebar.c | 131 +++++++++++++++++++++++++++++++++++++
>> xen/include/xen/pci_regs.h | 15 +++++
>> xen/include/xen/vpci.h | 1 +
>> 4 files changed, 148 insertions(+), 1 deletion(-)
>> create mode 100644 xen/drivers/vpci/rebar.c
>>
>> diff --git a/xen/drivers/vpci/Makefile b/xen/drivers/vpci/Makefile
>> index 1a1413b93e76..a7c8a30a8956 100644
>> --- a/xen/drivers/vpci/Makefile
>> +++ b/xen/drivers/vpci/Makefile
>> @@ -1,2 +1,2 @@
>> -obj-y += vpci.o header.o
>> +obj-y += vpci.o header.o rebar.o
>> obj-$(CONFIG_HAS_PCI_MSI) += msi.o msix.o
>> diff --git a/xen/drivers/vpci/rebar.c b/xen/drivers/vpci/rebar.c
>> new file mode 100644
>> index 000000000000..794f1168adf8
>> --- /dev/null
>> +++ b/xen/drivers/vpci/rebar.c
>> @@ -0,0 +1,131 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/*
>> + * Copyright (C) 2025 Advanced Micro Devices, Inc. All Rights Reserved.
>> + *
>> + * Author: Jiqian Chen <Jiqian.Chen@amd.com>
>> + */
>> +
>> +#include <xen/sched.h>
>> +#include <xen/vpci.h>
>> +
>> +static void cf_check rebar_ctrl_write(const struct pci_dev *pdev,
>> + unsigned int reg,
>> + uint32_t val,
>> + void *data)
>> +{
>> + struct vpci_bar *bar = data;
>> + const unsigned int index = bar - pdev->vpci->header.bars;
>> + uint64_t size = PCI_REBAR_CTRL_SIZE(val);
>
> Since you define index as const you could also do the same with size.
> Can adjust at commit, but I also don't have a strong opinion about
> it.
Got it.
If there aren't other comments, then I don't need to send a new version, right?
>
> Thanks, Roger.
--
Best regards,
Jiqian Chen.
next prev parent reply other threads:[~2025-02-14 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 2:22 [PATCH v8] vpci: Add resizable bar support Jiqian Chen
2025-02-11 9:21 ` Roger Pau Monné
2025-02-14 3:32 ` Chen, Jiqian [this message]
2025-02-14 7:35 ` Jan Beulich
2025-02-14 8:18 ` Oleksii Kurochko
2025-02-14 8:22 ` Chen, Jiqian
2025-02-14 8:39 ` Roger Pau Monné
2025-02-14 9:01 ` Chen, Jiqian
2025-02-14 9:12 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR12MB5849CF146DFA8BD2761D1F4EE7FE2@BL1PR12MB5849.namprd12.prod.outlook.com \
--to=jiqian.chen@amd.com \
--cc=Ray.Huang@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.