From: Wang Haikun <Haikun.Wang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/4] arm: ls102xa: Enable Driver Model SPI for ls1021atwr
Date: Fri, 19 Jun 2015 07:50:47 +0000 [thread overview]
Message-ID: <BN1PR0301MB061251FCF24B815ADA684D5DF8A40@BN1PR0301MB0612.namprd03.prod.outlook.com> (raw)
In-Reply-To: CAD6G_RTcpDb22jKFYWjOD5CUcLEy4ts=ns_xxj+H1K0rErHg9Q@mail.gmail.com
On 6/19/2015 3:34 PM, Jagan Teki wrote:
> On 18 June 2015 at 12:24, Jagan Teki <jteki@openedev.com> wrote:
>> On 18 June 2015 at 07:50, Wang Haikun <Haikun.Wang@freescale.com> wrote:
>>> On 6/17/2015 8:30 PM, Simon Glass wrote:
>>>> Hi,
>>>>
>>>> On 17 June 2015 at 03:36, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>>> Hi Haikun,
>>>>>
>>>>> On Mon, May 18, 2015 at 9:25 PM, Haikun Wang <haikun.wang@freescale.com> wrote:
>>>>>> From: Haikun Wang <Haikun.Wang@freescale.com>
>>>>>>
>>>>>> Enable Driver Model SPI for ls1021atwr board.
>>>>>> DSPI and QSPI only be enabled when boot from QSPI.
>>>>>> DSPI and QSPI are compatible under Driver Model SPI.
>>>>>>
>>>>>> Signed-off-by: Haikun Wang <Haikun.Wang@freescale.com>
>>>>>> Change-Id: I6342807da7725ae8b678952117c8758c75a61d3d
>
> Where is this commit id? I couldn't see it on "git log"
Hi Jagan,
It is not a git commit ID, it is a code review task ID of gerrit in fact.
I'm sorry again for forgetting remove it when submit patch.
Best regards,
Wang Haikun
>
>>>>>> Reviewed-on: http://git.am.freescale.net:8181/33447>
>>> Best regards,
>>> Wang Haikun
>>>>
>>>>>
>>>>> Is this URL Freescale internal? I cannot access it.
>>>>>
>>>>
>>>> Looks like it. BTW patman will remove these Gerrit tags automatically.
>>> Yes, it is our internal URL.
>>> I forget to remove it.
>>> It couldn't be better if it will be removed automatically.
>>
>> I will remove if something not remove automatically.
>>
>> Anyone have any comments on these patch-set, I'm planning to take these.
>>
>> https://patchwork.ozlabs.org/patch/473391/
>> https://patchwork.ozlabs.org/patch/473392/
>> https://patchwork.ozlabs.org/patch/473393/
>> https://patchwork.ozlabs.org/patch/473394/
>>
>>>>>> Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
>>>>>> Reviewed-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>>>>>> ---
>>>>>> Changes in v3:
>>>>>> - IS_ENABLED(CONFIG_XXX) is only work with configure option in Kconfig,
>>>>>> and DM core code use IS_ENABLED(), so configure option in head file
>>>>>> can't work, so remove CONFIG_OF_CONTROL CONFIG_OF_SEPARATE CONFIG_DM CONFIG_DM_SPI
>>>>>>
>>>>>> Changes in v2:
>>>>>> - Move all changes inside of CONFIG_QSPI_BOOT
>>>>>>
>>>>>> Changes in v1: None
>>>>>> include/configs/ls1021atwr.h | 10 ++++++++--
>>>>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
>>>>>> index 729205f..13e3aa4 100644
>>>>>> --- a/include/configs/ls1021atwr.h
>>>>>> +++ b/include/configs/ls1021atwr.h
>>>>>> @@ -229,16 +229,22 @@
>>>>>> #define CONFIG_CMD_FAT
>>>>>> #define CONFIG_DOS_PARTITION
>>>>>>
>>>>>> -/* QSPI */
>>>>>> +/* SPI */
>>>>>> #ifdef CONFIG_QSPI_BOOT
>>>>>> +/* QSPI */
>>>>>> #define CONFIG_FSL_QSPI
>>>>>> #define QSPI0_AMBA_BASE 0x40000000
>>>>>> #define FSL_QSPI_FLASH_SIZE (1 << 24)
>>>>>> #define FSL_QSPI_FLASH_NUM 2
>>>>>>
>>>>>> +#define CONFIG_SPI_FLASH_STMICRO
>>>>>> +
>>>>>> +/* DM SPI */
>>>>>> +#if defined(CONFIG_FSL_DSPI) || defined(CONFIG_FSL_QSPI)
>>>>>> #define CONFIG_CMD_SF
>>>>>> +#define CONFIG_DM_SPI_FLASH
>>>>>> #define CONFIG_SPI_FLASH
>>>>>> -#define CONFIG_SPI_FLASH_STMICRO
>>>>>> +#endif
>>>>>> #endif
>>>>>>
>>>>>> /*
>
> thanks!
> --
> Jagan | openedev.
>
next prev parent reply other threads:[~2015-06-19 7:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:25 [U-Boot] [PATCH v3 4/4] arm: ls102xa: Enable Driver Model SPI for ls1021atwr Haikun Wang
2015-06-16 8:55 ` Jagan Teki
2015-06-17 9:11 ` Wang Haikun
2015-06-17 9:36 ` Bin Meng
2015-06-17 12:30 ` Simon Glass
2015-06-18 2:20 ` Wang Haikun
2015-06-18 6:54 ` Jagan Teki
2015-06-18 15:18 ` Simon Glass
2015-06-19 7:34 ` Jagan Teki
2015-06-19 7:50 ` Wang Haikun [this message]
2015-06-19 8:14 ` Jagan Teki
2015-06-25 13:24 ` Jagan Teki
2015-06-26 3:13 ` Wang Haikun
2015-06-26 6:43 ` Jagan Teki
2015-06-26 8:18 ` Wang Haikun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN1PR0301MB061251FCF24B815ADA684D5DF8A40@BN1PR0301MB0612.namprd03.prod.outlook.com \
--to=haikun.wang@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.