* [PATCH] drm/i915: Remove dead code from gen8_pte_encode
@ 2023-07-07 12:46 ` Tvrtko Ursulin
0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2023-07-07 12:46 UTC (permalink / raw
To: Intel-gfx, dri-devel; +Cc: Matt Roper, Andi Shyti, Fei Yang, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
bit from gen8_pte_encode.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
Cc: Fei Yang <fei.yang@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
index f948d33e5ec5..c8568e5d1147 100644
--- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
@@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
if (unlikely(flags & PTE_READ_ONLY))
pte &= ~GEN8_PAGE_RW;
- if (flags & PTE_LM)
- pte |= GEN12_PPGTT_PTE_LM;
-
/*
* For pre-gen12 platforms pat_index is the same as enum
* i915_cache_level, so the switch-case here is still valid.
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
@ 2023-07-07 12:46 ` Tvrtko Ursulin
0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2023-07-07 12:46 UTC (permalink / raw
To: Intel-gfx, dri-devel; +Cc: Matt Roper
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
bit from gen8_pte_encode.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
Cc: Fei Yang <fei.yang@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
index f948d33e5ec5..c8568e5d1147 100644
--- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
+++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
@@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
if (unlikely(flags & PTE_READ_ONLY))
pte &= ~GEN8_PAGE_RW;
- if (flags & PTE_LM)
- pte |= GEN12_PPGTT_PTE_LM;
-
/*
* For pre-gen12 platforms pat_index is the same as enum
* i915_cache_level, so the switch-case here is still valid.
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
(?)
@ 2023-07-07 14:17 ` Rodrigo Vivi
2023-07-10 9:25 ` Tvrtko Ursulin
-1 siblings, 1 reply; 11+ messages in thread
From: Rodrigo Vivi @ 2023-07-07 14:17 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: Intel-gfx, Matt Roper, dri-devel
On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
> bit from gen8_pte_encode.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> index f948d33e5ec5..c8568e5d1147 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
> if (unlikely(flags & PTE_READ_ONLY))
> pte &= ~GEN8_PAGE_RW;
>
> - if (flags & PTE_LM)
> - pte |= GEN12_PPGTT_PTE_LM;
> -
> /*
> * For pre-gen12 platforms pat_index is the same as enum
> * i915_cache_level, so the switch-case here is still valid.
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
(?)
(?)
@ 2023-07-07 14:30 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-07-07 14:30 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14110 bytes --]
== Series Details ==
Series: drm/i915: Remove dead code from gen8_pte_encode
URL : https://patchwork.freedesktop.org/series/120342/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13355 -> Patchwork_120342v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/index.html
Participating hosts (39 -> 40)
------------------------------
Additional (2): fi-skl-guc bat-mtlp-8
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_120342v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-mtlp-8: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@debugfs_test@basic-hwmon.html
- bat-adlp-11: NOTRUN -> [SKIP][2] ([i915#7456])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@debugfs_test@basic-hwmon.html
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/fi-skl-guc/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-8: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@gem_lmem_swapping@verify-random.html
* igt@gem_mmap@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][6] ([i915#4077]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@gem_mmap_gtt@basic.html
* igt@gem_render_tiled_blits@basic:
- bat-mtlp-8: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@gem_render_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-adlp-11: NOTRUN -> [SKIP][8] ([i915#3282])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-adlp-11: NOTRUN -> [SKIP][9] ([i915#3546] / [i915#7561])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- bat-adlp-11: NOTRUN -> [ABORT][10] ([i915#7977] / [i915#8434] / [i915#8668])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rps@basic-api:
- bat-mtlp-8: NOTRUN -> [SKIP][11] ([i915#6621])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_lrc:
- bat-dg2-11: [PASS][12] -> [INCOMPLETE][13] ([i915#7609] / [i915#7913])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-dg2-11/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_mocs:
- bat-rpls-1: [PASS][14] -> [DMESG-FAIL][15] ([i915#7059])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [PASS][16] -> [ABORT][17] ([i915#7913] / [i915#7982])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-rpls-2/igt@i915_selftest@live@requests.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rpls-2/igt@i915_selftest@live@requests.html
- bat-mtlp-6: [PASS][18] -> [DMESG-FAIL][19] ([i915#7269])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-mtlp-6/igt@i915_selftest@live@requests.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][20] ([i915#6367])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-mtlp-8: NOTRUN -> [SKIP][21] ([i915#6645])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][22] ([i915#5190])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-mtlp-8: NOTRUN -> [SKIP][23] ([i915#4212]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- bat-adlp-11: NOTRUN -> [SKIP][24] ([i915#7828]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_chamelium_frames@hdmi-crc-fast.html
- bat-mtlp-8: NOTRUN -> [SKIP][25] ([i915#7828]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-11: NOTRUN -> [SKIP][26] ([i915#4103]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
- bat-mtlp-8: NOTRUN -> [SKIP][27] ([i915#4213]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-adlp-11: NOTRUN -> [SKIP][28] ([i915#3637])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-mtlp-8: NOTRUN -> [SKIP][29] ([fdo#109285])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-11: NOTRUN -> [SKIP][30] ([i915#4093]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_force_connector_basic@prune-stale-modes.html
- bat-mtlp-8: NOTRUN -> [SKIP][31] ([i915#5274])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_force_connector_basic@prune-stale-modes.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2:
- fi-skl-guc: NOTRUN -> [SKIP][32] ([fdo#109271]) +20 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence:
- bat-adlp-11: NOTRUN -> [SKIP][33] ([i915#3546])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [PASS][34] -> [ABORT][35] ([i915#8442] / [i915#8668])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
* igt@kms_pipe_crc_basic@read-crc@pipe-d-dp-5:
- bat-adlp-11: NOTRUN -> [DMESG-WARN][36] ([i915#6868]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc@pipe-d-dp-5.html
* igt@kms_psr@primary_page_flip:
- bat-adlp-11: NOTRUN -> [SKIP][37] ([i915#1072]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adlp-11: NOTRUN -> [SKIP][38] ([i915#3555])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@kms_setmode@basic-clone-single-crtc.html
- bat-mtlp-8: NOTRUN -> [SKIP][39] ([i915#8809])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-mmap:
- bat-mtlp-8: NOTRUN -> [SKIP][40] ([i915#3708] / [i915#4077]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-fence-read:
- bat-mtlp-8: NOTRUN -> [SKIP][41] ([i915#3708]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* igt@i915_module_load@load:
- bat-adlp-11: [ABORT][42] ([i915#4423]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-adlp-11/igt@i915_module_load@load.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_selftest@live@mman:
- bat-rpls-1: [TIMEOUT][44] ([i915#6794] / [i915#7392]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-rpls-1/igt@i915_selftest@live@mman.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rpls-1/igt@i915_selftest@live@mman.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-1: [WARN][46] ([i915#8747]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/bat-rpls-1/igt@i915_suspend@basic-s2idle-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7269]: https://gitlab.freedesktop.org/drm/intel/issues/7269
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7609]: https://gitlab.freedesktop.org/drm/intel/issues/7609
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8747]: https://gitlab.freedesktop.org/drm/intel/issues/8747
[i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
Build changes
-------------
* Linux: CI_DRM_13355 -> Patchwork_120342v1
CI-20190529: 20190529
CI_DRM_13355: 8f40aae3b99ac28dd81d00933f5dc9124dbfc881 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7377: d1574543ba4bb322597345530053475c07be0eb9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120342v1: 8f40aae3b99ac28dd81d00933f5dc9124dbfc881 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
e1fe34823949 drm/i915: Remove dead code from gen8_pte_encode
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/index.html
[-- Attachment #2: Type: text/html, Size: 16277 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH] drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
@ 2023-07-07 17:13 ` Yang, Fei
-1 siblings, 0 replies; 11+ messages in thread
From: Yang, Fei @ 2023-07-07 17:13 UTC (permalink / raw
To: Tvrtko Ursulin, Intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: Roper, Matthew D, Andi Shyti, Ursulin, Tvrtko
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> added a dedicated gen12_pte_encode but forgot to remove the Gen12
> specific bit from gen8_pte_encode.
Reviewed-by: Fei Yang <fei.yang@intel.com>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> index f948d33e5ec5..c8568e5d1147 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
> if (unlikely(flags & PTE_READ_ONLY))
> pte &= ~GEN8_PAGE_RW;
>
> - if (flags & PTE_LM)
> - pte |= GEN12_PPGTT_PTE_LM;
> -
> /*
> * For pre-gen12 platforms pat_index is the same as enum
> * i915_cache_level, so the switch-case here is still valid.
> --
> 2.39.2
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
@ 2023-07-07 17:13 ` Yang, Fei
0 siblings, 0 replies; 11+ messages in thread
From: Yang, Fei @ 2023-07-07 17:13 UTC (permalink / raw
To: Tvrtko Ursulin, Intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Cc: Roper, Matthew D
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> added a dedicated gen12_pte_encode but forgot to remove the Gen12
> specific bit from gen8_pte_encode.
Reviewed-by: Fei Yang <fei.yang@intel.com>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> index f948d33e5ec5..c8568e5d1147 100644
> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
> if (unlikely(flags & PTE_READ_ONLY))
> pte &= ~GEN8_PAGE_RW;
>
> - if (flags & PTE_LM)
> - pte |= GEN12_PPGTT_PTE_LM;
> -
> /*
> * For pre-gen12 platforms pat_index is the same as enum
> * i915_cache_level, so the switch-case here is still valid.
> --
> 2.39.2
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
` (3 preceding siblings ...)
(?)
@ 2023-07-07 18:03 ` Patchwork
-1 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-07-07 18:03 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 31036 bytes --]
== Series Details ==
Series: drm/i915: Remove dead code from gen8_pte_encode
URL : https://patchwork.freedesktop.org/series/120342/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13355_full -> Patchwork_120342v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (9 -> 9)
------------------------------
No changes in participating hosts
New tests
---------
New tests have been introduced between CI_DRM_13355_full and Patchwork_120342v1_full:
### New IGT tests (4) ###
* igt@kms_flip@2x-absolute-wf_vblank@ab-vga1-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_flip@2x-flip-vs-dpms@ab-vga1-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible@ab-vga1-hdmi-a1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_flip@absolute-wf_vblank@d-hdmi-a2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_120342v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_fdinfo@virtual-busy-all:
- shard-mtlp: NOTRUN -> [SKIP][1] ([i915#8414])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@drm_fdinfo@virtual-busy-all.html
* igt@drm_fdinfo@virtual-idle:
- shard-rkl: [PASS][2] -> [FAIL][3] ([i915#7742])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-7/igt@drm_fdinfo@virtual-idle.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-6/igt@drm_fdinfo@virtual-idle.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-dg2: [PASS][4] -> [DMESG-WARN][5] ([i915#8224])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-12/igt@gem_barrier_race@remote-request@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-12/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_create@hog-create@smem0:
- shard-dg2: [PASS][6] -> [FAIL][7] ([i915#5892] / [i915#8758])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-8/igt@gem_create@hog-create@smem0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@gem_create@hog-create@smem0.html
* igt@gem_exec_await@wide-contexts:
- shard-dg2: [PASS][8] -> [FAIL][9] ([i915#5892])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-8/igt@gem_exec_await@wide-contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@gem_exec_await@wide-contexts.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-rkl: [PASS][12] -> [FAIL][13] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-tglu: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-tglu-2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-range:
- shard-mtlp: NOTRUN -> [SKIP][16] ([i915#3281])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@gem_exec_reloc@basic-range.html
* igt@gem_exec_schedule@deep@vcs0:
- shard-mtlp: [PASS][17] -> [FAIL][18] ([i915#8606])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-7/igt@gem_exec_schedule@deep@vcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@gem_exec_schedule@deep@vcs0.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-mtlp: [PASS][19] -> [FAIL][20] ([i915#6363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-3/igt@gem_exec_whisper@basic-forked-all.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-7/igt@gem_exec_whisper@basic-forked-all.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [PASS][21] -> [TIMEOUT][22] ([i915#5493])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-7/igt@gem_lmem_swapping@smem-oom@lmem0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-7/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_mmap_gtt@fault-concurrent:
- shard-mtlp: NOTRUN -> [SKIP][23] ([i915#4077]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@gem_mmap_gtt@fault-concurrent.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [PASS][24] -> [SKIP][25] ([i915#1397]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-3/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-10/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
- shard-rkl: [PASS][26] -> [SKIP][27] ([i915#1397]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_selftest@live@migrate:
- shard-mtlp: [PASS][28] -> [DMESG-FAIL][29] ([i915#7699])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-3/igt@i915_selftest@live@migrate.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-7/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- shard-mtlp: [PASS][30] -> [DMESG-FAIL][31] ([i915#8497])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-3/igt@i915_selftest@live@requests.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-7/igt@i915_selftest@live@requests.html
* igt@kms_async_flips@crc@pipe-a-hdmi-a-2:
- shard-dg2: NOTRUN -> [FAIL][32] ([i915#8247]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-2/igt@kms_async_flips@crc@pipe-a-hdmi-a-2.html
* igt@kms_async_flips@crc@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [FAIL][33] ([i915#8247]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-7/igt@kms_async_flips@crc@pipe-b-hdmi-a-1.html
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglu: NOTRUN -> [SKIP][34] ([i915#404])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-7/igt@kms_atomic@plane-primary-overlay-mutable-zpos.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-mtlp: [PASS][35] -> [FAIL][36] ([i915#3743]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-mtlp: NOTRUN -> [SKIP][37] ([fdo#111615])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][38] ([i915#6095]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][39] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-7/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#4087] / [i915#7213]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-5/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-3.html
* igt@kms_chamelium_edid@vga-edid-read:
- shard-tglu: NOTRUN -> [SKIP][41] ([i915#7828])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-7/igt@kms_chamelium_edid@vga-edid-read.html
* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#7118]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-7/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@lic@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][43] ([i915#7173])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@kms_content_protection@lic@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-mtlp: NOTRUN -> [SKIP][44] ([i915#8814])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_cursor_crc@cursor-onscreen-32x32.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-mtlp: [PASS][45] -> [FAIL][46] ([i915#8248])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][47] ([i915#3804])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-7/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [PASS][48] -> [FAIL][49] ([i915#79]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#2672])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-dg2: [PASS][51] -> [FAIL][52] ([i915#6880]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render:
- shard-mtlp: NOTRUN -> [SKIP][53] ([i915#1825]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][54] ([i915#8292])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-6/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#5176]) +7 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-9/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-a-dp-4.html
* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][56] ([i915#5176]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-7/igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][57] ([i915#5235]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-6/igt@kms_plane_scaling@planes-downscale-factor-0-25-unity-scaling@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][58] ([fdo#109271]) +17 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-snb7/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-vga-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4:
- shard-dg2: NOTRUN -> [SKIP][59] ([i915#5235]) +19 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-dp-4.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][60] ([i915#5235]) +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-d-edp-1.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-dg2: [PASS][61] -> [FAIL][62] ([fdo#103375] / [i915#6121])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vrr@flip-suspend:
- shard-dg2: NOTRUN -> [SKIP][63] ([i915#3555])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-7/igt@kms_vrr@flip-suspend.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [PASS][64] -> [FAIL][65] ([i915#7484])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-8/igt@perf@non-zero-reason@0-rcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@perf@non-zero-reason@0-rcs0.html
* igt@v3d/v3d_submit_csd@bad-perfmon:
- shard-mtlp: NOTRUN -> [SKIP][66] ([i915#2575])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@v3d/v3d_submit_csd@bad-perfmon.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][67] ([i915#7742]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-4/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-tglu: [ABORT][69] ([i915#8211] / [i915#8234]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-tglu-4/igt@gem_barrier_race@remote-request@rcs0.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-7/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_eio@kms:
- shard-dg2: [INCOMPLETE][71] ([i915#1982] / [i915#7892]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-3/igt@gem_eio@kms.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-6/igt@gem_eio@kms.html
* igt@gem_eio@unwedge-stress:
- {shard-dg1}: [FAIL][73] ([i915#5784]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg1-12/igt@gem_eio@unwedge-stress.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg1-16/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][77] ([i915#2842]) -> [PASS][78] +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-7/igt@gem_exec_fair@basic-throttle@rcs0.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-7/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-mtlp: [ABORT][79] ([i915#8131]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-7/igt@gem_exec_whisper@basic-contexts-forked-all.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-5/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- {shard-dg1}: [FAIL][81] ([i915#3591]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg1-15/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg1-18/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][83] ([i915#1397]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg1-18/igt@i915_pm_rpm@modeset-lpsp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [SKIP][85] ([i915#1397]) -> [PASS][86] +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-6/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rpm@system-suspend:
- {shard-dg1}: [DMESG-WARN][87] ([i915#4391]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg1-19/igt@i915_pm_rpm@system-suspend.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg1-12/igt@i915_pm_rpm@system-suspend.html
* igt@i915_selftest@live@slpc:
- shard-mtlp: [DMESG-WARN][89] ([i915#6367]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-3/igt@i915_selftest@live@slpc.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-7/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@debugfs-reader:
- shard-dg2: [FAIL][91] ([fdo#103375] / [i915#6121]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-5/igt@i915_suspend@debugfs-reader.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-11/igt@i915_suspend@debugfs-reader.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-mtlp: [FAIL][93] ([i915#5138]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-4/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-rkl: [FAIL][95] ([i915#3743]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-dg2: [SKIP][97] ([i915#4087] / [i915#7213]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-6/igt@kms_cdclk@mode-transition-all-outputs.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-9/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_cursor_legacy@single-bo@all-pipes:
- shard-mtlp: [DMESG-WARN][99] ([i915#2017]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-4/igt@kms_cursor_legacy@single-bo@all-pipes.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-8/igt@kms_cursor_legacy@single-bo@all-pipes.html
* igt@kms_vblank@pipe-d-wait-forked:
- {shard-dg1}: [DMESG-WARN][101] ([i915#4391] / [i915#4423]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg1-15/igt@kms_vblank@pipe-d-wait-forked.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg1-18/igt@kms_vblank@pipe-d-wait-forked.html
#### Warnings ####
* igt@gem_ccs@ctrl-surf-copy-new-ctx:
- shard-glk: [SKIP][103] ([fdo#109271]) -> [INCOMPLETE][104] ([i915#2295])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-glk8/igt@gem_ccs@ctrl-surf-copy-new-ctx.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-glk1/igt@gem_ccs@ctrl-surf-copy-new-ctx.html
* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-mtlp: [FAIL][105] ([i915#6363]) -> [TIMEOUT][106] ([i915#7392])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-8/igt@gem_exec_whisper@basic-contexts-priority-all.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-3/igt@gem_exec_whisper@basic-contexts-priority-all.html
* igt@i915_pm_rc6_residency@rc6-idle@bcs0:
- shard-tglu: [WARN][107] ([i915#2681]) -> [FAIL][108] ([i915#2681] / [i915#3591])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-tglu-4/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@bcs0.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-tglu: [FAIL][109] ([i915#2681] / [i915#3591]) -> [WARN][110] ([i915#2681])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-tglu-4/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@kms_async_flips@crc@pipe-b-edp-1:
- shard-mtlp: [FAIL][111] ([i915#8247]) -> [DMESG-FAIL][112] ([i915#8561])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-2/igt@kms_async_flips@crc@pipe-b-edp-1.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-6/igt@kms_async_flips@crc@pipe-b-edp-1.html
* igt@kms_async_flips@crc@pipe-c-edp-1:
- shard-mtlp: [DMESG-FAIL][113] ([i915#8561]) -> [FAIL][114] ([i915#8247])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-mtlp-2/igt@kms_async_flips@crc@pipe-c-edp-1.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-mtlp-6/igt@kms_async_flips@crc@pipe-c-edp-1.html
* igt@kms_dsc@dsc-with-formats:
- shard-tglu: [SKIP][115] ([i915#3555]) -> [SKIP][116] ([i915#3555] / [i915#3840]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-tglu-4/igt@kms_dsc@dsc-with-formats.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-tglu-7/igt@kms_dsc@dsc-with-formats.html
* igt@kms_dsc@dsc-with-output-formats:
- shard-dg2: [SKIP][117] ([i915#3555]) -> [SKIP][118] ([i915#3555] / [i915#3840]) +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-dg2-1/igt@kms_dsc@dsc-with-output-formats.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-dg2-12/igt@kms_dsc@dsc-with-output-formats.html
- shard-rkl: [SKIP][119] ([i915#3555]) -> [SKIP][120] ([i915#3555] / [i915#3840]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-6/igt@kms_dsc@dsc-with-output-formats.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-4/igt@kms_dsc@dsc-with-output-formats.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][121] ([fdo#109285]) -> [SKIP][122] ([fdo#109285] / [i915#4098])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13355/shard-rkl-6/igt@kms_force_connector_basic@force-load-detect.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/shard-rkl-4/igt@kms_force_connector_basic@force-load-detect.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#5138]: https://gitlab.freedesktop.org/drm/intel/issues/5138
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6121]: https://gitlab.freedesktop.org/drm/intel/issues/6121
[i915#6363]: https://gitlab.freedesktop.org/drm/intel/issues/6363
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7892]: https://gitlab.freedesktop.org/drm/intel/issues/7892
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8224]: https://gitlab.freedesktop.org/drm/intel/issues/8224
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8561]: https://gitlab.freedesktop.org/drm/intel/issues/8561
[i915#8606]: https://gitlab.freedesktop.org/drm/intel/issues/8606
[i915#8709]: https://gitlab.freedesktop.org/drm/intel/issues/8709
[i915#8758]: https://gitlab.freedesktop.org/drm/intel/issues/8758
[i915#8814]: https://gitlab.freedesktop.org/drm/intel/issues/8814
Build changes
-------------
* Linux: CI_DRM_13355 -> Patchwork_120342v1
CI-20190529: 20190529
CI_DRM_13355: 8f40aae3b99ac28dd81d00933f5dc9124dbfc881 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7377: d1574543ba4bb322597345530053475c07be0eb9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_120342v1: 8f40aae3b99ac28dd81d00933f5dc9124dbfc881 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120342v1/index.html
[-- Attachment #2: Type: text/html, Size: 35860 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 14:17 ` Rodrigo Vivi
@ 2023-07-10 9:25 ` Tvrtko Ursulin
0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2023-07-10 9:25 UTC (permalink / raw
To: Rodrigo Vivi; +Cc: Intel-gfx, Matt Roper, Fei Yang, dri-devel
On 07/07/2023 15:17, Rodrigo Vivi wrote:
> On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
>> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
>> bit from gen8_pte_encode.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
>> Cc: Fei Yang <fei.yang@intel.com>
>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed, thanks for the reviews!
Regards,
Tvrtko
>
>> ---
>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> index f948d33e5ec5..c8568e5d1147 100644
>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
>> if (unlikely(flags & PTE_READ_ONLY))
>> pte &= ~GEN8_PAGE_RW;
>>
>> - if (flags & PTE_LM)
>> - pte |= GEN12_PPGTT_PTE_LM;
>> -
>> /*
>> * For pre-gen12 platforms pat_index is the same as enum
>> * i915_cache_level, so the switch-case here is still valid.
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
@ 2023-07-10 9:25 ` Tvrtko Ursulin
0 siblings, 0 replies; 11+ messages in thread
From: Tvrtko Ursulin @ 2023-07-10 9:25 UTC (permalink / raw
To: Rodrigo Vivi; +Cc: Intel-gfx, Matt Roper, dri-devel
On 07/07/2023 15:17, Rodrigo Vivi wrote:
> On Fri, Jul 07, 2023 at 01:46:44PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
>> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
>> bit from gen8_pte_encode.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
>> Cc: Fei Yang <fei.yang@intel.com>
>> Cc: Andi Shyti <andi.shyti@linux.intel.com>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Pushed, thanks for the reviews!
Regards,
Tvrtko
>
>> ---
>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> index f948d33e5ec5..c8568e5d1147 100644
>> --- a/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> +++ b/drivers/gpu/drm/i915/gt/gen8_ppgtt.c
>> @@ -37,9 +37,6 @@ static u64 gen8_pte_encode(dma_addr_t addr,
>> if (unlikely(flags & PTE_READ_ONLY))
>> pte &= ~GEN8_PAGE_RW;
>>
>> - if (flags & PTE_LM)
>> - pte |= GEN12_PPGTT_PTE_LM;
>> -
>> /*
>> * For pre-gen12 platforms pat_index is the same as enum
>> * i915_cache_level, so the switch-case here is still valid.
>> --
>> 2.39.2
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: Remove dead code from gen8_pte_encode
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
@ 2023-07-10 9:35 ` Andi Shyti
-1 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2023-07-10 9:35 UTC (permalink / raw
To: Tvrtko Ursulin
Cc: Fei Yang, Tvrtko Ursulin, Intel-gfx, dri-devel, Andi Shyti,
Matt Roper
Hi Tvrtko,
> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
> bit from gen8_pte_encode.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove dead code from gen8_pte_encode
@ 2023-07-10 9:35 ` Andi Shyti
0 siblings, 0 replies; 11+ messages in thread
From: Andi Shyti @ 2023-07-10 9:35 UTC (permalink / raw
To: Tvrtko Ursulin; +Cc: Intel-gfx, dri-devel, Matt Roper
Hi Tvrtko,
> Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> added a dedicated gen12_pte_encode but forgot to remove the Gen12 specific
> bit from gen8_pte_encode.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Fixes: 9275277d5324 ("drm/i915: use pat_index instead of cache_level")
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-07-10 9:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 12:46 [PATCH] drm/i915: Remove dead code from gen8_pte_encode Tvrtko Ursulin
2023-07-07 12:46 ` [Intel-gfx] " Tvrtko Ursulin
2023-07-07 14:17 ` Rodrigo Vivi
2023-07-10 9:25 ` Tvrtko Ursulin
2023-07-10 9:25 ` Tvrtko Ursulin
2023-07-07 14:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-07-07 17:13 ` [PATCH] " Yang, Fei
2023-07-07 17:13 ` [Intel-gfx] " Yang, Fei
2023-07-07 18:03 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2023-07-10 9:35 ` [PATCH] " Andi Shyti
2023-07-10 9:35 ` [Intel-gfx] " Andi Shyti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.