From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars Kurth Subject: Re: [v7][PATCH 00/16] Fix RMRR Date: Thu, 16 Jul 2015 10:45:35 +0100 Message-ID: References: <1436420047-25356-1-git-send-email-tiejun.chen@intel.com> <55A77F950200007800091AEC@mail.emea.novell.com> <55A76560.4090302@intel.com> <55A7828E0200007800091B2A@mail.emea.novell.com> <1437035454.32371.131.camel@citrix.com> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1437035454.32371.131.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Wei Liu , George Dunlap , Ian Jackson , "xen-devel@lists.xen.org" , Jan Beulich , Tiejun Chen List-Id: xen-devel@lists.xenproject.org > On 16 Jul 2015, at 09:30, Ian Campbell wrote: > > On Thu, 2015-07-16 at 09:08 +0100, Jan Beulich wrote: >> >>> >>> Does this imply this is already reviewed? >> >> No, that would be expressed by Reviewed-by. Acked-by merely >> means no objection by the maintainer for the change to go in. > > For my part I, perhaps wrongly, use Acked-by for both. If I haven't > actually carefully reviewed the change I will usually say so, e.g. "I > see XXX has reviewed this already, so that's fine by me" or something > similar (which I admit gets lost once it becomes just the tags). > > I can't speak for Ian or Wei (now CCd) but Ian at least I think operates > similarly. > > Ian. We shouldn't have an argument about this now. I wrote some scripts yesterday to track Acked-by and Reviewed-by and it is clear that these two tags are not consistently used at the moment. Maybe something to pick up in 2 weeks Regards Lars