All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed

From: daniel antoine <univac55@gmail.com>
To: Gabriel Sanches <gabriel.sanches@prevas.dk>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] gateway: fix calculation of is_vpn6
Date: Fri, 24 Jan 2025 14:20:51 +0100	[thread overview]
Message-ID: <CA+iibzCNbo26XnW4_2fR3WvnPpe1g4sV_Qrr6GH--2xwgQ180g@mail.gmail.com> (raw)
In-Reply-To: <DB6PR10MB1845EBB07DB785B580B3F6ECE1E02@DB6PR10MB1845.EURPRD10.PROD.OUTLOOK.COM>

Hi

I have installed the patch but I am not sure about the config file in
/usr/lib/connman-vpn

does it look like this
[provider_wireguard]
Type = WireGuard
Name = Wireguard VPN Tunnel
Host = 3.2.5.6
Domain = my.home.network
WireGuard.Address = 10.2.0.2/24
WireGuard.ListenPort = 47824
WireGuard.DNS = 10.2.0.1
WireGuard.PrivateKey = qKIj010hDdWSjQQyVCnEgthLXusBgm3I6HWrJUaJymc=
WireGuard.PublicKey = zzqUfWGIil6QxrAGz77HE5BGUEdD2PgHYnCg3CDKagE=
WireGuard.AllowedIPs = 0.0.0.0/0, ::/0
WireGuard.EndpointPort = 51820

I am not sure if the options Domain WireGuard.DNS and
WireGuard.ListenPort are mandatory. The host must be an Ip address or
a name like mysite.fr ?

Best regards

Daniel

Le jeu. 23 janv. 2025 à 12:38, Gabriel Sanches
<gabriel.sanches@prevas.dk> a écrit :
>
> Fix is_vpn6 to use ipv6 variables not ipv4 variables. This stops
> the WireGuard plugin from faulting on startup.
>
> Fixes: commit 823d5a2a8cc4 ("connection: Refactor ‘__connman_connection_gateway_add’”)”
>
> Signed-of-by: Gabriel Sanches <gabriel.sanches@prevas.dk>
> Tested-by: Christian Hewitt <christianshewitt@gmail.com>
>
> ---
>  src/gateway.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/gateway.c b/src/gateway.c
> index 16c87f83..b2c211e2 100644
> --- a/src/gateway.c
> +++ b/src/gateway.c
> @@ -3704,10 +3704,10 @@ int __connman_gateway_add(struct connman_service *service,
>                                          is_gateway_config_vpn(
>                                                  new_gateway->ipv4_config);
>
> -               is_vpn6 = do_ipv4 &&
> -                                       new_gateway->ipv4_config &&
> +               is_vpn6 = do_ipv6 &&
> +                                       new_gateway->ipv6_config &&
>                                          is_gateway_config_vpn(
> -                                               new_gateway->ipv4_config);
> +                                               new_gateway->ipv6_config);
>
>          } else {
>                  if (do_ipv4 && new_gateway->ipv4_config)
> --
> 2.43.0

next prev parent reply	other threads:[~2025-01-24 13:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 11:38 [PATCH] gateway: fix calculation of is_vpn6 Gabriel Sanches
2025-01-24 13:20 ` daniel antoine [this message]
2025-02-14  6:33 ` Christian Hewitt
2025-02-14 16:02 ` Denis Kenzior
2025-02-21 16:15   ` Grant Erickson
2025-02-21 17:13     ` Grant Erickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+iibzCNbo26XnW4_2fR3WvnPpe1g4sV_Qrr6GH--2xwgQ180g@mail.gmail.com \
    --to=univac55@gmail.com \
    --cc=connman@lists.linux.dev \
    --cc=gabriel.sanches@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.