From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Borzenkov Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 Date: Fri, 30 Oct 2015 13:07:58 +0300 Message-ID: References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> <56323A72.3000905@gmail.com> <56333D6A.2080506@gmail.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56333D6A.2080506@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Vladimir_=27=CF=86=2Dcoder=2Fphcoder=27_Serbinenko?= Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Stefano Stabellini , Jon Masters , Leif Lindholm , Ryan Harkin , Linaro UEFI Mailman List , Fu Wei List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBPY3QgMzAsIDIwMTUgYXQgMTI6NTAgUE0sIFZsYWRpbWlyICfPhi1jb2Rlci9waGNv ZGVyJwpTZXJiaW5lbmtvIDxwaGNvZGVyQGdtYWlsLmNvbT4gd3JvdGU6Cj4+Cj4+IEJ1dCBob3cg dG8gZGVhbCB3aXRoIHhlbl9pbml0cmQgPwo+PiBDb3VsZCB5b3UgaGVscCBtZSA/Cj4+Cj4gSnVz dCBhbm90aGVyIGFsaWFzIHRvIG1vZHVsZS4gUG9zc2libHkgeW91IG1pZ2h0IHdhbnQgdG8gYWRk IGEgY29kZSB0bwo+IHhlbl9pbml0cmQgdHRvIGNoZWNrIHRoYXQgeGVuX2xpbnV4IHdhcyBhbHJl YWR5IHJ1bgoKSSB0aGluayB3ZSBuZWVkIHRvIGJlIGNhcmVmdWwgaGVyZS4gV2UgbmVlZCB0byB0 aGluayBhYm91dCBmdXR1cmUKZXh0ZW5zdGlvbnMgKGluIHBhcnRpY3VsYXIgdG8gb3RoZXIgYXJj aGl0ZWN0dXJlcykgYW5kIG9wdGlvbnMKaGFuZGxpbmcuIEUuZy4gaW5pdHJkIG5ldmVyIGFjY2Vw dGVkIGFueSBvcHRpb24gYW5kIHdlIGNhbm5vdCByZWFsbHkKYWRkIG9uZSBwcm9iYWJseSBub3c7 IGJ1dCB4ZW5faW5pdHJkIGRpZCBJSVJDIChvciBtYXkgYmUgSSB3YXMKbWlzdGFrZW4gd2l0aCB4 ZW5fbW9kdWxlKS4gV2hhdCBJIG1lYW4sIHdlIHNob3VsZCBhbGxvdyBhZGRpdGlvbmFsCm9wdGlv bnMgZnJvbSB0aGUgdmVyeSBiZWdpbm5pbmcsIG5vdCBqdXN0IG1ha2luZyBpdCBleGFjdCBhbGlh cy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkdydWIt ZGV2ZWwgbWFpbGluZyBsaXN0CkdydWItZGV2ZWxAZ251Lm9yZwpodHRwczovL2xpc3RzLmdudS5v cmcvbWFpbG1hbi9saXN0aW5mby9ncnViLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zs6bJ-0002ct-T8 for mharc-grub-devel@gnu.org; Fri, 30 Oct 2015 06:08:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs6bH-0002aJ-Vx for grub-devel@gnu.org; Fri, 30 Oct 2015 06:08:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zs6bH-0002h4-68 for grub-devel@gnu.org; Fri, 30 Oct 2015 06:07:59 -0400 Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:34676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs6bH-0002h0-1L for grub-devel@gnu.org; Fri, 30 Oct 2015 06:07:59 -0400 Received: by oies66 with SMTP id s66so55915254oie.1 for ; Fri, 30 Oct 2015 03:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=0VJ4sUpPHV4NfguDKZ2M7tqXlgsofhh1Uyr2tN9bJFQ=; b=HXDDvDdRkqOw0oKizjJEl+j3UX0buIZHMCuq+lntqH7E4ax93jffvK4BscRjMGX0S/ 3mpdC9b27e02umItfgyVo8GLXMto1PFfbkA89+dwTCXce8qjr042dNpnD0ks0lxM5uuF frsFUY44u/5E5nvr6BtCYIYj9sqzPUDoEAUwD5xzc4AEa8q2Lk+Bbu2H0TlooRP+BBcA 2d2iuCuGUH3Zxam7vlDrH8j5Tpy1FG2P2i1PmtdovG0a+qTqz9sZ/zwBUOtKafNt9/3z 2QQEIKcOTU2KpZ8Mlta2yf7Smm7YWPZqgmeiuZLSpq6eYUOkR3/M+7nbPMjVAVGCT1LO ZLkw== MIME-Version: 1.0 X-Received: by 10.202.97.196 with SMTP id v187mr4859633oib.91.1446199678285; Fri, 30 Oct 2015 03:07:58 -0700 (PDT) Received: by 10.202.48.141 with HTTP; Fri, 30 Oct 2015 03:07:58 -0700 (PDT) In-Reply-To: <56333D6A.2080506@gmail.com> References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> <56323A72.3000905@gmail.com> <56333D6A.2080506@gmail.com> Date: Fri, 30 Oct 2015 13:07:58 +0300 Message-ID: Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 From: Andrei Borzenkov To: =?UTF-8?Q?Vladimir_=27=CF=86=2Dcoder=2Fphcoder=27_Serbinenko?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::229 Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Stefano Stabellini , Jon Masters , Leif Lindholm , Ryan Harkin , Linaro UEFI Mailman List , Fu Wei X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 10:08:00 -0000 On Fri, Oct 30, 2015 at 12:50 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: >> >> But how to deal with xen_initrd ? >> Could you help me ? >> > Just another alias to module. Possibly you might want to add a code to > xen_initrd tto check that xen_linux was already run I think we need to be careful here. We need to think about future extenstions (in particular to other architectures) and options handling. E.g. initrd never accepted any option and we cannot really add one probably now; but xen_initrd did IIRC (or may be I was mistaken with xen_module). What I mean, we should allow additional options from the very beginning, not just making it exact alias.