From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Wed, 14 Apr 2021 10:06:04 +0900 Subject: [PATCH 10/13] ARM: dts: synquacer: Add device trees for DeveloperBox In-Reply-To: <20210413174746.GS1310@bill-the-cat> References: <161832714362.562320.8024090839631691588.stgit@localhost> <161832781487.562320.49203469390042692.stgit@localhost> <20210413174746.GS1310@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Thank you for your comment! 2021?4?14?(?) 2:47 Tom Rini : > > On Wed, Apr 14, 2021 at 12:30:15AM +0900, Masami Hiramatsu wrote: > > > Add device trees for 96boards EE DeveloperBox and basement SynQuacer > > SoC dtsi. These files are imported from EDK2 with cosmetic change > > and modified for accessing SPI NOR flash. > > > > Signed-off-by: Masami Hiramatsu > > --- > > arch/arm/dts/DeveloperBox.dts | 146 +++++++++ > > arch/arm/dts/Makefile | 2 > > arch/arm/dts/SynQuacer.dtsi | 590 +++++++++++++++++++++++++++++++++++++ > > arch/arm/dts/SynQuacerCaches.dtsi | 72 +++++ > > This poses a bit of a naming challenge. I assume, but please correct me > if I'm wrong, that you don't intend to push these dts files to the Linux > kernel. So that means EDK2 is the primary source of the files, yes? Yes, those are originally written for the EDK2 and I ported it. > We > want to keep them as-is from the upstream project, and note that > relevant git hash/tag/etc that matches where we pulled from, to make > future syncs easier, in the commit message. Let me confirm what you mean, is the git hash/tag/etc what the commit I copied from? and note it in commit message or in the devicetree file? BTW, I made some changes on it for U-Boot drivers. - Enabled OP-TEE node by default (EDK2 checks OP-TEE existance and enables it) - Add SPI node information for accessing SPI-NOR from U-Boot (EDK2 embedded such information inside) Thus the DeveloperBox.dts may not be kept as-is. > I assume this is not part of the uniphier family, so we should start by > naming these as arch/arm/dts/synquacer-... to fit with the general > scheme. Perhaps -developerbox, -core and -caches ? OK. BTW, I'm not sure what is the best way to use SYS_CPU and SYS_SOC. This SoC family name is SynQuacer and the SoC itself is SC2A11. In this case, CONFIG_SYS_CPU=synquacer CONFIG_SYS_SOC=sc2a11 or CONFIG_SYS_SOC=synquacer-sc2a11 ? > And for any changes > we do need, they go in a -u-boot.dtsi file and then potentially > automatically included (if it fits in the logic we have today for that) > or specifically #included otherwise. It seems that (CONFIG_SYS_SOC)-u-boot.dtsi is automatically included, am I correct? Thank you, -- Masami Hiramatsu