* [PATCH] arm64: dts: rockchip: add fan on Sapphire board
@ 2018-09-30 15:50 Vicente Bergas
[not found] ` <20180930155033.31105-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Vicente Bergas @ 2018-09-30 15:50 UTC (permalink / raw
To: Heiko Stuebner, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Vicente Bergas
The Sapphire board has a 12V fan. So, adding it to the DTS.
There is no power supply directly connected, it needs the baseboard to
work.
If the board is used standalone then a hardware modification is needed.
On the Sapphire board there is an unpopulated resistor to connect it to
VBUS_TYPEC, which is usually 5V (too low) and can range up to 20V
(too high).
I tested it for a week connected to VCC_SYS which is 8.4V and proved to
be more than enough for the required cooling needs. This is the
connection described in the comment.
Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
.../boot/dts/rockchip/rk3399-sapphire.dtsi | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 5421e23760c3..90d813bdabde 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -66,6 +66,19 @@
regulator-max-microvolt = <12000000>;
};
+ /*
+ * The fan power supply comes from the baseboard.
+ * For the standalone Sapphire one option is to connect a wire
+ * from R90030 DNP R0805 pin2 to C90002 10uF C0805 pin1 (vcc_sys).
+ */
+ fan0: gpio-fan {
+ #cooling-cells = <2>;
+ compatible = "gpio-fan";
+ gpio-fan,speed-map = <0 0 3000 1>;
+ gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+ };
+
keys: gpio-keys {
compatible = "gpio-keys";
autorepeat;
@@ -183,6 +196,24 @@
cpu-supply = <&vdd_cpu_b>;
};
+&cpu_thermal {
+ trips {
+ cpu_hot: cpu_hot {
+ hysteresis = <10000>;
+ temperature = <55000>;
+ type = "active";
+ };
+ };
+
+ cooling-maps {
+ map2 {
+ cooling-device =
+ <&fan0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ trip = <&cpu_hot>;
+ };
+ };
+};
+
&emmc_phy {
status = "okay";
};
@@ -472,6 +503,13 @@
};
};
+ fan {
+ motor_pwr: motor-pwr {
+ rockchip,pins =
+ <RK_GPIO1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
pmic {
pmic_int_l: pmic-int-l {
rockchip,pins =
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add fan on Sapphire board
[not found] ` <20180930155033.31105-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-10-22 13:28 ` Vicente Bergas
2018-10-30 14:08 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Vicente Bergas @ 2018-10-22 13:28 UTC (permalink / raw
To: Heiko Stübner, open list:ARM/Rockchip SoC...
On Sun, Sep 30, 2018 at 5:50 PM Vicente Bergas <vicencb@gmail.com> wrote:
>
> The Sapphire board has a 12V fan. So, adding it to the DTS.
> There is no power supply directly connected, it needs the baseboard to
> work.
> If the board is used standalone then a hardware modification is needed.
> On the Sapphire board there is an unpopulated resistor to connect it to
> VBUS_TYPEC, which is usually 5V (too low) and can range up to 20V
> (too high).
> I tested it for a week connected to VCC_SYS which is 8.4V and proved to
> be more than enough for the required cooling needs. This is the
> connection described in the comment.
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> .../boot/dts/rockchip/rk3399-sapphire.dtsi | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> index 5421e23760c3..90d813bdabde 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> @@ -66,6 +66,19 @@
> regulator-max-microvolt = <12000000>;
> };
>
> + /*
> + * The fan power supply comes from the baseboard.
> + * For the standalone Sapphire one option is to connect a wire
> + * from R90030 DNP R0805 pin2 to C90002 10uF C0805 pin1 (vcc_sys).
> + */
> + fan0: gpio-fan {
> + #cooling-cells = <2>;
> + compatible = "gpio-fan";
> + gpio-fan,speed-map = <0 0 3000 1>;
> + gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> + };
> +
> keys: gpio-keys {
> compatible = "gpio-keys";
> autorepeat;
> @@ -183,6 +196,24 @@
> cpu-supply = <&vdd_cpu_b>;
> };
>
> +&cpu_thermal {
> + trips {
> + cpu_hot: cpu_hot {
> + hysteresis = <10000>;
> + temperature = <55000>;
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map2 {
> + cooling-device =
> + <&fan0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + trip = <&cpu_hot>;
> + };
> + };
> +};
> +
> &emmc_phy {
> status = "okay";
> };
> @@ -472,6 +503,13 @@
> };
> };
>
> + fan {
> + motor_pwr: motor-pwr {
> + rockchip,pins =
> + <RK_GPIO1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> + };
> +
> pmic {
> pmic_int_l: pmic-int-l {
> rockchip,pins =
> --
> 2.19.0
Hi,
can i kindly ask for feedback on this proposed patch?
Regards,
Vicenç.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add fan on Sapphire board
[not found] ` <20180930155033.31105-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-22 13:28 ` Vicente Bergas
@ 2018-10-30 14:08 ` Heiko Stuebner
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2018-10-30 14:08 UTC (permalink / raw
To: Vicente Bergas; +Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Sonntag, 30. September 2018, 17:50:33 CET schrieb Vicente Bergas:
> The Sapphire board has a 12V fan. So, adding it to the DTS.
> There is no power supply directly connected, it needs the baseboard to
> work.
> If the board is used standalone then a hardware modification is needed.
> On the Sapphire board there is an unpopulated resistor to connect it to
> VBUS_TYPEC, which is usually 5V (too low) and can range up to 20V
> (too high).
> I tested it for a week connected to VCC_SYS which is 8.4V and proved to
> be more than enough for the required cooling needs. This is the
> connection described in the comment.
>
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
applied for 4.21 (or whatever it will get called)
Thanks
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-30 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-30 15:50 [PATCH] arm64: dts: rockchip: add fan on Sapphire board Vicente Bergas
[not found] ` <20180930155033.31105-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-22 13:28 ` Vicente Bergas
2018-10-30 14:08 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.