From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbGNIed (ORCPT ); Tue, 14 Jul 2015 04:34:33 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:34040 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753536AbbGNIea (ORCPT ); Tue, 14 Jul 2015 04:34:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <1434548543-22949-1-git-send-email-tomeu.vizoso@collabora.com> <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> From: Tomeu Vizoso Date: Tue, 14 Jul 2015 10:34:09 +0200 X-Google-Sender-Auth: PqxENedikLmqZR84veLD1ZB1Gjw Message-ID: Subject: Re: [PATCH 04/13] pinctrl: tegra: Only set the gpio range if needed To: Linus Walleij Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Mark Rutland , Krzysztof Kozlowski , Andrzej Hajda , Lv Zheng , Alexander Holler , Russell King , Arnd Bergmann , Robert Moore , Grant Likely , Len Brown , Pawel Moll , Ian Campbell , Rob Herring , =?UTF-8?Q?Terje_Bergstr=C3=B6m?= , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , Dmitry Torokhov , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Mark Brown , Kumar Gala , Javier Martinez Canillas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13 July 2015 at 22:14, Linus Walleij wrote: > On Wed, Jun 17, 2015 at 3:42 PM, Tomeu Vizoso > wrote: > >> If the gpio DT node has the gpio-ranges property, the range will be >> added by the gpio core and doesn't need to be added by the pinctrl >> driver. >> >> By having the gpio-ranges property, we have an explicit dependency from >> the gpio node to the pinctrl node and we can stop using the deprecated >> pinctrl_add_gpio_range() function. >> >> Note that when the GPIO device gets probed before the associated >> princtrl device, the gpio core actually won't register the gpio range. >> Thus, this patch is only safe to be merged after we have in place a way >> to assure that gpio devices are probed after their associated pinctrl >> devices (such as ordered probing). >> >> Signed-off-by: Tomeu Vizoso > > This doesn't look like it would hurt, but need Stephen's opinion > on it, and I think he's on vacation. Would check with next-in-line > Tegra maintainer, Thierry/Alexandre? Sorry about that, but I have split these changes out into their own series after people complained about it. Have just sent a new version which already has Stephen's ack: https://lkml.kernel.org/g/1436862596-27730-1-git-send-email-tomeu.vizoso@collabora.com Thanks, Tomeu From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomeu.vizoso@collabora.com (Tomeu Vizoso) Date: Tue, 14 Jul 2015 10:34:09 +0200 Subject: [PATCH 04/13] pinctrl: tegra: Only set the gpio range if needed In-Reply-To: References: <1434548543-22949-1-git-send-email-tomeu.vizoso@collabora.com> <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13 July 2015 at 22:14, Linus Walleij wrote: > On Wed, Jun 17, 2015 at 3:42 PM, Tomeu Vizoso > wrote: > >> If the gpio DT node has the gpio-ranges property, the range will be >> added by the gpio core and doesn't need to be added by the pinctrl >> driver. >> >> By having the gpio-ranges property, we have an explicit dependency from >> the gpio node to the pinctrl node and we can stop using the deprecated >> pinctrl_add_gpio_range() function. >> >> Note that when the GPIO device gets probed before the associated >> princtrl device, the gpio core actually won't register the gpio range. >> Thus, this patch is only safe to be merged after we have in place a way >> to assure that gpio devices are probed after their associated pinctrl >> devices (such as ordered probing). >> >> Signed-off-by: Tomeu Vizoso > > This doesn't look like it would hurt, but need Stephen's opinion > on it, and I think he's on vacation. Would check with next-in-line > Tegra maintainer, Thierry/Alexandre? Sorry about that, but I have split these changes out into their own series after people complained about it. Have just sent a new version which already has Stephen's ack: https://lkml.kernel.org/g/1436862596-27730-1-git-send-email-tomeu.vizoso at collabora.com Thanks, Tomeu