* [PATCH] gpio/xilinx: Use correct address when setting initial values.
@ 2015-06-23 13:14 ` Raphaël Teysseyre
0 siblings, 0 replies; 6+ messages in thread
From: Raphaël Teysseyre @ 2015-06-23 13:14 UTC (permalink / raw
To: linus.walleij, gnurou, michal.simek, soren.brinkmann, linux-gpio,
linux-arm-kernel, linux-kernel
>From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
Date: Tue, 23 Jun 2015 14:49:31 +0200
Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Raphaël Teysseyre <rteysseyre@gmail.com>
---
drivers/gpio/gpio-xilinx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 61243d1..e544b7a 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
if (!chip->gpio_width[1])
return;
- xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_state[1]);
- xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_dir[1]);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gpio/xilinx: Use correct address when setting initial values.
@ 2015-06-23 13:14 ` Raphaël Teysseyre
0 siblings, 0 replies; 6+ messages in thread
From: Raphaël Teysseyre @ 2015-06-23 13:14 UTC (permalink / raw
To: linux-arm-kernel
>From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
Date: Tue, 23 Jun 2015 14:49:31 +0200
Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Rapha?l Teysseyre <rteysseyre@gmail.com>
---
drivers/gpio/gpio-xilinx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 61243d1..e544b7a 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
if (!chip->gpio_width[1])
return;
- xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_state[1]);
- xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_dir[1]);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] gpio/xilinx: Use correct address when setting initial values.
@ 2015-06-23 13:14 ` Raphaël Teysseyre
0 siblings, 0 replies; 6+ messages in thread
From: Raphaël Teysseyre @ 2015-06-23 13:14 UTC (permalink / raw
To: linus.walleij, gnurou, michal.simek, soren.brinkmann, linux-gpio,
linux-arm-kernel, linux-kernel
From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
Date: Tue, 23 Jun 2015 14:49:31 +0200
Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Raphaël Teysseyre <rteysseyre@gmail.com>
---
drivers/gpio/gpio-xilinx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 61243d1..e544b7a 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
if (!chip->gpio_width[1])
return;
- xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_state[1]);
- xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
+ xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
chip->gpio_dir[1]);
}
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio/xilinx: Use correct address when setting initial values.
2015-06-23 13:14 ` Raphaël Teysseyre
(?)
@ 2015-06-23 14:11 ` Alexandre Courbot
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2015-06-23 14:11 UTC (permalink / raw
To: Raphaël Teysseyre
Cc: Linus Walleij, Michal Simek, Sören Brinkmann,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List
On Tue, Jun 23, 2015 at 10:14 PM, Raphaël Teysseyre
<rteysseyre@gmail.com> wrote:
> From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
> Date: Tue, 23 Jun 2015 14:49:31 +0200
> Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
Mmm this looks like you copy/pasted the output of git format-patch
into your email client. Use git send-email instead, or avoid the mail
headers if you wish to use another client.
>
> Signed-off-by: Raphaël Teysseyre <rteysseyre@gmail.com>
A commit message beyond the subject would be appreciated. What did you
fix exactly? What was incorrect?
> ---
> drivers/gpio/gpio-xilinx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 61243d1..e544b7a 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
> if (!chip->gpio_width[1])
> return;
>
> - xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_state[1]);
> - xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_dir[1]);
> }
>
> --
> 1.7.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] gpio/xilinx: Use correct address when setting initial values.
@ 2015-06-23 14:11 ` Alexandre Courbot
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2015-06-23 14:11 UTC (permalink / raw
To: linux-arm-kernel
On Tue, Jun 23, 2015 at 10:14 PM, Rapha?l Teysseyre
<rteysseyre@gmail.com> wrote:
> From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
> Date: Tue, 23 Jun 2015 14:49:31 +0200
> Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
Mmm this looks like you copy/pasted the output of git format-patch
into your email client. Use git send-email instead, or avoid the mail
headers if you wish to use another client.
>
> Signed-off-by: Rapha?l Teysseyre <rteysseyre@gmail.com>
A commit message beyond the subject would be appreciated. What did you
fix exactly? What was incorrect?
> ---
> drivers/gpio/gpio-xilinx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 61243d1..e544b7a 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
> if (!chip->gpio_width[1])
> return;
>
> - xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_state[1]);
> - xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_dir[1]);
> }
>
> --
> 1.7.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gpio/xilinx: Use correct address when setting initial values.
@ 2015-06-23 14:11 ` Alexandre Courbot
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Courbot @ 2015-06-23 14:11 UTC (permalink / raw
To: Raphaël Teysseyre
Cc: Linus Walleij, Michal Simek, Sören Brinkmann,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List
On Tue, Jun 23, 2015 at 10:14 PM, Raphaël Teysseyre
<rteysseyre@gmail.com> wrote:
> From 670209328307a198b80723a917957269a815fc32 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rapha=C3=ABl=20Teysseyre?= <rteysseyre@gmail.com>
> Date: Tue, 23 Jun 2015 14:49:31 +0200
> Subject: [PATCH] gpio/xilinx: Use correct address when setting initial values.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
Mmm this looks like you copy/pasted the output of git format-patch
into your email client. Use git send-email instead, or avoid the mail
headers if you wish to use another client.
>
> Signed-off-by: Raphaël Teysseyre <rteysseyre@gmail.com>
A commit message beyond the subject would be appreciated. What did you
fix exactly? What was incorrect?
> ---
> drivers/gpio/gpio-xilinx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 61243d1..e544b7a 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -220,9 +220,9 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
> if (!chip->gpio_width[1])
> return;
>
> - xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_DATA_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_state[1]);
> - xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_TRI_OFFSET,
> + xgpio_writereg(mm_gc->regs + XGPIO_TRI_OFFSET + XGPIO_CHANNEL_OFFSET,
> chip->gpio_dir[1]);
> }
>
> --
> 1.7.1
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-23 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-23 13:14 [PATCH] gpio/xilinx: Use correct address when setting initial values Raphaël Teysseyre
2015-06-23 13:14 ` Raphaël Teysseyre
2015-06-23 13:14 ` Raphaël Teysseyre
2015-06-23 14:11 ` Alexandre Courbot
2015-06-23 14:11 ` Alexandre Courbot
2015-06-23 14:11 ` Alexandre Courbot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.