From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753136AbbEGHNt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 May 2015 03:13:49 -0400
Received: from mail-qk0-f179.google.com ([209.85.220.179]:36625 "EHLO
	mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750967AbbEGHNp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 May 2015 03:13:45 -0400
MIME-Version: 1.0
In-Reply-To: <1430898058.3843.30.camel@x220>
References: <1430316005-16480-7-git-send-email-shobhit.kumar@intel.com>
	<1430818716-27287-1-git-send-email-shobhit.kumar@intel.com>
	<1430898058.3843.30.camel@x220>
Date: Thu, 7 May 2015 12:43:44 +0530
Message-ID: <CAAbrOmcLynLOfphBbCHYBwc7uK=OKhXxRCYHNAx3X=Pi8S1_9Q@mail.gmail.com>
Subject: Re: [Intel-gfx] [PATCH 6/8] pwm: crc: Add Crystalcove (CRC) PWM driver
From: Shobhit Kumar <kumar@shobhit.info>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Shobhit Kumar <shobhit.kumar@intel.com>,
        linux-pwm <linux-pwm@vger.kernel.org>,
        Jani Nikula <jani.nikula@intel.com>,
        Samuel Ortiz <sameo@linux.intel.com>,
        Alexandre Courbot <gnurou@gmail.com>, David Airlie <airlied@linux.ie>,
        Povilas Staniulis <wdmonster@gmail.com>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        Chih-Wei Huang <cwhuang@android-x86.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 6, 2015 at 1:10 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Tue, 2015-05-05 at 15:08 +0530, Shobhit Kumar wrote:
>> The Crystalcove PMIC controls PWM signals and this driver exports that
>> capability as a PWM chip driver. This is platform device implementtaion
>> of the drivers/mfd cell device for CRC PMIC
>>
>> v2: Use the existing config callback with duty_ns and period_ns(Thierry)
>>
>> v3: Correct the subject line (Lee jones)
>>
>> CC: Samuel Ortiz <sameo@linux.intel.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Alexandre Courbot <gnurou@gmail.com>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
>
> The same comments can be made as for v2, see
> http://lkml.kernel.org/r/1430428322.2187.24.camel@x220 . Maybe you
> didn't receive that message.
>
> It could also be that you think my comments were invalid, or too vague,
> or whatever. Please say so, because then I don't have to bother you
> again when you send out v4.
>

Not at all, I just missed your comments and realise my mistake later
after sending next update. Somehow the mailing list filters that I
have setup are not working correctly. I will look into your comments.

Regards
Shobhit