From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbbFSGq4 (ORCPT ); Fri, 19 Jun 2015 02:46:56 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:35595 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbbFSGqs (ORCPT ); Fri, 19 Jun 2015 02:46:48 -0400 MIME-Version: 1.0 In-Reply-To: <1434652916.2385.124.camel@x220> References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-7-git-send-email-shobhit.kumar@intel.com> <1430428322.2187.24.camel@x220> <1434652916.2385.124.camel@x220> Date: Fri, 19 Jun 2015 12:16:47 +0530 Message-ID: Subject: Re: [Intel-gfx] [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver From: Shobhit Kumar To: Paul Bolle Cc: Shobhit Kumar , linux-pwm , Jani Nikula , Samuel Ortiz , Alexandre Courbot , David Airlie , Povilas Staniulis , intel-gfx , linux-kernel , dri-devel , linux-gpio , Chih-Wei Huang , Thierry Reding , Daniel Vetter , Lee Jones , Linus Walleij Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Fri, Jun 19, 2015 at 12:11 AM, Paul Bolle wrote: > Hi Shobhit, > > On Thu, 2015-06-18 at 23:24 +0530, Shobhit Kumar wrote: >> On Fri, May 1, 2015 at 2:42 AM, Paul Bolle wrote: >> > On Wed, 2015-04-29 at 19:30 +0530, Shobhit Kumar wrote: >> >> --- a/drivers/pwm/Kconfig >> >> +++ b/drivers/pwm/Kconfig >> > >> >> +config PWM_CRC >> >> + bool "Intel Crystalcove (CRC) PWM support" >> >> + depends on X86 && INTEL_SOC_PMIC >> >> + help >> >> + Generic PWM framework driver for Crystalcove (CRC) PMIC based PWM >> >> + control. >> > >> >> --- a/drivers/pwm/Makefile >> >> +++ b/drivers/pwm/Makefile >> > >> >> +obj-$(CONFIG_PWM_CRC) += pwm-crc.o >> > >> > PWM_CRC is a bool symbol. So pwm-crc.o can never be part of a module. >> >> I actually started this as a module but later decided to make it as >> bool because INTEL_SOC_PMIC on which this depends is itself a bool as >> well. > > As does GPIO_CRYSTAL_COVE and that's a tristate. So? > >> Still it is good to keep the module based initialization. >> Firstly because it causes no harm > > If I got a dime for every time people used an argument like that I ... I > could treat myself to an ice cream. A really big ice cream. Hmm, that > doesn't sound too impressive. But still, "causes no harm" is below the > bar for kernel code. Kernel code needs to add value. > >> and even though some of the macros >> are pre-processed out, gives info about the driver. > > None of which can't be gotten elsewhere (ie, the commit message, or the > file these macro reside in). > Causes no harm comment had to be read together with more info about the driver. It causes no harm while providing more info. And as you only said those macros are pre-processed out to really the defaults for built-in drivers. So what is the exact big problem with this ? I can anyway shove out these macros to end the discussion. BTW whether you buy the argument or not, please do treat yourself with ice cream for being able to make such a comment. >> Secondly there >> were discussion on why INTEL_SOC_PMIC is bool (note this driver also >> has module based initialization even when bool). > > Yes, there's copy and paste going on even in kernel development. > There are other examples in the kernel. I just gave the one which is related as well. Regards Shobhit >> I am guessing because >> of some tricky module load order dependencies. If ever that becomes a >> module, this can mostly be unchanged to be loaded as a module. > > You put in a macro, or any other bit of code, when it's needed, not > beforehand, "just in case". That's silly. > > Thanks, > > > Paul Bolle > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shobhit Kumar Subject: Re: [PATCH 6/8] drivers/pwm: Add Crystalcove (CRC) PWM driver Date: Fri, 19 Jun 2015 12:16:47 +0530 Message-ID: References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-7-git-send-email-shobhit.kumar@intel.com> <1430428322.2187.24.camel@x220> <1434652916.2385.124.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1434652916.2385.124.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paul Bolle Cc: Alexandre Courbot , Samuel Ortiz , linux-pwm , Jani Nikula , Shobhit Kumar , intel-gfx , linux-kernel , Povilas Staniulis , David Airlie , Chih-Wei Huang , Thierry Reding , dri-devel , linux-gpio , Daniel Vetter , Lee Jones , Linus Walleij List-Id: linux-gpio@vger.kernel.org SGkgUGF1bCwKCk9uIEZyaSwgSnVuIDE5LCAyMDE1IGF0IDEyOjExIEFNLCBQYXVsIEJvbGxlIDxw ZWJvbGxlQHRpc2NhbGkubmw+IHdyb3RlOgo+IEhpIFNob2JoaXQsCj4KPiBPbiBUaHUsIDIwMTUt MDYtMTggYXQgMjM6MjQgKzA1MzAsIFNob2JoaXQgS3VtYXIgd3JvdGU6Cj4+IE9uIEZyaSwgTWF5 IDEsIDIwMTUgYXQgMjo0MiBBTSwgUGF1bCBCb2xsZSA8cGVib2xsZUB0aXNjYWxpLm5sPiB3cm90 ZToKPj4gPiBPbiBXZWQsIDIwMTUtMDQtMjkgYXQgMTk6MzAgKzA1MzAsIFNob2JoaXQgS3VtYXIg d3JvdGU6Cj4+ID4+IC0tLSBhL2RyaXZlcnMvcHdtL0tjb25maWcKPj4gPj4gKysrIGIvZHJpdmVy cy9wd20vS2NvbmZpZwo+PiA+Cj4+ID4+ICtjb25maWcgUFdNX0NSQwo+PiA+PiArICAgICBib29s ICJJbnRlbCBDcnlzdGFsY292ZSAoQ1JDKSBQV00gc3VwcG9ydCIKPj4gPj4gKyAgICAgZGVwZW5k cyBvbiBYODYgJiYgSU5URUxfU09DX1BNSUMKPj4gPj4gKyAgICAgaGVscAo+PiA+PiArICAgICAg IEdlbmVyaWMgUFdNIGZyYW1ld29yayBkcml2ZXIgZm9yIENyeXN0YWxjb3ZlIChDUkMpIFBNSUMg YmFzZWQgUFdNCj4+ID4+ICsgICAgICAgY29udHJvbC4KPj4gPgo+PiA+PiAtLS0gYS9kcml2ZXJz L3B3bS9NYWtlZmlsZQo+PiA+PiArKysgYi9kcml2ZXJzL3B3bS9NYWtlZmlsZQo+PiA+Cj4+ID4+ ICtvYmotJChDT05GSUdfUFdNX0NSQykgICAgICAgICAgICAgICAgKz0gcHdtLWNyYy5vCj4+ID4K Pj4gPiBQV01fQ1JDIGlzIGEgYm9vbCBzeW1ib2wuIFNvIHB3bS1jcmMubyBjYW4gbmV2ZXIgYmUg cGFydCBvZiBhIG1vZHVsZS4KPj4KPj4gSSBhY3R1YWxseSBzdGFydGVkIHRoaXMgYXMgYSBtb2R1 bGUgYnV0IGxhdGVyIGRlY2lkZWQgdG8gbWFrZSBpdCBhcwo+PiBib29sIGJlY2F1c2UgSU5URUxf U09DX1BNSUMgb24gd2hpY2ggdGhpcyBkZXBlbmRzIGlzIGl0c2VsZiBhIGJvb2wgYXMKPj4gd2Vs bC4KPgo+IEFzIGRvZXMgR1BJT19DUllTVEFMX0NPVkUgYW5kIHRoYXQncyBhIHRyaXN0YXRlLiBT bz8KPgo+PiBTdGlsbCBpdCBpcyBnb29kIHRvIGtlZXAgdGhlIG1vZHVsZSBiYXNlZCBpbml0aWFs aXphdGlvbi4KPj4gRmlyc3RseSBiZWNhdXNlIGl0IGNhdXNlcyBubyBoYXJtCj4KPiBJZiBJIGdv dCBhIGRpbWUgZm9yIGV2ZXJ5IHRpbWUgcGVvcGxlIHVzZWQgYW4gYXJndW1lbnQgbGlrZSB0aGF0 IEkgLi4uIEkKPiBjb3VsZCB0cmVhdCBteXNlbGYgdG8gYW4gaWNlIGNyZWFtLiBBIHJlYWxseSBi aWcgaWNlIGNyZWFtLiBIbW0sIHRoYXQKPiBkb2Vzbid0IHNvdW5kIHRvbyBpbXByZXNzaXZlLiBC dXQgc3RpbGwsICJjYXVzZXMgbm8gaGFybSIgaXMgYmVsb3cgdGhlCj4gYmFyIGZvciBrZXJuZWwg Y29kZS4gS2VybmVsIGNvZGUgbmVlZHMgdG8gYWRkIHZhbHVlLgo+Cj4+IGFuZCBldmVuIHRob3Vn aCBzb21lIG9mIHRoZSBtYWNyb3MKPj4gYXJlIHByZS1wcm9jZXNzZWQgb3V0LCBnaXZlcyBpbmZv IGFib3V0IHRoZSBkcml2ZXIuCj4KPiBOb25lIG9mIHdoaWNoIGNhbid0IGJlIGdvdHRlbiBlbHNl d2hlcmUgKGllLCB0aGUgY29tbWl0IG1lc3NhZ2UsIG9yIHRoZQo+IGZpbGUgdGhlc2UgbWFjcm8g cmVzaWRlIGluKS4KPgoKQ2F1c2VzIG5vIGhhcm0gY29tbWVudCBoYWQgdG8gYmUgcmVhZCB0b2dl dGhlciB3aXRoIG1vcmUgaW5mbyBhYm91dAp0aGUgZHJpdmVyLiBJdCBjYXVzZXMgbm8gaGFybSB3 aGlsZSBwcm92aWRpbmcgbW9yZSBpbmZvLiBBbmQgYXMgeW91Cm9ubHkgc2FpZCB0aG9zZSBtYWNy b3MgYXJlIHByZS1wcm9jZXNzZWQgb3V0IHRvIHJlYWxseSB0aGUgZGVmYXVsdHMKZm9yIGJ1aWx0 LWluIGRyaXZlcnMuIFNvIHdoYXQgaXMgdGhlIGV4YWN0IGJpZyBwcm9ibGVtIHdpdGggdGhpcyA/ IEkKY2FuIGFueXdheSBzaG92ZSBvdXQgdGhlc2UgbWFjcm9zIHRvIGVuZCB0aGUgZGlzY3Vzc2lv bi4KCkJUVyB3aGV0aGVyIHlvdSAgYnV5IHRoZSBhcmd1bWVudCBvciBub3QsIHBsZWFzZSBkbyB0 cmVhdCB5b3Vyc2VsZgp3aXRoIGljZSBjcmVhbSBmb3IgYmVpbmcgYWJsZSB0byBtYWtlIHN1Y2gg YSBjb21tZW50LgoKPj4gU2Vjb25kbHkgdGhlcmUKPj4gd2VyZSBkaXNjdXNzaW9uIG9uIHdoeSBJ TlRFTF9TT0NfUE1JQyBpcyBib29sIChub3RlIHRoaXMgZHJpdmVyIGFsc28KPj4gaGFzIG1vZHVs ZSBiYXNlZCBpbml0aWFsaXphdGlvbiBldmVuIHdoZW4gYm9vbCkuCj4KPiBZZXMsIHRoZXJlJ3Mg Y29weSBhbmQgcGFzdGUgZ29pbmcgb24gZXZlbiBpbiBrZXJuZWwgZGV2ZWxvcG1lbnQuCj4KClRo ZXJlIGFyZSBvdGhlciBleGFtcGxlcyBpbiB0aGUga2VybmVsLiBJIGp1c3QgZ2F2ZSB0aGUgb25l IHdoaWNoIGlzCnJlbGF0ZWQgYXMgd2VsbC4KClJlZ2FyZHMKU2hvYmhpdAoKPj4gSSBhbSBndWVz c2luZyBiZWNhdXNlCj4+IG9mIHNvbWUgdHJpY2t5IG1vZHVsZSBsb2FkIG9yZGVyIGRlcGVuZGVu Y2llcy4gSWYgZXZlciB0aGF0IGJlY29tZXMgYQo+PiBtb2R1bGUsIHRoaXMgY2FuIG1vc3RseSBi ZSB1bmNoYW5nZWQgdG8gYmUgbG9hZGVkIGFzIGEgbW9kdWxlLgo+Cj4gWW91IHB1dCBpbiBhIG1h Y3JvLCBvciBhbnkgb3RoZXIgYml0IG9mIGNvZGUsIHdoZW4gaXQncyBuZWVkZWQsIG5vdAo+IGJl Zm9yZWhhbmQsICJqdXN0IGluIGNhc2UiLiBUaGF0J3Mgc2lsbHkuCj4KPiBUaGFua3MsCj4KPgo+ IFBhdWwgQm9sbGUKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=