From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D3BC32772 for ; Wed, 17 Aug 2022 22:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242168AbiHQWkl (ORCPT ); Wed, 17 Aug 2022 18:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238965AbiHQWki (ORCPT ); Wed, 17 Aug 2022 18:40:38 -0400 Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A688712D18 for ; Wed, 17 Aug 2022 15:40:36 -0700 (PDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-33387bf0c4aso164154397b3.11 for ; Wed, 17 Aug 2022 15:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=J81yxb+B+6s5/E+3d62WGHV/0oRet+1BBMtJwVekE7E=; b=UVV3tBJN+nWPgXWbzXoIJ7ET1m0vHO1eOl1vsUPP33ajyJXls3XLYbyaM8JBtAbuTo gszE7Bqg/242FQYx7cA1yTbssCv+bIo2SJ+toiN3eHXiu/IYX7mIOUwF5nwqfKeFaTII 0JT1BC5Z/ssN2J8UO2ZmHeK4ygUBP6SI5l+60a0Cgas2gpUcsYdxDRASXYxSbC71+Moj 8ssx58q2egBLNn5JXq2ItIcFv9Zg1zYgLPQDHE2QiHRO0lH4yFUPfYCb8U/w6BVRlvgW xuGMkBSYo/WHk6IdUjc069oBP/pLEX91lTjhbnWDmYonNcv7fDYpm/5WAwVn1Y5bktNd gtDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=J81yxb+B+6s5/E+3d62WGHV/0oRet+1BBMtJwVekE7E=; b=QNvJpF/lz8UmPhTKyoaRUG4lqZswTBRj8AAKfSGvpwWiSacAMroE7QjUK2M/+T8PL+ 0pxJJf2iwxASWooZ6VL2AYRc6/yXIVh97AJm4bBgQiPPgMhqGtzfkXM0rHu2RobNPfVf H2p3ZFU+j0I24Ev5VmRiAloB02p8ala0G5deXZhjECdA2tc8YzGS3dhOuONAeSh1Zsk4 S9s4OgkR3BY3gHLakVwW3hQqiXn/0zzbeb75m5TVib3im+r+RZUzZ09rJKEMIeTTmUdb AXFypx5/TGHYr/kxmug6tLBOCw1hg2iIxpVCn40nwOwm+gtgljJ6I++JN7B5GCBwi/PY lmBA== X-Gm-Message-State: ACgBeo13zVU3seBZfVluACb5UC5FUKSLY+AMzp1h5q1SRjBO2Py4vuLn h0tIkgHtR403wTsIJAjgYyExhvRvv5KWk/ij1tpobw== X-Google-Smtp-Source: AA6agR63irMBuNJvUV6dHagvxLxtF40zcMq/BDY/Y/mI/gQ26YgrS9LS7HL2vDj4yBbSgLwws5Jx4rCzvzBBO3cHL9I= X-Received: by 2002:a25:bb04:0:b0:67e:e3b:ee91 with SMTP id z4-20020a25bb04000000b0067e0e3bee91mr394878ybg.71.1660776035737; Wed, 17 Aug 2022 15:40:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sagi Shahar Date: Wed, 17 Aug 2022 15:40:24 -0700 Message-ID: Subject: Re: [PATCH v8 095/103] KVM: TDX: Handle TDX PV rdmsr/wrmsr hypercall To: "Yamahata, Isaku" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Isaku Yamahata , Paolo Bonzini , Erdem Aktas , Sean Christopherson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 7, 2022 at 3:03 PM wrote: > > From: Isaku Yamahata > > Wire up TDX PV rdmsr/wrmsr hypercall to the KVM backend function. > > Signed-off-by: Isaku Yamahata > Reviewed-by: Paolo Bonzini > --- > arch/x86/kvm/vmx/tdx.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > index 341c29385544..fdd0609bd01b 100644 > --- a/arch/x86/kvm/vmx/tdx.c > +++ b/arch/x86/kvm/vmx/tdx.c > @@ -1157,6 +1157,41 @@ static int tdx_emulate_mmio(struct kvm_vcpu *vcpu) > return 1; > } > > +static int tdx_emulate_rdmsr(struct kvm_vcpu *vcpu) > +{ > + u32 index = tdvmcall_a0_read(vcpu); > + u64 data; > + > + if (!kvm_msr_allowed(vcpu, index, KVM_MSR_FILTER_READ) || > + kvm_get_msr(vcpu, index, &data)) { > + trace_kvm_msr_read_ex(index); > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_INVALID_OPERAND); > + return 1; > + } > + trace_kvm_msr_read(index, data); > + > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_SUCCESS); > + tdvmcall_set_return_val(vcpu, data); > + return 1; > +} > + > +static int tdx_emulate_wrmsr(struct kvm_vcpu *vcpu) > +{ > + u32 index = tdvmcall_a0_read(vcpu); > + u64 data = tdvmcall_a1_read(vcpu); > + > + if (!kvm_msr_allowed(vcpu, index, KVM_MSR_FILTER_READ) || ^ This should be KVM_MSR_FILTER_WRITE > + kvm_set_msr(vcpu, index, data)) { > + trace_kvm_msr_write_ex(index, data); > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_INVALID_OPERAND); > + return 1; > + } > + > + trace_kvm_msr_write(index, data); > + tdvmcall_set_return_code(vcpu, TDG_VP_VMCALL_SUCCESS); > + return 1; > +} > + > static int handle_tdvmcall(struct kvm_vcpu *vcpu) > { > if (tdvmcall_exit_type(vcpu)) > @@ -1171,6 +1206,10 @@ static int handle_tdvmcall(struct kvm_vcpu *vcpu) > return tdx_emulate_io(vcpu); > case EXIT_REASON_EPT_VIOLATION: > return tdx_emulate_mmio(vcpu); > + case EXIT_REASON_MSR_READ: > + return tdx_emulate_rdmsr(vcpu); > + case EXIT_REASON_MSR_WRITE: > + return tdx_emulate_wrmsr(vcpu); > default: > break; > } > -- > 2.25.1 >