From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F46C433B4 for ; Wed, 14 Apr 2021 13:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B698C61132 for ; Wed, 14 Apr 2021 13:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351373AbhDNNdL (ORCPT ); Wed, 14 Apr 2021 09:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbhDNNdI (ORCPT ); Wed, 14 Apr 2021 09:33:08 -0400 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48B63C061756 for ; Wed, 14 Apr 2021 06:32:35 -0700 (PDT) Received: by mail-il1-x136.google.com with SMTP id r5so8933695ilb.2 for ; Wed, 14 Apr 2021 06:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+rJkm+pt7IAIh3meE9DcpUBzUhbdXEUDSKBscpDbcvQ=; b=SdJvtJWFpdtL24ZNlj+RoMxAj5tA6pT+FNmGcPLgHU0k94dxjF7yuNFFoBBo1LY4r6 IhBsY1KplvIJlpe302RTUiVZPvoyVU5AO0u0dNEp6+jD+i7N4WnItL/yk/LlBf0rlXbr 86GH9pU9ZIpe7lbkOa6WmN2CohV0FPVA/gwB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+rJkm+pt7IAIh3meE9DcpUBzUhbdXEUDSKBscpDbcvQ=; b=op3ZBvgbaNlgKxC1Y43OcDLnV8SETqZ9ng5yUtTShfMidjuKTdby3F1Sv8zgWa79uy zqOA2AsyE1C1UwxiCc0iGHJzQmRztW7ehN5Ohdq2BQ4KdaRBfXKo7swAIPEGSndiTdW6 L+bUIh3MRGwXgjkm5Qx8Zu4LikSjGhhm6x0IrcDMLol+AxJZzxXoE5/k5fvJeduRU7yp NslpQ5SXpWKhXTK1yG/EdZ/K6U105N2la6r0xKGfdI5NWzO44lGhP0Haw34PZVNmKR9o QkW8ciJ4ZlsY3OkwOThsswtCRedOTEsJyIshguuFeE4MafOneX6t9e2bK/k4UJvuruKv c6nw== X-Gm-Message-State: AOAM5315vNXW7ttJLc1qfrXW/3+R0UB+6rmJe37J/b9serowtrCFIgjs +6maaA/h4O0Ce0PicW95W+rVrj7xK/M0WyvppEx3dw== X-Google-Smtp-Source: ABdhPJxpQBuy43S79HHF6y0YaWWhOf7xOlTljrKXOqrhq+xJ7yWxHZ2nsrlYqB99sBD3phaEhBb5ng2ySZoZ/DB+8qE= X-Received: by 2002:a92:ce90:: with SMTP id r16mr13484481ilo.220.1618407154503; Wed, 14 Apr 2021 06:32:34 -0700 (PDT) MIME-Version: 1.0 References: <20210412153754.235500-4-revest@chromium.org> <202104130447.2WLAvV47-lkp@intel.com> In-Reply-To: <202104130447.2WLAvV47-lkp@intel.com> From: Florent Revest Date: Wed, 14 Apr 2021 15:32:23 +0200 Message-ID: Subject: Re: [PATCH bpf-next v3 3/6] bpf: Add a bpf_snprintf helper To: kernel test robot Cc: bpf , kbuild-all@lists.01.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Yonghong Song , KP Singh , Brendan Jackman , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 10:32 PM kernel test robot wrote: > m68k-linux-ld: kernel/bpf/verifier.o: in function `check_helper_call.isra.0': > >> verifier.c:(.text+0xf79e): undefined reference to `bpf_printf_prepare' > m68k-linux-ld: kernel/bpf/helpers.o: in function `bpf_base_func_proto': > >> helpers.c:(.text+0xd82): undefined reference to `bpf_snprintf_proto' I'll move the implementation of bpf_printf_prepare/bpf_printf_cleanup and bpf_snprintf to kernel/bpf/helpers.c so that they all get built on kernels with CONFIG_BPF_SYSCALL but not CONFIG_BPF_EVENTS. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0682866294084018201==" MIME-Version: 1.0 From: Florent Revest To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next v3 3/6] bpf: Add a bpf_snprintf helper Date: Wed, 14 Apr 2021 15:32:23 +0200 Message-ID: In-Reply-To: <202104130447.2WLAvV47-lkp@intel.com> List-Id: --===============0682866294084018201== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Apr 12, 2021 at 10:32 PM kernel test robot wrote: > m68k-linux-ld: kernel/bpf/verifier.o: in function `check_helper_call.i= sra.0': > >> verifier.c:(.text+0xf79e): undefined reference to `bpf_printf_prepare' > m68k-linux-ld: kernel/bpf/helpers.o: in function `bpf_base_func_proto': > >> helpers.c:(.text+0xd82): undefined reference to `bpf_snprintf_proto' I'll move the implementation of bpf_printf_prepare/bpf_printf_cleanup and bpf_snprintf to kernel/bpf/helpers.c so that they all get built on kernels with CONFIG_BPF_SYSCALL but not CONFIG_BPF_EVENTS. --===============0682866294084018201==--