* [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq()
@ 2018-02-09 23:12 ` Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-02-09 23:12 UTC (permalink / raw
To: Alex Deucher, Christian König, David Zhou, David Airlie,
Harry Wentland, Tony Cheng, Wenjing Liu
Cc: amd-gfx, dri-devel, linux-kernel, Guenter Roeck, Justin TerAvest,
Craig Bergstrom, Matthias Kaehlcke
The initialization of 'result' is unnecessary, the variable is assigned
unconditionally a few lines below. Removing the initialization also fixes
the following warning when building with clang:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26:
error: implicit conversion from enumeration type 'enum ddc_result'
to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion]
enum dc_status result = DDC_RESULT_UNKNOWN;
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 4ee4c03a6724..8e3a8c1395a3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -1926,7 +1926,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
{
union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}};
union device_service_irq device_service_clear = { { 0 } };
- enum dc_status result = DDC_RESULT_UNKNOWN;
+ enum dc_status result;
bool status = false;
/* For use cases related to down stream connection status change,
* PSR and device auto test, refer to function handle_sst_hpd_irq
--
2.16.0.rc1.238.g530d649a79-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq()
@ 2018-02-09 23:12 ` Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-02-09 23:12 UTC (permalink / raw
To: Alex Deucher, Christian König, David Zhou, David Airlie,
Harry Wentland, Tony Cheng, Wenjing Liu
Cc: Craig Bergstrom, linux-kernel, dri-devel, Justin TerAvest,
Matthias Kaehlcke, amd-gfx, Guenter Roeck
The initialization of 'result' is unnecessary, the variable is assigned
unconditionally a few lines below. Removing the initialization also fixes
the following warning when building with clang:
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26:
error: implicit conversion from enumeration type 'enum ddc_result'
to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion]
enum dc_status result = DDC_RESULT_UNKNOWN;
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 4ee4c03a6724..8e3a8c1395a3 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -1926,7 +1926,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
{
union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}};
union device_service_irq device_service_clear = { { 0 } };
- enum dc_status result = DDC_RESULT_UNKNOWN;
+ enum dc_status result;
bool status = false;
/* For use cases related to down stream connection status change,
* PSR and device auto test, refer to function handle_sst_hpd_irq
--
2.16.0.rc1.238.g530d649a79-goog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq()
2018-02-09 23:12 ` Matthias Kaehlcke
(?)
@ 2018-02-10 0:06 ` Guenter Roeck
-1 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2018-02-10 0:06 UTC (permalink / raw
To: Matthias Kaehlcke
Cc: Alex Deucher, Christian König, David Zhou, David Airlie,
Harry Wentland, Tony Cheng, Wenjing Liu, amd-gfx list,
Maling list - DRI developers, linux-kernel, Guenter Roeck,
Justin TerAvest, Craig Bergstrom
On Fri, Feb 9, 2018 at 3:12 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> The initialization of 'result' is unnecessary, the variable is assigned
> unconditionally a few lines below. Removing the initialization also fixes
> the following warning when building with clang:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26:
> error: implicit conversion from enumeration type 'enum ddc_result'
> to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion]
> enum dc_status result = DDC_RESULT_UNKNOWN;
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 4ee4c03a6724..8e3a8c1395a3 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -1926,7 +1926,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
> {
> union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}};
> union device_service_irq device_service_clear = { { 0 } };
> - enum dc_status result = DDC_RESULT_UNKNOWN;
> + enum dc_status result;
> bool status = false;
> /* For use cases related to down stream connection status change,
> * PSR and device auto test, refer to function handle_sst_hpd_irq
> --
> 2.16.0.rc1.238.g530d649a79-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-10 0:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 23:12 [PATCH] amdgpu/dc: Remove unnecessary initialization in dc_link_handle_hpd_rx_irq() Matthias Kaehlcke
2018-02-09 23:12 ` Matthias Kaehlcke
2018-02-10 0:06 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.