From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932279AbbGJP6K (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jul 2015 11:58:10 -0400
Received: from mail-yk0-f174.google.com ([209.85.160.174]:33891 "EHLO
	mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754143AbbGJP6D (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jul 2015 11:58:03 -0400
MIME-Version: 1.0
In-Reply-To: <CAGS+omC7274iPDdfXpKuM0HvCcEscUE5e5jrDH4DhW4j_Ykt2A@mail.gmail.com>
References: <1436522405-13923-1-git-send-email-jamesjj.liao@mediatek.com>
	<1436522405-13923-6-git-send-email-jamesjj.liao@mediatek.com>
	<CAGS+omC7274iPDdfXpKuM0HvCcEscUE5e5jrDH4DhW4j_Ykt2A@mail.gmail.com>
Date: Fri, 10 Jul 2015 17:58:02 +0200
Message-ID: <CABuKBe+oLmRRHZKnBsfU8icf2r2f3+XrPNMVw_QaGPE9vVxGFw@mail.gmail.com>
Subject: Re: [PATCH v3 5/5] arm64: dts: mt8173: Add subsystem clock controller
 device nodes
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: James Liao <jamesjj.liao@mediatek.com>,
        "moderated list:ARM/Mediatek SoC..." 
	<linux-mediatek@lists.infradead.org>,
        Mike Turquette <mturquette@baylibre.com>,
        Heiko Stubner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Ricky Liang <jcliang@chromium.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2015-07-10 17:02 GMT+02:00 Daniel Kurtz <djkurtz@chromium.org>:
>
> On Jul 10, 2015 18:00, "James Liao" <jamesjj.liao@mediatek.com> wrote:
>>
>> This patch adds device nodes providing subsystem clocks on MT8173,
>> includes mmsys, imgsys, vdecsys, vencsys and vencltsys.
>>
>> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
>> ---
>>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 30
>> ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index a2f63e4..9d74ce5 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -227,6 +227,36 @@
>>                         clocks = <&uart_clk>;
>>                         status = "disabled";
>>                 };
>> +
>> +               mmsys: mmsys@14000000 {
>
> I think we agreed previously that these should all be clock-controller@.
>

I did understand the same.
Please change that.

Thanks.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: matthias.bgg@gmail.com (Matthias Brugger)
Date: Fri, 10 Jul 2015 17:58:02 +0200
Subject: [PATCH v3 5/5] arm64: dts: mt8173: Add subsystem clock controller
 device nodes
In-Reply-To: <CAGS+omC7274iPDdfXpKuM0HvCcEscUE5e5jrDH4DhW4j_Ykt2A@mail.gmail.com>
References: <1436522405-13923-1-git-send-email-jamesjj.liao@mediatek.com>
 <1436522405-13923-6-git-send-email-jamesjj.liao@mediatek.com>
 <CAGS+omC7274iPDdfXpKuM0HvCcEscUE5e5jrDH4DhW4j_Ykt2A@mail.gmail.com>
Message-ID: <CABuKBe+oLmRRHZKnBsfU8icf2r2f3+XrPNMVw_QaGPE9vVxGFw@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

2015-07-10 17:02 GMT+02:00 Daniel Kurtz <djkurtz@chromium.org>:
>
> On Jul 10, 2015 18:00, "James Liao" <jamesjj.liao@mediatek.com> wrote:
>>
>> This patch adds device nodes providing subsystem clocks on MT8173,
>> includes mmsys, imgsys, vdecsys, vencsys and vencltsys.
>>
>> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>
>> ---
>>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 30
>> ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index a2f63e4..9d74ce5 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -227,6 +227,36 @@
>>                         clocks = <&uart_clk>;
>>                         status = "disabled";
>>                 };
>> +
>> +               mmsys: mmsys at 14000000 {
>
> I think we agreed previously that these should all be clock-controller at .
>

I did understand the same.
Please change that.

Thanks.