From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9B93C433EF for ; Mon, 28 Mar 2022 06:18:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 882CA60AED; Mon, 28 Mar 2022 06:18:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HGgt9QCI-dbu; Mon, 28 Mar 2022 06:18:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5074060EAF; Mon, 28 Mar 2022 06:18:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 21026C001D; Mon, 28 Mar 2022 06:18:49 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1B999C0012 for ; Mon, 28 Mar 2022 06:18:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0AAD7417A1 for ; Mon, 28 Mar 2022 06:18:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0CmP8BGxCmvc for ; Mon, 28 Mar 2022 06:18:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7E2744179F for ; Mon, 28 Mar 2022 06:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648448325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TOq4wlvx736BsBWhZ6JA8b6dWPJXab61zLMmfndi4Bc=; b=NJnd8cGK7UQieEGCqFyZWyPW0XwGPPusb/6SxItGyuN1ZhncdlL3EGqWGEXmFXxSMWrY2/ Jgbn40itmxPV5cDT5OEat5OZy3qwlw1KG1okytTt5SDuy/NHl8E9eB8nMNRG9Gpg9iJz2a THFiNqEu2HaB5johcOtmSFk11t6+F58= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-504-Ixkl9030Ph6oouX4kH-Rpw-1; Mon, 28 Mar 2022 02:18:35 -0400 X-MC-Unique: Ixkl9030Ph6oouX4kH-Rpw-1 Received: by mail-lf1-f70.google.com with SMTP id e15-20020ac24e0f000000b0044a8b775985so252146lfr.19 for ; Sun, 27 Mar 2022 23:18:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TOq4wlvx736BsBWhZ6JA8b6dWPJXab61zLMmfndi4Bc=; b=fJx3Ee/FXXfyhBcmXeDj2KDTqPCfRYNmAWCs9SPFCVE/9xFHNKW4KXtvqAZwwYkw9w zJ3wQMAVkhtReChDnrjXaiHiJtZq4nGym3oAWpIdzaIR/klOyo66LWnMCVHcZxeia+wg 7rYOkKfmxUyAXxiCwhqHQKzUUufnD04yngrqKxtOMQ/ZFcxoKPL6x+aiHvCjPEH7HGPz fhyx8uQPyhqKVw4qXliOeHCp24cl6+oUG2GmATcCTfA0HkAuPu0q4Oy1VZzJy6jt873I mnAMiFTxo6tp7GdWwPzlGz0xRaY3qBbdH7mUYXDTMCkL2kjAZdv23FRS8xJ3Ff35Wwjt 4ZxA== X-Gm-Message-State: AOAM532NAEeV9QD9+645BTNzOvOKHvLCpHF3UiBbVfvQ1R6OruHpt3/7 fFYpHtpTRpzYCEsXHvOT6JyZLtQNwplj54fgKoNJ5gfVcuaYYwXl4TieR3FzfoGjU7mQjegrsTm YtflgGUEzjAqHyC42F30gh75n6Jr7N5ksvgXbrv9kGNW+Pd1Wxaitg68++g== X-Received: by 2002:a05:6512:2203:b0:44a:12c9:8696 with SMTP id h3-20020a056512220300b0044a12c98696mr18842242lfu.98.1648448313811; Sun, 27 Mar 2022 23:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI2Q2LMMG8+mW3nff22tnI7dvxsrM50RfloptpE6d8PmS7L1v/505BjHQdTcUuY5bYb0gyp9gkYvlPGG/mgNg= X-Received: by 2002:a05:6512:2203:b0:44a:12c9:8696 with SMTP id h3-20020a056512220300b0044a12c98696mr18842223lfu.98.1648448313408; Sun, 27 Mar 2022 23:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220325050947-mutt-send-email-mst@kernel.org> <20220325060659-mutt-send-email-mst@kernel.org> <20220328015757-mutt-send-email-mst@kernel.org> In-Reply-To: <20220328015757-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 28 Mar 2022 14:18:22 +0800 Message-ID: Subject: Re: To: "Michael S. Tsirkin" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: "Paul E. McKenney" , Peter Zijlstra , Marc Zyngier , Keir Fraser , linux-kernel , virtualization , Thomas Gleixner X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBNYXIgMjgsIDIwMjIgYXQgMTo1OSBQTSBNaWNoYWVsIFMuIFRzaXJraW4gPG1zdEBy ZWRoYXQuY29tPiB3cm90ZToKPgo+IE9uIE1vbiwgTWFyIDI4LCAyMDIyIGF0IDEyOjU2OjQxUE0g KzA4MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiBPbiBGcmksIE1hciAyNSwgMjAyMiBhdCA2OjEw IFBNIE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5jb20+IHdyb3RlOgo+ID4gPgo+ID4g PiBPbiBGcmksIE1hciAyNSwgMjAyMiBhdCAwNToyMDoxOVBNICswODAwLCBKYXNvbiBXYW5nIHdy b3RlOgo+ID4gPiA+IE9uIEZyaSwgTWFyIDI1LCAyMDIyIGF0IDU6MTAgUE0gTWljaGFlbCBTLiBU c2lya2luIDxtc3RAcmVkaGF0LmNvbT4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gRnJp LCBNYXIgMjUsIDIwMjIgYXQgMDM6NTI6MDBQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ ID4gPiA+ID4gT24gRnJpLCBNYXIgMjUsIDIwMjIgYXQgMjozMSBQTSBNaWNoYWVsIFMuIFRzaXJr aW4gPG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEJj YzoKPiA+ID4gPiA+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDMvM10gdmlydGlvOiBoYXJkZW4g dnJpbmcgSVJRCj4gPiA+ID4gPiA+ID4gTWVzc2FnZS1JRDogPDIwMjIwMzI1MDIxNDIyLW11dHQt c2VuZC1lbWFpbC1tc3RAa2VybmVsLm9yZz4KPiA+ID4gPiA+ID4gPiBSZXBseS1UbzoKPiA+ID4g PiA+ID4gPiBJbi1SZXBseS1UbzogPGY3MDQ2MzAzLTdkN2QtZTM5Zi0zYzcxLTM2ODgxMjZjYzgx MkByZWRoYXQuY29tPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gT24gRnJpLCBNYXIgMjUs IDIwMjIgYXQgMTE6MDQ6MDhBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToKPiA+ID4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+ID4gPiDlnKggMjAyMi8zLzI0IOS4i+WNiDc6MDMsIE1pY2hhZWwgUy4g VHNpcmtpbiDlhpnpgZM6Cj4gPiA+ID4gPiA+ID4gPiA+IE9uIFRodSwgTWFyIDI0LCAyMDIyIGF0 IDA0OjQwOjA0UE0gKzA4MDAsIEphc29uIFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiA+ID4g VGhpcyBpcyBhIHJld29yayBvbiB0aGUgcHJldmlvdXMgSVJRIGhhcmRlbmluZyB0aGF0IGlzIGRv bmUgZm9yCj4gPiA+ID4gPiA+ID4gPiA+ID4gdmlydGlvLXBjaSB3aGVyZSBzZXZlcmFsIGRyYXdi YWNrcyB3ZXJlIGZvdW5kIGFuZCB3ZXJlIHJldmVydGVkOgo+ID4gPiA+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gPiA+ID4gMSkgdHJ5IHRvIHVzZSBJUlFGX05PX0FVVE9FTiB3aGljaCBpcyBu b3QgZnJpZW5kbHkgdG8gYWZmaW5pdHkgbWFuYWdlZCBJUlEKPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAgdGhhdCBpcyB1c2VkIGJ5IHNvbWUgZGV2aWNlIHN1Y2ggYXMgdmlydGlvLWJsawo+ID4gPiA+ ID4gPiA+ID4gPiA+IDIpIGRvbmUgb25seSBmb3IgUENJIHRyYW5zcG9ydAo+ID4gPiA+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ID4gSW4gdGhpcyBwYXRjaCwgd2UgdHJpZXMgdG8gYm9y cm93IHRoZSBpZGVhIGZyb20gdGhlIElOVFggSVJRIGhhcmRlbmluZwo+ID4gPiA+ID4gPiA+ID4g PiA+IGluIHRoZSByZXZlcnRlZCBjb21taXQgMDgwY2Q3YzNhYzg3ICgidmlydGlvLXBjaTogaGFy ZGVuIElOVFggaW50ZXJydXB0cyIpCj4gPiA+ID4gPiA+ID4gPiA+ID4gYnkgaW50cm9kdWNpbmcg YSBnbG9iYWwgaXJxX3NvZnRfZW5hYmxlZCB2YXJpYWJsZSBmb3IgZWFjaAo+ID4gPiA+ID4gPiA+ ID4gPiA+IHZpcnRpb19kZXZpY2UuIFRoZW4gd2UgY2FuIHRvIHRvZ2dsZSBpdCBkdXJpbmcKPiA+ ID4gPiA+ID4gPiA+ID4gPiB2aXJ0aW9fcmVzZXRfZGV2aWNlKCkvdmlydGlvX2RldmljZV9yZWFk eSgpLiBBIHN5bmNob3JuaXplX3JjdSgpIGlzCj4gPiA+ID4gPiA+ID4gPiA+ID4gdXNlZCBpbiB2 aXJ0aW9fcmVzZXRfZGV2aWNlKCkgdG8gc3luY2hyb25pemUgd2l0aCB0aGUgSVJRIGhhbmRsZXJz LiBJbgo+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBmdXR1cmUsIHdlIG1heSBwcm92aWRlIGNvbmZp Z19vcHMgZm9yIHRoZSB0cmFuc3BvcnQgdGhhdCBkb2Vzbid0Cj4gPiA+ID4gPiA+ID4gPiA+ID4g dXNlIElSUS4gV2l0aCB0aGlzLCB2cmluZ19pbnRlcnJ1cHQoKSBjYW4gcmV0dXJuIGNoZWNrIGFu ZCBlYXJseSBpZgo+ID4gPiA+ID4gPiA+ID4gPiA+IGlycV9zb2Z0X2VuYWJsZWQgaXMgZmFsc2Uu IFRoaXMgbGVhZCB0byBzbXBfbG9hZF9hY3F1aXJlKCkgdG8gYmUgdXNlZAo+ID4gPiA+ID4gPiA+ ID4gPiA+IGJ1dCB0aGUgY29zdCBzaG91bGQgYmUgYWNjZXB0YWJsZS4KPiA+ID4gPiA+ID4gPiA+ ID4gTWF5YmUgaXQgc2hvdWxkIGJlIGJ1dCBpcyBpdD8gQ2FuJ3Qgd2UgdXNlIHN5bmNocm9uaXpl X2lycSBpbnN0ZWFkPwo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ ID4gPiBFdmVuIGlmIHdlIGFsbG93IHRoZSB0cmFuc3BvcnQgZHJpdmVyIHRvIHN5bmNob3JuaXpl IHRocm91Z2gKPiA+ID4gPiA+ID4gPiA+IHN5bmNocm9uaXplX2lycSgpIHdlIHN0aWxsIG5lZWQg YSBjaGVjayBpbiB0aGUgdnJpbmdfaW50ZXJydXB0KCkuCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPiA+ID4gV2UgZG8gc29tZXRoaW5nIGxpa2UgdGhlIGZvbGxvd2luZyBwcmV2aW91c2x5Ogo+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgaWYgKCFSRUFEX09OQ0UodnBf ZGV2LT5pbnR4X3NvZnRfZW5hYmxlZCkpCj4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAg cmV0dXJuIElSUV9OT05FOwo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IEJ1dCBpdCBs b29rcyBsaWtlIGEgYnVnIHNpbmNlIHNwZWN1bGF0aXZlIHJlYWQgY2FuIGJlIGRvbmUgYmVmb3Jl IHRoZSBjaGVjawo+ID4gPiA+ID4gPiA+ID4gd2hlcmUgdGhlIGludGVycnVwdCBoYW5kbGVyIGNh bid0IHNlZSB0aGUgdW5jb21taXR0ZWQgc2V0dXAgd2hpY2ggaXMgZG9uZSBieQo+ID4gPiA+ID4g PiA+ID4gdGhlIGRyaXZlci4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgZG9uJ3QgdGhp bmsgc28gLSBpZiB5b3Ugc3luYyBhZnRlciBzZXR0aW5nIHRoZSB2YWx1ZSB0aGVuCj4gPiA+ID4g PiA+ID4geW91IGFyZSBndWFyYW50ZWVkIHRoYXQgYW55IGhhbmRsZXIgcnVubmluZyBhZnRlcndh cmRzCj4gPiA+ID4gPiA+ID4gd2lsbCBzZWUgdGhlIG5ldyB2YWx1ZS4KPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gVGhlIHByb2JsZW0gaXMgbm90IGRpc2FibGVkIGJ1dCB0aGUgZW5hYmxlLgo+ID4g PiA+ID4KPiA+ID4gPiA+IFNvIGEgbWlzYmVoYXZpbmcgZGV2aWNlIGNhbiBsb3NlIGludGVycnVw dHM/IFRoYXQncyBub3QgYSBwcm9ibGVtIGF0IGFsbAo+ID4gPiA+ID4gaW1vLgo+ID4gPiA+Cj4g PiA+ID4gSXQncyB0aGUgaW50ZXJydXB0IHJhaXNlZCBiZWZvcmUgc2V0dGluZyBpcnFfc29mdF9l bmFibGVkIHRvIHRydWU6Cj4gPiA+ID4KPiA+ID4gPiBDUFUgMCBwcm9iZSkgZHJpdmVyIHNwZWNp ZmljIHNldHVwIChub3QgY29tbWl0ZWQpCj4gPiA+ID4gQ1BVIDEgSVJRIGhhbmRsZXIpIHJlYWQg dGhlIHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUKPiA+ID4gPiBDUFUgMCBwcm9iZSkgc2V0IGlycV9z b2Z0X2VuYWJsZWQgdG8gdHJ1ZQo+ID4gPiA+IENQVSAxIElSUSBoYW5kbGVyKSByZWFkIGlycV9z b2Z0X2VuYWJsZSBhcyB0cnVlCj4gPiA+ID4gQ1BVIDEgSVJRIGhhbmRsZXIpIHVzZSB0aGUgdW5p bml0aWFsaXplZCB2YXJpYWJsZQo+ID4gPiA+Cj4gPiA+ID4gVGhhbmtzCj4gPiA+Cj4gPiA+IFll YSwgaXQgaHVydHMgaWYgeW91IGRvIGl0LiAgU28gZG8gbm90IGRvIGl0IHRoZW4gOykuCj4gPiA+ Cj4gPiA+IGlycV9zb2Z0X2VuYWJsZWQgKEkgdGhpbmsgZHJpdmVyX29rIG9yIHN0YXR1cyBpcyBh IGJldHRlciBuYW1lKQo+ID4KPiA+IEkgY2FuIGNoYW5nZSBpdCB0byBkcml2ZXJfb2suCj4gPgo+ ID4gPiBzaG91bGQgYmUgaW5pdGlhbGl6ZWQgdG8gZmFsc2UgKmJlZm9yZSogaXJxIGlzIHJlcXVl c3RlZC4KPiA+ID4KPiA+ID4gQW5kIHJlcXVlc3RpbmcgaXJxIGNvbW1pdHMgYWxsIG1lbW9yeSBv dGhlcndpc2UgYWxsIGRyaXZlcnMgd291bGQgYmUKPiA+ID4gYnJva2VuLAo+ID4KPiA+IFNvIEkg dGhpbmsgd2UgbWlnaHQgdGFsayBkaWZmZXJlbnQgaXNzdWVzOgo+ID4KPiA+IDEpIFdoZXRoZXIg cmVxdWVzdF9pcnEoKSBjb21taXRzIHRoZSBwcmV2aW91cyBzZXR1cHMsIEkgdGhpbmsgdGhlCj4g PiBhbnN3ZXIgaXMgeWVzLCBzaW5jZSB0aGUgc3Bpbl91bmxvY2sgb2YgZGVzYy0+bG9jayAocmVs ZWFzZSkgY2FuCj4gPiBndWFyYW50ZWUgdGhpcyB0aG91Z2ggdGhlcmUgc2VlbXMgbm8gZG9jdW1l bnRhdGlvbiBhcm91bmQKPiA+IHJlcXVlc3RfaXJxKCkgdG8gc2F5IHRoaXMuCj4gPgo+ID4gQW5k IEkgY2FuIHNlZSBhdCBsZWFzdCBkcml2ZXJzL3ZpZGVvL2ZiZGV2L29tYXAyL29tYXBmYi9kc3Mv ZGlzcGMuYyBpcwo+ID4gdXNpbmcgc21wX3dtYigpIGJlZm9yZSB0aGUgcmVxdWVzdF9pcnEoKS4K PiA+Cj4gPiBBbmQgZXZlbiBpZiB3cml0ZSBpcyBvcmRlcmVkIHdlIHN0aWxsIG5lZWQgcmVhZCB0 byBiZSBvcmRlcmVkIHRvIGJlCj4gPiBwYWlyZWQgd2l0aCB0aGF0Lgo+ID4KPiA+ID4gaWYgaXQg ZG9lc24ndCBpdCBqdXN0IG5lZWRzIHRvIGJlIGZpeGVkLCBub3Qgd29ya2VkIGFyb3VuZCBpbgo+ ID4gPiB2aXJ0aW8uCj4gPgo+ID4gMikgdmlydGlvIGRyaXZlcnMgbWlnaHQgZG8gYSBsb3Qgb2Yg c2V0dXBzIGJldHdlZW4gcmVxdWVzdF9pcnEoKSBhbmQKPiA+IHZpcnRpb19kZXZpY2VfcmVhZHko KToKPiA+Cj4gPiByZXF1ZXN0X2lycSgpCj4gPiBkcml2ZXIgc3BlY2lmaWMgc2V0dXBzCj4gPiB2 aXJ0aW9fZGV2aWNlX3JlYWR5KCkKPiA+Cj4gPiBDUFUgMCBwcm9iZSkgcmVxdWVzdF9pcnEoKQo+ ID4gQ1BVIDEgSVJRIGhhbmRsZXIpIHJlYWQgdGhlIHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUKPiA+ IENQVSAwIHByb2JlKSBkcml2ZXIgc3BlY2lmaWMgc2V0dXBzCj4gPiBDUFUgMCBwcm9iZSkgc21w X3N0b3JlX3JlbGVhc2UoaW50cl9zb2Z0X2VuYWJsZWQsIHRydWUpLCBjb21taXQgdGhlIHNldHVw cwo+ID4gQ1BVIDEgSVJRIGhhbmRsZXIpIHJlYWQgaXJxX3NvZnRfZW5hYmxlIGFzIHRydWUKPiA+ IENQVSAxIElSUSBoYW5kbGVyKSB1c2UgdGhlIHVuaW5pdGlhbGl6ZWQgdmFyaWFibGUKPiA+Cj4g PiBUaGFua3MKPgo+Cj4gQXMgSSBzYWlkLCB2aXJ0aW9fZGV2aWNlX3JlYWR5IG5lZWRzIHRvIGRv IHN5bmNocm9uaXplX2lycS4KPiBUaGF0IHdpbGwgZ3VhcmFudGVlIGFsbCBzZXR1cCBpcyB2aXNp YmxlIHRvIHRoZSBzcGVjaWZpYyBJUlEsCgpPbmx5IHRoZSBpbnRlcnJ1cHQgYWZ0ZXIgc3luY2hy b25pemVfaXJxKCkgcmV0dXJucy4KCj50aGlzCj4gaXMgd2hhdCBpdCdzIHBvaW50IGlzLgoKV2hh dCBoYXBwZW5zIGlmIGFuIGludGVycnVwdCBpcyByYWlzZWQgaW4gdGhlIG1pZGRsZSBsaWtlOgoK c21wX3N0b3JlX3JlbGVhc2UoZGV2LT5pcnFfc29mdF9lbmFibGVkLCB0cnVlKQpJUlEgaGFuZGxl cgpzeW5jaG9ybml6ZV9pcnEoKQoKSWYgd2UgZG9uJ3QgZW5mb3JjZSBhIHJlYWRpbmcgb3JkZXIs IHRoZSBJUlEgaGFuZGxlciBtYXkgc3RpbGwgc2VlIHRoZQp1bmluaXRpYWxpemVkIHZhcmlhYmxl LgoKVGhhbmtzCgo+Cj4KPiA+ID4KPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFdlIHVzZSBz bXBfc3RvcmVfcmVsYXNlKCkKPiA+ID4gPiA+ID4gdG8gbWFrZSBzdXJlIHRoZSBkcml2ZXIgY29t bWl0cyB0aGUgc2V0dXAgYmVmb3JlIGVuYWJsaW5nIHRoZSBpcnEuIEl0Cj4gPiA+ID4gPiA+IG1l YW5zIHRoZSByZWFkIG5lZWRzIHRvIGJlIG9yZGVyZWQgYXMgd2VsbCBpbiB2cmluZ19pbnRlcnJ1 cHQoKS4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEFsdGhvdWdoIEkg Y291bGRuJ3QgZmluZCBhbnl0aGluZyBhYm91dCB0aGlzIGluIG1lbW9yeS1iYXJyaWVycy50eHQK PiA+ID4gPiA+ID4gPiB3aGljaCBzdXJwcmlzZXMgbWUuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ ID4gPiBDQyBQYXVsIHRvIGhlbHAgbWFrZSBzdXJlIEknbSByaWdodC4KPiA+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+ID4gPiA+IFRvIGF2b2lkIGJyZWFraW5nIGxlZ2FjeSBkZXZpY2Ugd2hpY2ggY2FuIHNlbmQg SVJRIGJlZm9yZSBEUklWRVJfT0ssIGEKPiA+ID4gPiA+ID4gPiA+ID4gPiBtb2R1bGUgcGFyYW1l dGVyIGlzIGludHJvZHVjZWQgdG8gZW5hYmxlIHRoZSBoYXJkZW5pbmcgc28gZnVuY3Rpb24KPiA+ ID4gPiA+ID4gPiA+ID4gPiBoYXJkZW5pbmcgaXMgZGlzYWJsZWQgYnkgZGVmYXVsdC4KPiA+ID4g PiA+ID4gPiA+ID4gV2hpY2ggZGV2aWNlcyBhcmUgdGhlc2U/IEhvdyBjb21lIHRoZXkgc2VuZCBh biBpbnRlcnJ1cHQgYmVmb3JlIHRoZXJlCj4gPiA+ID4gPiA+ID4gPiA+IGFyZSBhbnkgYnVmZmVy cyBpbiBhbnkgcXVldWVzPwo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4g PiA+ID4gPiBJIGNvcGllZCB0aGlzIGZyb20gdGhlIGNvbW1pdCBsb2cgZm9yIDIyYjcwNTBhMDI0 ZDcKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiAiCj4gPiA+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiA+ID4gICAgIFRoaXMgY2hhbmdlIHdpbGwgYWxzbyBiZW5lZml0IG9sZCBoeXBlcnZp c29ycyAoYmVmb3JlIDIwMDkpCj4gPiA+ID4gPiA+ID4gPiAgICAgdGhhdCBzZW5kIGludGVycnVw dHMgd2l0aG91dCBjaGVja2luZyBEUklWRVJfT0s6IHByZXZpb3VzbHksCj4gPiA+ID4gPiA+ID4g PiAgICAgdGhlIGNhbGxiYWNrIGNvdWxkIHJhY2Ugd2l0aCBkcml2ZXItc3BlY2lmaWMgaW5pdGlh bGl6YXRpb24uCj4gPiA+ID4gPiA+ID4gPiAiCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ ID4gSWYgdGhpcyBpcyBvbmx5IGZvciBjb25maWcgaW50ZXJydXB0LCBJIGNhbiByZW1vdmUgdGhl IGFib3ZlIGxvZy4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gVGhp cyBpcyBvbmx5IGZvciBjb25maWcgaW50ZXJydXB0Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBP ay4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiBOb3RlIHRoYXQgdGhlIGhhcmRlbmluZyBpcyBvbmx5 IGRvbmUgZm9yIHZyaW5nIGludGVycnVwdCBzaW5jZSB0aGUKPiA+ID4gPiA+ID4gPiA+ID4gPiBj b25maWcgaW50ZXJydXB0IGhhcmRlbmluZyBpcyBhbHJlYWR5IGRvbmUgaW4gY29tbWl0IDIyYjcw NTBhMDI0ZDcKPiA+ID4gPiA+ID4gPiA+ID4gPiAoInZpcnRpbzogZGVmZXIgY29uZmlnIGNoYW5n ZWQgbm90aWZpY2F0aW9ucyIpLiBCdXQgdGhlIG1ldGhvZCB0aGF0IGlzCj4gPiA+ID4gPiA+ID4g PiA+ID4gdXNlZCBieSBjb25maWcgaW50ZXJydXB0IGNhbid0IGJlIHJldXNlZCBieSB0aGUgdnJp bmcgaW50ZXJydXB0Cj4gPiA+ID4gPiA+ID4gPiA+ID4gaGFuZGxlciBiZWNhdXNlIGl0IHVzZXMg c3BpbmxvY2sgdG8gZG8gdGhlIHN5bmNocm9uaXphdGlvbiB3aGljaCBpcwo+ID4gPiA+ID4gPiA+ ID4gPiA+IGV4cGVuc2l2ZS4KPiA+ID4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IEphc29uIFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4gPiA+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gPiA+ID4gICBk cml2ZXJzL3ZpcnRpby92aXJ0aW8uYyAgICAgICB8IDE5ICsrKysrKysrKysrKysrKysrKysKPiA+ ID4gPiA+ID4gPiA+ID4gPiAgIGRyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgIHwgIDkgKysr KysrKystCj4gPiA+ID4gPiA+ID4gPiA+ID4gICBpbmNsdWRlL2xpbnV4L3ZpcnRpby5oICAgICAg ICB8ICA0ICsrKysKPiA+ID4gPiA+ID4gPiA+ID4gPiAgIGluY2x1ZGUvbGludXgvdmlydGlvX2Nv bmZpZy5oIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ID4gPiA+ID4gPiA+ ICAgNCBmaWxlcyBjaGFuZ2VkLCA1NiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92 aXJ0aW8vdmlydGlvLmMgYi9kcml2ZXJzL3ZpcnRpby92aXJ0aW8uYwo+ID4gPiA+ID4gPiA+ID4g PiA+IGluZGV4IDhkZGU0NGVhMDQ0YS4uODVlMzMxZWZhOWNjIDEwMDY0NAo+ID4gPiA+ID4gPiA+ ID4gPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpby5jCj4gPiA+ID4gPiA+ID4gPiA+ID4g KysrIGIvZHJpdmVycy92aXJ0aW8vdmlydGlvLmMKPiA+ID4gPiA+ID4gPiA+ID4gPiBAQCAtNyw2 ICs3LDEyIEBACj4gPiA+ID4gPiA+ID4gPiA+ID4gICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICNpbmNsdWRlIDx1YXBpL2xpbnV4L3ZpcnRpb19pZHMuaD4KPiA+ ID4gPiA+ID4gPiA+ID4gPiArc3RhdGljIGJvb2wgaXJxX2hhcmRlbmluZyA9IGZhbHNlOwo+ID4g PiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiArbW9kdWxlX3BhcmFtKGlycV9o YXJkZW5pbmcsIGJvb2wsIDA0NDQpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICtNT0RVTEVfUEFSTV9E RVNDKGlycV9oYXJkZW5pbmcsCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAiRGlzYWxi ZSBJUlEgc29mdHdhcmUgcHJvY2Vzc2luZyB3aGVuIGl0IGlzIG5vdCBleHBlY3RlZCIpOwo+ID4g PiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC8qIFVuaXF1ZSBudW1iZXJp bmcgZm9yIHZpcnRpbyBkZXZpY2VzLiAqLwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgc3RhdGljIERF RklORV9JREEodmlydGlvX2luZGV4X2lkYSk7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTIyMCw2 ICsyMjYsMTUgQEAgc3RhdGljIGludCB2aXJ0aW9fZmVhdHVyZXNfb2soc3RydWN0IHZpcnRpb19k ZXZpY2UgKmRldikKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAqICovCj4gPiA+ID4gPiA+ID4gPiA+ ID4gICB2b2lkIHZpcnRpb19yZXNldF9kZXZpY2Uoc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikK PiA+ID4gPiA+ID4gPiA+ID4gPiAgIHsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIC8qCj4gPiA+ID4g PiA+ID4gPiA+ID4gKyAgKiBUaGUgYmVsb3cgc3luY2hyb25pemVfcmN1KCkgZ3VhcmFudGVlcyB0 aGF0IGFueQo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICogaW50ZXJydXB0IGZvciB0aGlzIGxpbmUg YXJyaXZpbmcgYWZ0ZXIKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAqIHN5bmNocm9uaXplX3JjdSgp IGhhcyBjb21wbGV0ZWQgaXMgZ3VhcmFudGVlZCB0byBzZWUKPiA+ID4gPiA+ID4gPiA+ID4gPiAr ICAqIGlycV9zb2Z0X2VuYWJsZWQgPT0gZmFsc2UuCj4gPiA+ID4gPiA+ID4gPiA+IE5ld3MgdG8g bWUgSSBkaWQgbm90IGtub3cgc3luY2hyb25pemVfcmN1IGhhcyBhbnl0aGluZyB0byBkbwo+ID4g PiA+ID4gPiA+ID4gPiB3aXRoIGludGVycnVwdHMuIERpZCBub3QgeW91IGludGVuZCB0byB1c2Ug c3luY2hyb25pemVfaXJxPwo+ID4gPiA+ID4gPiA+ID4gPiBJIGFtIG5vdCBldmVuIDEwMCUgc3Vy ZSBzeW5jaHJvbml6ZV9yY3UgaXMgYnkgZGVzaWduIGEgbWVtb3J5IGJhcnJpZXIKPiA+ID4gPiA+ ID4gPiA+ID4gdGhvdWdoIGl0J3MgbW9zdCBsaWtlbHkgaXMgLi4uCj4gPiA+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IEFjY29yZGluZyB0byB0aGUgY29tbWVudCBh Ym92ZSB0cmVlIFJDVSB2ZXJzaW9uIG9mIHN5bmNocm9uaXplX3JjdSgpOgo+ID4gPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gPiA+ICIiIgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ICAq IFJDVSByZWFkLXNpZGUgY3JpdGljYWwgc2VjdGlvbnMgYXJlIGRlbGltaXRlZCBieSByY3VfcmVh ZF9sb2NrKCkKPiA+ID4gPiA+ID4gPiA+ICAqIGFuZCByY3VfcmVhZF91bmxvY2soKSwgYW5kIG1h eSBiZSBuZXN0ZWQuICBJbiBhZGRpdGlvbiwgYnV0IG9ubHkgaW4KPiA+ID4gPiA+ID4gPiA+ICAq IHY1LjAgYW5kIGxhdGVyLCByZWdpb25zIG9mIGNvZGUgYWNyb3NzIHdoaWNoIGludGVycnVwdHMs IHByZWVtcHRpb24sCj4gPiA+ID4gPiA+ID4gPiAgKiBvciBzb2Z0aXJxcyBoYXZlIGJlZW4gZGlz YWJsZWQgYWxzbyBzZXJ2ZSBhcyBSQ1UgcmVhZC1zaWRlIGNyaXRpY2FsCj4gPiA+ID4gPiA+ID4g PiAgKiBzZWN0aW9ucy4gIFRoaXMgaW5jbHVkZXMgaGFyZHdhcmUgaW50ZXJydXB0IGhhbmRsZXJz LCBzb2Z0aXJxIGhhbmRsZXJzLAo+ID4gPiA+ID4gPiA+ID4gICogYW5kIE5NSSBoYW5kbGVycy4K PiA+ID4gPiA+ID4gPiA+ICIiIgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IFNvIGlu dGVycnVwdCBoYW5kbGVycyBhcmUgdHJlYXRlZCBhcyByZWFkLXNpZGUgY3JpdGljYWwgc2VjdGlv bnMuCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gQW5kIGl0IGhhcyB0aGUgY29tbWVu dCBmb3IgZXhwbGFpbiB0aGUgYmFycmllcjoKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g PiAiIiIKPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiAgKiBOb3RlIHRoYXQgdGhpcyBn dWFyYW50ZWUgaW1wbGllcyBmdXJ0aGVyIG1lbW9yeS1vcmRlcmluZyBndWFyYW50ZWVzLgo+ID4g PiA+ID4gPiA+ID4gICogT24gc3lzdGVtcyB3aXRoIG1vcmUgdGhhbiBvbmUgQ1BVLCB3aGVuIHN5 bmNocm9uaXplX3JjdSgpIHJldHVybnMsCj4gPiA+ID4gPiA+ID4gPiAgKiBlYWNoIENQVSBpcyBn dWFyYW50ZWVkIHRvIGhhdmUgZXhlY3V0ZWQgYSBmdWxsIG1lbW9yeSBiYXJyaWVyIHNpbmNlCj4g PiA+ID4gPiA+ID4gPiAgKiB0aGUgZW5kIG9mIGl0cyBsYXN0IFJDVSByZWFkLXNpZGUgY3JpdGlj YWwgc2VjdGlvbiB3aG9zZSBiZWdpbm5pbmcKPiA+ID4gPiA+ID4gPiA+ICAqIHByZWNlZGVkIHRo ZSBjYWxsIHRvIHN5bmNocm9uaXplX3JjdSgpLiAgSW4gYWRkaXRpb24sIGVhY2ggQ1BVIGhhdmlu Zwo+ID4gPiA+ID4gPiA+ID4gIiIiCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gU28g b24gU01QIGl0IHByb3ZpZGVzIGEgZnVsbCBiYXJyaWVyLiBBbmQgZm9yIFVQL3RpbnkgUkNVIHdl IGRvbid0IG5lZWQgdGhlCj4gPiA+ID4gPiA+ID4gPiBiYXJyaWVyLCBpZiB0aGUgaW50ZXJydXB0 IGNvbWUgYWZ0ZXIgV1JJVEVfT05DRSgpIGl0IHdpbGwgc2VlIHRoZQo+ID4gPiA+ID4gPiA+ID4g aXJxX3NvZnRfZW5hYmxlZCBhcyBmYWxzZS4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4K PiA+ID4gPiA+ID4gPiBZb3UgYXJlIHJpZ2h0LiBTbyB0aGVuCj4gPiA+ID4gPiA+ID4gMS4gSSBk byBub3QgdGhpbmsgd2UgbmVlZCBsb2FkX2FjcXVpcmUgLSB3aHkgaXMgaXQgbmVlZGVkPyBKdXN0 Cj4gPiA+ID4gPiA+ID4gICAgUkVBRF9PTkNFIHNob3VsZCBkby4KPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gU2VlIGFib3ZlLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IDIuIGlzbid0IHN5bmNo cm9uaXplX2lycSBhbHNvIGRvaW5nIHRoZSBzYW1lIHRoaW5nPwo+ID4gPiA+ID4gPgo+ID4gPiA+ ID4gPgo+ID4gPiA+ID4gPiBZZXMsIGJ1dCBpdCByZXF1aXJlcyBhIGNvbmZpZyBvcHMgc2luY2Ug dGhlIElSUSBrbm93bGVkZ2UgaXMgdHJhbnNwb3J0IHNwZWNpZmljLgo+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ ID4gPiArICAqLwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgV1JJVEVfT05DRShkZXYtPmlycV9zb2Z0 X2VuYWJsZWQsIGZhbHNlKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIHN5bmNocm9uaXplX3JjdSgp Owo+ID4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgZGV2 LT5jb25maWctPnJlc2V0KGRldik7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ID4gPiA+ ID4gPiA+ID4gICBFWFBPUlRfU1lNQk9MX0dQTCh2aXJ0aW9fcmVzZXRfZGV2aWNlKTsKPiA+ID4g PiA+ID4gPiA+ID4gUGxlYXNlIGFkZCBjb21tZW50IGV4cGxhaW5pbmcgd2hlcmUgaXQgd2lsbCBi ZSBlbmFibGVkLgo+ID4gPiA+ID4gPiA+ID4gPiBBbHNvLCB3ZSAqcmVhbGx5KiBkb24ndCBuZWVk IHRvIHN5bmNoIGlmIGl0IHdhcyBhbHJlYWR5IGRpc2FibGVkLAo+ID4gPiA+ID4gPiA+ID4gPiBs ZXQncyBub3QgYWRkIHVzZWxlc3Mgb3ZlcmhlYWQgdG8gdGhlIGJvb3Qgc2VxdWVuY2UuCj4gPiA+ ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IE9rLgo+ID4gPiA+ID4g PiA+ID4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ Cj4gPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTQyNyw2ICs0NDIsMTAgQEAgaW50IHJlZ2lzdGVyX3Zp cnRpb19kZXZpY2Uoc3RydWN0IHZpcnRpb19kZXZpY2UgKmRldikKPiA+ID4gPiA+ID4gPiA+ID4g PiAgICAgICAgICAgc3Bpbl9sb2NrX2luaXQoJmRldi0+Y29uZmlnX2xvY2spOwo+ID4gPiA+ID4g PiA+ID4gPiA+ICAgICAgICAgICBkZXYtPmNvbmZpZ19lbmFibGVkID0gZmFsc2U7Cj4gPiA+ID4g PiA+ID4gPiA+ID4gICAgICAgICAgIGRldi0+Y29uZmlnX2NoYW5nZV9wZW5kaW5nID0gZmFsc2U7 Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyBkZXYtPmlycV9zb2Z0X2NoZWNrID0gaXJxX2hhcmRlbmlu ZzsKPiA+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyBpZiAoZGV2LT5p cnFfc29mdF9jaGVjaykKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAgICAgICAgZGV2X2luZm8oJmRl di0+ZGV2LCAiSVJRIGhhcmRlbmluZyBpcyBlbmFibGVkXG4iKTsKPiA+ID4gPiA+ID4gPiA+ID4g PiAgICAgICAgICAgLyogV2UgYWx3YXlzIHN0YXJ0IGJ5IHJlc2V0dGluZyB0aGUgZGV2aWNlLCBp biBjYXNlIGEgcHJldmlvdXMKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICogZHJpdmVy IG1lc3NlZCBpdCB1cC4gIFRoaXMgYWxzbyB0ZXN0cyB0aGF0IGNvZGUgcGF0aCBhIGxpdHRsZS4g Ki8KPiA+ID4gPiA+ID4gPiA+ID4gb25lIG9mIHRoZSBwb2ludHMgb2YgaGFyZGVuaW5nIGlzIGl0 J3MgYWxzbyBoZWxwZnVsIGZvciBidWdneQo+ID4gPiA+ID4gPiA+ID4gPiBkZXZpY2VzLiB0aGlz IGZsYWcgZGVmZWF0cyB0aGUgcHVycG9zZS4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiA+ID4gRG8geW91IG1lYW46Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4g PiA+ID4gMSkgd2UgbmVlZCBzb21ldGhpbmcgbGlrZSBjb25maWdfZW5hYmxlPyBUaGlzIHNlZW1z IG5vdCBlYXN5IHRvIGJlCj4gPiA+ID4gPiA+ID4gPiBpbXBsZW1lbnRlZCB3aXRob3V0IG9idmlv dXMgb3ZlcmhlYWQsIG1haW5seSB0aGUgc3luY2hyb25pemUgd2l0aCB0aGUKPiA+ID4gPiA+ID4g PiA+IGludGVycnVwdCBoYW5kbGVycwo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gQnV0IHN5 bmNocm9uaXplIGlzIG9ubHkgb24gdGVhci1kb3duIHBhdGguIFRoYXQgaXMgbm90IGNyaXRpY2Fs IGZvciBhbnkKPiA+ID4gPiA+ID4gPiB1c2VycyBhdCB0aGUgbW9tZW50LCBldmVuIGxlc3MgdGhh biBwcm9iZS4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gSSBtZWFudCBpZiB3ZSBoYXZlIHZxLT5p cnFfcGVuZGluZywgd2UgbmVlZCB0byBjYWxsIHZyaW5nX2ludGVycnVwdCgpCj4gPiA+ID4gPiA+ IGluIHRoZSB2aXJ0aW9fZGV2aWNlX3JlYWR5KCkgYW5kIHN5bmNocm9uaXplIHRoZSBJUlEgaGFu ZGxlcnMgd2l0aAo+ID4gPiA+ID4gPiBzcGlubG9jayBvciBvdGhlcnMuCj4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IDIpIGVuYWJsZSB0aGlzIGJ5IGRlZmF1bHQsIHNv IEkgZG9uJ3Qgb2JqZWN0LCBidXQgdGhpcyBtYXkgaGF2ZSBzb21lIHJpc2sKPiA+ID4gPiA+ID4g PiA+IGZvciBvbGQgaHlwZXJ2aXNvcnMKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+ID4gVGhlIHJpc2sgaWYgdGhlcmUncyBhIGRyaXZlciBhZGRpbmcgYnVmZmVycyB3aXRo b3V0IHNldHRpbmcgRFJJVkVSX09LLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBQcm9iYWJseSBu b3QsIHdlIGhhdmUgZGV2aWNlcyB0aGF0IGFjY2VwdCByYW5kb20gaW5wdXRzIGZyb20gb3V0c2lk ZSwKPiA+ID4gPiA+ID4gbmV0LCBjb25zb2xlLCBpbnB1dCBldGMuIEkndmUgZG9uZSBhIHJvdW5k IG9mIGF1ZGl0cyBvZiB0aGUgUWVtdQo+ID4gPiA+ID4gPiBjb2Rlcy4gVGhleSBsb29rIGFsbCBm aW5lIHNpbmNlIGRheTAuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gU28gd2l0aCB0aGlzIGFw cHJvYWNoLCBob3cgYWJvdXQgd2UgcmVuYW1lIHRoZSBmbGFnICJkcml2ZXJfb2siPwo+ID4gPiA+ ID4gPiA+IEFuZCB0aGVuIGFkZF9idWYgY2FuIGFjdHVhbGx5IHRlc3QgaXQgYW5kIEJVR19PTiBp ZiBub3QgdGhlcmUgIChhdCBsZWFzdAo+ID4gPiA+ID4gPiA+IGluIHRoZSBkZWJ1ZyBidWlsZCku Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoaXMgbG9va3MgbGlrZSBhIGhhcmRlbmluZyBvZiB0 aGUgZHJpdmVyIGluIHRoZSBjb3JlIGluc3RlYWQgb2YgdGhlCj4gPiA+ID4gPiA+IGRldmljZS4g SSB0aGluayBpdCBjYW4gYmUgZG9uZSBidXQgaW4gYSBzZXBhcmF0ZSBzZXJpZXMuCj4gPiA+ID4g PiA+Cj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBBbmQgZ29pbmcgZG93biBmcm9tIHRoZXJl LCBob3cgYWJvdXQgd2UgY2FjaGUgc3RhdHVzIGluIHRoZQo+ID4gPiA+ID4gPiA+IGRldmljZT8g VGhlbiB3ZSBkb24ndCBuZWVkIHRvIGtlZXAgcmUtcmVhZGluZyBpdCBldmVyeSB0aW1lLAo+ID4g PiA+ID4gPiA+IHNwZWVkaW5nIGJvb3QgdXAgYSB0aW55IGJpdC4KPiA+ID4gPiA+ID4KPiA+ID4g PiA+ID4gSSBkb24ndCBmdWxseSB1bmRlcnN0YW5kIGhlcmUsIGFjdHVhbGx5IHNwZWMgcmVxdWly ZXMgc3RhdHVzIHRvIGJlCj4gPiA+ID4gPiA+IHJlYWQgYmFjayBmb3IgdmFsaWRhdGlvbiBpbiBt YW55IGNhc2VzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBUaGFua3MKPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g PiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYyBiL2RyaXZl cnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ID4gPiA+ID4gPiA+ID4gPiBpbmRleCA5NjJmMTQ3 N2IxZmEuLjAxNzBmOGM3ODRkOCAxMDA2NDQKPiA+ID4gPiA+ID4gPiA+ID4gPiAtLS0gYS9kcml2 ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5jCj4gPiA+ID4gPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVy cy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+ID4gPiA+ID4gPiA+ID4gPiA+IEBAIC0yMTQ0LDEwICsy MTQ0LDE3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBtb3JlX3VzZWQoY29uc3Qgc3RydWN0IHZyaW5n X3ZpcnRxdWV1ZSAqdnEpCj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIHJldHVybiB2cS0+ cGFja2VkX3JpbmcgPyBtb3JlX3VzZWRfcGFja2VkKHZxKSA6IG1vcmVfdXNlZF9zcGxpdCh2cSk7 Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICB9Cj4gPiA+ID4gPiA+ID4gPiA+ID4gLWlycXJldHVybl90 IHZyaW5nX2ludGVycnVwdChpbnQgaXJxLCB2b2lkICpfdnEpCj4gPiA+ID4gPiA+ID4gPiA+ID4g K2lycXJldHVybl90IHZyaW5nX2ludGVycnVwdChpbnQgaXJxLCB2b2lkICp2KQo+ID4gPiA+ID4g PiA+ID4gPiA+ICAgewo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgc3RydWN0IHZpcnRxdWV1ZSAqX3Zx ID0gdjsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIHN0cnVjdCB2aXJ0aW9fZGV2aWNlICp2ZGV2ID0g X3ZxLT52ZGV2Owo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICBzdHJ1Y3QgdnJpbmdfdmly dHF1ZXVlICp2cSA9IHRvX3Z2cShfdnEpOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgaWYgKCF2aXJ0 aW9faXJxX3NvZnRfZW5hYmxlZCh2ZGV2KSkgewo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICAgICAg ICBkZXZfd2Fybl9vbmNlKCZ2ZGV2LT5kZXYsICJ2aXJ0aW8gdnJpbmcgSVJRIHJhaXNlZCBiZWZv cmUgRFJJVkVSX09LIik7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgIHJldHVybiBJUlFf Tk9ORTsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIH0KPiA+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIGlmICghbW9yZV91c2VkKHZxKSkgewo+ID4gPiA+ID4g PiA+ID4gPiA+ICAgICAgICAgICAgICAgICAgIHByX2RlYnVnKCJ2aXJ0cXVldWUgaW50ZXJydXB0 IHdpdGggbm8gd29yayBmb3IgJXBcbiIsIHZxKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAg ICAgICAgICAgICByZXR1cm4gSVJRX05PTkU7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvbGludXgvdmlydGlvLmggYi9pbmNsdWRlL2xpbnV4L3ZpcnRpby5oCj4gPiA+ ID4gPiA+ID4gPiA+ID4gaW5kZXggNTQ2NGYzOTg5MTJhLi45NTdkNmFkNjA0YWMgMTAwNjQ0Cj4g PiA+ID4gPiA+ID4gPiA+ID4gLS0tIGEvaW5jbHVkZS9saW51eC92aXJ0aW8uaAo+ID4gPiA+ID4g PiA+ID4gPiA+ICsrKyBiL2luY2x1ZGUvbGludXgvdmlydGlvLmgKPiA+ID4gPiA+ID4gPiA+ID4g PiBAQCAtOTUsNiArOTUsOCBAQCBkbWFfYWRkcl90IHZpcnRxdWV1ZV9nZXRfdXNlZF9hZGRyKHN0 cnVjdCB2aXJ0cXVldWUgKnZxKTsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAqIEBmYWlsZWQ6IHNh dmVkIHZhbHVlIGZvciBWSVJUSU9fQ09ORklHX1NfRkFJTEVEIGJpdCAoZm9yIHJlc3RvcmUpCj4g PiA+ID4gPiA+ID4gPiA+ID4gICAgKiBAY29uZmlnX2VuYWJsZWQ6IGNvbmZpZ3VyYXRpb24gY2hh bmdlIHJlcG9ydGluZyBlbmFibGVkCj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgKiBAY29uZmlnX2No YW5nZV9wZW5kaW5nOiBjb25maWd1cmF0aW9uIGNoYW5nZSByZXBvcnRlZCB3aGlsZSBkaXNhYmxl ZAo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgKiBAaXJxX3NvZnRfY2hlY2s6IHdoZXRoZXIgb3Igbm90 IHRvIGNoZWNrIEBpcnFfc29mdF9lbmFibGVkCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAqIEBpcnFf c29mdF9lbmFibGVkOiBjYWxsYmFja3MgZW5hYmxlZAo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICog QGNvbmZpZ19sb2NrOiBwcm90ZWN0cyBjb25maWd1cmF0aW9uIGNoYW5nZSByZXBvcnRpbmcKPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICAqIEBkZXY6IHVuZGVybHlpbmcgZGV2aWNlLgo+ID4gPiA+ID4g PiA+ID4gPiA+ICAgICogQGlkOiB0aGUgZGV2aWNlIHR5cGUgaWRlbnRpZmljYXRpb24gKHVzZWQg dG8gbWF0Y2ggaXQgd2l0aCBhIGRyaXZlcikuCj4gPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTEwOSw2 ICsxMTEsOCBAQCBzdHJ1Y3QgdmlydGlvX2RldmljZSB7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAg ICAgICAgIGJvb2wgZmFpbGVkOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICBib29sIGNv bmZpZ19lbmFibGVkOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICBib29sIGNvbmZpZ19j aGFuZ2VfcGVuZGluZzsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIGJvb2wgaXJxX3NvZnRfY2hlY2s7 Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyBib29sIGlycV9zb2Z0X2VuYWJsZWQ7Cj4gPiA+ID4gPiA+ ID4gPiA+ID4gICAgICAgICAgIHNwaW5sb2NrX3QgY29uZmlnX2xvY2s7Cj4gPiA+ID4gPiA+ID4g PiA+ID4gICAgICAgICAgIHNwaW5sb2NrX3QgdnFzX2xpc3RfbG9jazsgLyogUHJvdGVjdHMgVlFz IGxpc3QgYWNjZXNzICovCj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIHN0cnVjdCBkZXZp Y2UgZGV2Owo+ID4gPiA+ID4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3Zp cnRpb19jb25maWcuaCBiL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5oCj4gPiA+ID4gPiA+ ID4gPiA+ID4gaW5kZXggZGFmZGM3ZjQ4YzAxLi45YzFiNjFmMmU1MjUgMTAwNjQ0Cj4gPiA+ID4g PiA+ID4gPiA+ID4gLS0tIGEvaW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiA+ID4gPiA+ ID4gPiA+ID4gPiArKysgYi9pbmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+ID4gPiA+ID4g PiA+ID4gPiA+IEBAIC0xNzQsNiArMTc0LDI0IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCB2aXJ0aW9f aGFzX2ZlYXR1cmUoY29uc3Qgc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCj4gPiA+ID4gPiA+ ID4gPiA+ID4gICAgICAgICAgIHJldHVybiBfX3ZpcnRpb190ZXN0X2JpdCh2ZGV2LCBmYml0KTsK PiA+ID4gPiA+ID4gPiA+ID4gPiAgIH0KPiA+ID4gPiA+ID4gPiA+ID4gPiArLyoKPiA+ID4gPiA+ ID4gPiA+ID4gPiArICogdmlydGlvX2lycV9zb2Z0X2VuYWJsZWQ6IHdoZXRoZXIgd2UgY2FuIGV4 ZWN1dGUgY2FsbGJhY2tzCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAqIEB2ZGV2OiB0aGUgZGV2aWNl Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAqLwo+ID4gPiA+ID4gPiA+ID4gPiA+ICtzdGF0aWMgaW5s aW5lIGJvb2wgdmlydGlvX2lycV9zb2Z0X2VuYWJsZWQoY29uc3Qgc3RydWN0IHZpcnRpb19kZXZp Y2UgKnZkZXYpCj4gPiA+ID4gPiA+ID4gPiA+ID4gK3sKPiA+ID4gPiA+ID4gPiA+ID4gPiArIGlm ICghdmRldi0+aXJxX3NvZnRfY2hlY2spCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgIHJl dHVybiB0cnVlOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiArIC8q Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgKiBSZWFkIGlycV9zb2Z0X2VuYWJsZWQgYmVmb3JlIHJl YWRpbmcgb3RoZXIgZGV2aWNlIHNwZWNpZmljCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgKiBkYXRh LiBQYXJpZWQgd2l0aCBzbXBfc3RvcmVfcmVsYXNlKCkgaW4KPiA+ID4gPiA+ID4gPiA+ID4gcGFp cmVkCj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IFdpbGwg Zml4Lgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IFRoYW5rcwo+ID4gPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiA+ID4g KyAgKiB2aXJ0aW9fZGV2aWNlX3JlYWR5KCkgYW5kIFdSSVRFX09OQ0UoKS9zeW5jaHJvbml6ZV9y Y3UoKSBpbgo+ID4gPiA+ID4gPiA+ID4gPiA+ICsgICogdmlydGlvX3Jlc2V0X2RldmljZSgpLgo+ ID4gPiA+ID4gPiA+ID4gPiA+ICsgICovCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyByZXR1cm4gc21w X2xvYWRfYWNxdWlyZSgmdmRldi0+aXJxX3NvZnRfZW5hYmxlZCk7Cj4gPiA+ID4gPiA+ID4gPiA+ ID4gK30KPiA+ID4gPiA+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ID4gPiA+ID4gICAvKioKPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICAqIHZpcnRpb19oYXNfZG1hX3F1aXJrIC0gZGV0ZXJtaW5lIHdo ZXRoZXIgdGhpcyBkZXZpY2UgaGFzIHRoZSBETUEgcXVpcmsKPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAqIEB2ZGV2OiB0aGUgZGV2aWNlCj4gPiA+ID4gPiA+ID4gPiA+ID4gQEAgLTIzNiw2ICsyNTQs MTMgQEAgdm9pZCB2aXJ0aW9fZGV2aWNlX3JlYWR5KHN0cnVjdCB2aXJ0aW9fZGV2aWNlICpkZXYp Cj4gPiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgIGlmIChkZXYtPmNvbmZpZy0+ZW5hYmxlX2Ni cykKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgIGRldi0+Y29uZmlnLT5l bmFibGVfY2JzKGRldik7Cj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAvKgo+ID4gPiA+ID4gPiA+ID4g PiA+ICsgICogQ29tbWl0IHRoZSBkcml2ZXIgc2V0dXAgYmVmb3JlIGVuYWJsaW5nIHRoZSB2aXJ0 cXVldWUKPiA+ID4gPiA+ID4gPiA+ID4gPiArICAqIGNhbGxiYWNrcy4gUGFyaWVkIHdpdGggc21w X2xvYWRfYWN1cWlyZSgpIGluCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgKiB2aXJ0aW9faXJxX3Nv ZnRfZW5hYmxlZCgpCj4gPiA+ID4gPiA+ID4gPiA+ID4gKyAgKi8KPiA+ID4gPiA+ID4gPiA+ID4g PiArIHNtcF9zdG9yZV9yZWxlYXNlKCZkZXYtPmlycV9zb2Z0X2VuYWJsZWQsIHRydWUpOwo+ID4g PiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgQlVHX09OKHN0 YXR1cyAmIFZJUlRJT19DT05GSUdfU19EUklWRVJfT0spOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAg ICAgICAgICBkZXYtPmNvbmZpZy0+c2V0X3N0YXR1cyhkZXYsIHN0YXR1cyB8IFZJUlRJT19DT05G SUdfU19EUklWRVJfT0spOwo+ID4gPiA+ID4gPiA+ID4gPiA+ICAgfQo+ID4gPiA+ID4gPiA+ID4g PiA+IC0tCj4gPiA+ID4gPiA+ID4gPiA+ID4gMi4yNS4xCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ Cj4gPiA+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f ClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1m b3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9s aXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63393C433F5 for ; Mon, 28 Mar 2022 06:18:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235693AbiC1GUd (ORCPT ); Mon, 28 Mar 2022 02:20:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbiC1GU3 (ORCPT ); Mon, 28 Mar 2022 02:20:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 34C633CFEB for ; Sun, 27 Mar 2022 23:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648448327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TOq4wlvx736BsBWhZ6JA8b6dWPJXab61zLMmfndi4Bc=; b=UqP44aynsNUqRV+i3rAcVGi7nUdrxhikcMwf/Q/TBrzb/AwKjOI4oOMmqGA0+sWigC9zRC 0/tGxPWIkvSyDpZ1BbPQaO5Tz7u/oePprgYAt5OM9oZcxCR1Jlpm3BC72+fs2m/jhZqXC2 kNS0IjPdV2XQUH5OS5Qdzu6bFcN2zDw= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-QtLNXXxfPZqoNc6FWcXMxQ-1; Mon, 28 Mar 2022 02:18:35 -0400 X-MC-Unique: QtLNXXxfPZqoNc6FWcXMxQ-1 Received: by mail-lj1-f199.google.com with SMTP id h4-20020a2ea484000000b002480c04898aso5515785lji.6 for ; Sun, 27 Mar 2022 23:18:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TOq4wlvx736BsBWhZ6JA8b6dWPJXab61zLMmfndi4Bc=; b=Om8D8BJM3WBskq6HpNcUahUUOHGa11/TL7J6r/EFrTrTJsIsTBD4TKJGvGOqOmA2jo 1rU1fXv90roV9Qom5x2V8hlqOP9Hh9wa8dleYNALH6HFn9dNzcKKTVKq1mB2wYM6QgAN cDsfrxr/T6OUeRuhVk2ckZF1TUg3djKUtkzTnahG26WQCtJrxBPt8UGZ042nWWm8FvAy g9vKJ/bUjKf/YFqF6MXEGZXrGy5j1Lkn4zjAi5oFwd2kwZNkM7d9aXowQkB1GFDPcMGq MzE+eVpCZFlIzV7gKRWQv8ycQB0M9WqRiQxOyDdyVXnly9UBm6B477Z1OYxIVQP8Z38b KhMQ== X-Gm-Message-State: AOAM531UIHyL2iuhWqAnYeCMYS8klzbYg29V+/u5uruxLHz27ooQ/TjJ 6W/uI1XJiBkY7/zcLUO/JCH9ke+yefi+fpk7Cl8YrXlRT9nHoBMGocRoVhb8tPHMEcdcMSl3rzO uoGpnKPkD0i2bveqK5pxuiSApFRr7uZKWEF5j59/c X-Received: by 2002:a05:6512:2203:b0:44a:12c9:8696 with SMTP id h3-20020a056512220300b0044a12c98696mr18842236lfu.98.1648448313760; Sun, 27 Mar 2022 23:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyI2Q2LMMG8+mW3nff22tnI7dvxsrM50RfloptpE6d8PmS7L1v/505BjHQdTcUuY5bYb0gyp9gkYvlPGG/mgNg= X-Received: by 2002:a05:6512:2203:b0:44a:12c9:8696 with SMTP id h3-20020a056512220300b0044a12c98696mr18842223lfu.98.1648448313408; Sun, 27 Mar 2022 23:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220325050947-mutt-send-email-mst@kernel.org> <20220325060659-mutt-send-email-mst@kernel.org> <20220328015757-mutt-send-email-mst@kernel.org> In-Reply-To: <20220328015757-mutt-send-email-mst@kernel.org> From: Jason Wang Date: Mon, 28 Mar 2022 14:18:22 +0800 Message-ID: Subject: Re: To: "Michael S. Tsirkin" Cc: virtualization , linux-kernel , Marc Zyngier , Thomas Gleixner , Peter Zijlstra , Stefano Garzarella , Keir Fraser , "Paul E. McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 1:59 PM Michael S. Tsirkin wrote: > > On Mon, Mar 28, 2022 at 12:56:41PM +0800, Jason Wang wrote: > > On Fri, Mar 25, 2022 at 6:10 PM Michael S. Tsirkin wro= te: > > > > > > On Fri, Mar 25, 2022 at 05:20:19PM +0800, Jason Wang wrote: > > > > On Fri, Mar 25, 2022 at 5:10 PM Michael S. Tsirkin = wrote: > > > > > > > > > > On Fri, Mar 25, 2022 at 03:52:00PM +0800, Jason Wang wrote: > > > > > > On Fri, Mar 25, 2022 at 2:31 PM Michael S. Tsirkin wrote: > > > > > > > > > > > > > > Bcc: > > > > > > > Subject: Re: [PATCH 3/3] virtio: harden vring IRQ > > > > > > > Message-ID: <20220325021422-mutt-send-email-mst@kernel.org> > > > > > > > Reply-To: > > > > > > > In-Reply-To: > > > > > > > > > > > > > > On Fri, Mar 25, 2022 at 11:04:08AM +0800, Jason Wang wrote: > > > > > > > > > > > > > > > > =E5=9C=A8 2022/3/24 =E4=B8=8B=E5=8D=887:03, Michael S. Tsir= kin =E5=86=99=E9=81=93: > > > > > > > > > On Thu, Mar 24, 2022 at 04:40:04PM +0800, Jason Wang wrot= e: > > > > > > > > > > This is a rework on the previous IRQ hardening that is = done for > > > > > > > > > > virtio-pci where several drawbacks were found and were = reverted: > > > > > > > > > > > > > > > > > > > > 1) try to use IRQF_NO_AUTOEN which is not friendly to a= ffinity managed IRQ > > > > > > > > > > that is used by some device such as virtio-blk > > > > > > > > > > 2) done only for PCI transport > > > > > > > > > > > > > > > > > > > > In this patch, we tries to borrow the idea from the INT= X IRQ hardening > > > > > > > > > > in the reverted commit 080cd7c3ac87 ("virtio-pci: harde= n INTX interrupts") > > > > > > > > > > by introducing a global irq_soft_enabled variable for e= ach > > > > > > > > > > virtio_device. Then we can to toggle it during > > > > > > > > > > virtio_reset_device()/virtio_device_ready(). A synchorn= ize_rcu() is > > > > > > > > > > used in virtio_reset_device() to synchronize with the I= RQ handlers. In > > > > > > > > > > the future, we may provide config_ops for the transport= that doesn't > > > > > > > > > > use IRQ. With this, vring_interrupt() can return check = and early if > > > > > > > > > > irq_soft_enabled is false. This lead to smp_load_acquir= e() to be used > > > > > > > > > > but the cost should be acceptable. > > > > > > > > > Maybe it should be but is it? Can't we use synchronize_ir= q instead? > > > > > > > > > > > > > > > > > > > > > > > > Even if we allow the transport driver to synchornize throug= h > > > > > > > > synchronize_irq() we still need a check in the vring_interr= upt(). > > > > > > > > > > > > > > > > We do something like the following previously: > > > > > > > > > > > > > > > > if (!READ_ONCE(vp_dev->intx_soft_enabled)) > > > > > > > > return IRQ_NONE; > > > > > > > > > > > > > > > > But it looks like a bug since speculative read can be done = before the check > > > > > > > > where the interrupt handler can't see the uncommitted setup= which is done by > > > > > > > > the driver. > > > > > > > > > > > > > > I don't think so - if you sync after setting the value then > > > > > > > you are guaranteed that any handler running afterwards > > > > > > > will see the new value. > > > > > > > > > > > > The problem is not disabled but the enable. > > > > > > > > > > So a misbehaving device can lose interrupts? That's not a problem= at all > > > > > imo. > > > > > > > > It's the interrupt raised before setting irq_soft_enabled to true: > > > > > > > > CPU 0 probe) driver specific setup (not commited) > > > > CPU 1 IRQ handler) read the uninitialized variable > > > > CPU 0 probe) set irq_soft_enabled to true > > > > CPU 1 IRQ handler) read irq_soft_enable as true > > > > CPU 1 IRQ handler) use the uninitialized variable > > > > > > > > Thanks > > > > > > Yea, it hurts if you do it. So do not do it then ;). > > > > > > irq_soft_enabled (I think driver_ok or status is a better name) > > > > I can change it to driver_ok. > > > > > should be initialized to false *before* irq is requested. > > > > > > And requesting irq commits all memory otherwise all drivers would be > > > broken, > > > > So I think we might talk different issues: > > > > 1) Whether request_irq() commits the previous setups, I think the > > answer is yes, since the spin_unlock of desc->lock (release) can > > guarantee this though there seems no documentation around > > request_irq() to say this. > > > > And I can see at least drivers/video/fbdev/omap2/omapfb/dss/dispc.c is > > using smp_wmb() before the request_irq(). > > > > And even if write is ordered we still need read to be ordered to be > > paired with that. > > > > > if it doesn't it just needs to be fixed, not worked around in > > > virtio. > > > > 2) virtio drivers might do a lot of setups between request_irq() and > > virtio_device_ready(): > > > > request_irq() > > driver specific setups > > virtio_device_ready() > > > > CPU 0 probe) request_irq() > > CPU 1 IRQ handler) read the uninitialized variable > > CPU 0 probe) driver specific setups > > CPU 0 probe) smp_store_release(intr_soft_enabled, true), commit the set= ups > > CPU 1 IRQ handler) read irq_soft_enable as true > > CPU 1 IRQ handler) use the uninitialized variable > > > > Thanks > > > As I said, virtio_device_ready needs to do synchronize_irq. > That will guarantee all setup is visible to the specific IRQ, Only the interrupt after synchronize_irq() returns. >this > is what it's point is. What happens if an interrupt is raised in the middle like: smp_store_release(dev->irq_soft_enabled, true) IRQ handler synchornize_irq() If we don't enforce a reading order, the IRQ handler may still see the uninitialized variable. Thanks > > > > > > > > > > > > > > > > > > > We use smp_store_relase() > > > > > > to make sure the driver commits the setup before enabling the i= rq. It > > > > > > means the read needs to be ordered as well in vring_interrupt()= . > > > > > > > > > > > > > > > > > > > > Although I couldn't find anything about this in memory-barrie= rs.txt > > > > > > > which surprises me. > > > > > > > > > > > > > > CC Paul to help make sure I'm right. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > To avoid breaking legacy device which can send IRQ befo= re DRIVER_OK, a > > > > > > > > > > module parameter is introduced to enable the hardening = so function > > > > > > > > > > hardening is disabled by default. > > > > > > > > > Which devices are these? How come they send an interrupt = before there > > > > > > > > > are any buffers in any queues? > > > > > > > > > > > > > > > > > > > > > > > > I copied this from the commit log for 22b7050a024d7 > > > > > > > > > > > > > > > > " > > > > > > > > > > > > > > > > This change will also benefit old hypervisors (before 2= 009) > > > > > > > > that send interrupts without checking DRIVER_OK: previo= usly, > > > > > > > > the callback could race with driver-specific initializa= tion. > > > > > > > > " > > > > > > > > > > > > > > > > If this is only for config interrupt, I can remove the abov= e log. > > > > > > > > > > > > > > > > > > > > > This is only for config interrupt. > > > > > > > > > > > > Ok. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Note that the hardening is only done for vring interrup= t since the > > > > > > > > > > config interrupt hardening is already done in commit 22= b7050a024d7 > > > > > > > > > > ("virtio: defer config changed notifications"). But the= method that is > > > > > > > > > > used by config interrupt can't be reused by the vring i= nterrupt > > > > > > > > > > handler because it uses spinlock to do the synchronizat= ion which is > > > > > > > > > > expensive. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Jason Wang > > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > drivers/virtio/virtio.c | 19 ++++++++++++++++++= + > > > > > > > > > > drivers/virtio/virtio_ring.c | 9 ++++++++- > > > > > > > > > > include/linux/virtio.h | 4 ++++ > > > > > > > > > > include/linux/virtio_config.h | 25 ++++++++++++++++++= +++++++ > > > > > > > > > > 4 files changed, 56 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/virtio/virtio.c b/drivers/virtio/v= irtio.c > > > > > > > > > > index 8dde44ea044a..85e331efa9cc 100644 > > > > > > > > > > --- a/drivers/virtio/virtio.c > > > > > > > > > > +++ b/drivers/virtio/virtio.c > > > > > > > > > > @@ -7,6 +7,12 @@ > > > > > > > > > > #include > > > > > > > > > > #include > > > > > > > > > > +static bool irq_hardening =3D false; > > > > > > > > > > + > > > > > > > > > > +module_param(irq_hardening, bool, 0444); > > > > > > > > > > +MODULE_PARM_DESC(irq_hardening, > > > > > > > > > > + "Disalbe IRQ software processing when it is = not expected"); > > > > > > > > > > + > > > > > > > > > > /* Unique numbering for virtio devices. */ > > > > > > > > > > static DEFINE_IDA(virtio_index_ida); > > > > > > > > > > @@ -220,6 +226,15 @@ static int virtio_features_ok(stru= ct virtio_device *dev) > > > > > > > > > > * */ > > > > > > > > > > void virtio_reset_device(struct virtio_device *dev) > > > > > > > > > > { > > > > > > > > > > + /* > > > > > > > > > > + * The below synchronize_rcu() guarantees that any > > > > > > > > > > + * interrupt for this line arriving after > > > > > > > > > > + * synchronize_rcu() has completed is guaranteed to s= ee > > > > > > > > > > + * irq_soft_enabled =3D=3D false. > > > > > > > > > News to me I did not know synchronize_rcu has anything to= do > > > > > > > > > with interrupts. Did not you intend to use synchronize_ir= q? > > > > > > > > > I am not even 100% sure synchronize_rcu is by design a me= mory barrier > > > > > > > > > though it's most likely is ... > > > > > > > > > > > > > > > > > > > > > > > > According to the comment above tree RCU version of synchron= ize_rcu(): > > > > > > > > > > > > > > > > """ > > > > > > > > > > > > > > > > * RCU read-side critical sections are delimited by rcu_rea= d_lock() > > > > > > > > * and rcu_read_unlock(), and may be nested. In addition, = but only in > > > > > > > > * v5.0 and later, regions of code across which interrupts,= preemption, > > > > > > > > * or softirqs have been disabled also serve as RCU read-si= de critical > > > > > > > > * sections. This includes hardware interrupt handlers, so= ftirq handlers, > > > > > > > > * and NMI handlers. > > > > > > > > """ > > > > > > > > > > > > > > > > So interrupt handlers are treated as read-side critical sec= tions. > > > > > > > > > > > > > > > > And it has the comment for explain the barrier: > > > > > > > > > > > > > > > > """ > > > > > > > > > > > > > > > > * Note that this guarantee implies further memory-ordering= guarantees. > > > > > > > > * On systems with more than one CPU, when synchronize_rcu(= ) returns, > > > > > > > > * each CPU is guaranteed to have executed a full memory ba= rrier since > > > > > > > > * the end of its last RCU read-side critical section whose= beginning > > > > > > > > * preceded the call to synchronize_rcu(). In addition, ea= ch CPU having > > > > > > > > """ > > > > > > > > > > > > > > > > So on SMP it provides a full barrier. And for UP/tiny RCU w= e don't need the > > > > > > > > barrier, if the interrupt come after WRITE_ONCE() it will s= ee the > > > > > > > > irq_soft_enabled as false. > > > > > > > > > > > > > > > > > > > > > > You are right. So then > > > > > > > 1. I do not think we need load_acquire - why is it needed? Ju= st > > > > > > > READ_ONCE should do. > > > > > > > > > > > > See above. > > > > > > > > > > > > > 2. isn't synchronize_irq also doing the same thing? > > > > > > > > > > > > > > > > > > Yes, but it requires a config ops since the IRQ knowledge is tr= ansport specific. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + */ > > > > > > > > > > + WRITE_ONCE(dev->irq_soft_enabled, false); > > > > > > > > > > + synchronize_rcu(); > > > > > > > > > > + > > > > > > > > > > dev->config->reset(dev); > > > > > > > > > > } > > > > > > > > > > EXPORT_SYMBOL_GPL(virtio_reset_device); > > > > > > > > > Please add comment explaining where it will be enabled. > > > > > > > > > Also, we *really* don't need to synch if it was already d= isabled, > > > > > > > > > let's not add useless overhead to the boot sequence. > > > > > > > > > > > > > > > > > > > > > > > > Ok. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > @@ -427,6 +442,10 @@ int register_virtio_device(struct = virtio_device *dev) > > > > > > > > > > spin_lock_init(&dev->config_lock); > > > > > > > > > > dev->config_enabled =3D false; > > > > > > > > > > dev->config_change_pending =3D false; > > > > > > > > > > + dev->irq_soft_check =3D irq_hardening; > > > > > > > > > > + > > > > > > > > > > + if (dev->irq_soft_check) > > > > > > > > > > + dev_info(&dev->dev, "IRQ hardening is enabled= \n"); > > > > > > > > > > /* We always start by resetting the device, i= n case a previous > > > > > > > > > > * driver messed it up. This also tests that= code path a little. */ > > > > > > > > > one of the points of hardening is it's also helpful for b= uggy > > > > > > > > > devices. this flag defeats the purpose. > > > > > > > > > > > > > > > > > > > > > > > > Do you mean: > > > > > > > > > > > > > > > > 1) we need something like config_enable? This seems not eas= y to be > > > > > > > > implemented without obvious overhead, mainly the synchroniz= e with the > > > > > > > > interrupt handlers > > > > > > > > > > > > > > But synchronize is only on tear-down path. That is not critic= al for any > > > > > > > users at the moment, even less than probe. > > > > > > > > > > > > I meant if we have vq->irq_pending, we need to call vring_inter= rupt() > > > > > > in the virtio_device_ready() and synchronize the IRQ handlers w= ith > > > > > > spinlock or others. > > > > > > > > > > > > > > > > > > > > > 2) enable this by default, so I don't object, but this may = have some risk > > > > > > > > for old hypervisors > > > > > > > > > > > > > > > > > > > > > The risk if there's a driver adding buffers without setting D= RIVER_OK. > > > > > > > > > > > > Probably not, we have devices that accept random inputs from ou= tside, > > > > > > net, console, input etc. I've done a round of audits of the Qem= u > > > > > > codes. They look all fine since day0. > > > > > > > > > > > > > So with this approach, how about we rename the flag "driver_o= k"? > > > > > > > And then add_buf can actually test it and BUG_ON if not there= (at least > > > > > > > in the debug build). > > > > > > > > > > > > This looks like a hardening of the driver in the core instead o= f the > > > > > > device. I think it can be done but in a separate series. > > > > > > > > > > > > > > > > > > > > And going down from there, how about we cache status in the > > > > > > > device? Then we don't need to keep re-reading it every time, > > > > > > > speeding boot up a tiny bit. > > > > > > > > > > > > I don't fully understand here, actually spec requires status to= be > > > > > > read back for validation in many cases. > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/vir= tio/virtio_ring.c > > > > > > > > > > index 962f1477b1fa..0170f8c784d8 100644 > > > > > > > > > > --- a/drivers/virtio/virtio_ring.c > > > > > > > > > > +++ b/drivers/virtio/virtio_ring.c > > > > > > > > > > @@ -2144,10 +2144,17 @@ static inline bool more_used(co= nst struct vring_virtqueue *vq) > > > > > > > > > > return vq->packed_ring ? more_used_packed(vq)= : more_used_split(vq); > > > > > > > > > > } > > > > > > > > > > -irqreturn_t vring_interrupt(int irq, void *_vq) > > > > > > > > > > +irqreturn_t vring_interrupt(int irq, void *v) > > > > > > > > > > { > > > > > > > > > > + struct virtqueue *_vq =3D v; > > > > > > > > > > + struct virtio_device *vdev =3D _vq->vdev; > > > > > > > > > > struct vring_virtqueue *vq =3D to_vvq(_vq); > > > > > > > > > > + if (!virtio_irq_soft_enabled(vdev)) { > > > > > > > > > > + dev_warn_once(&vdev->dev, "virtio vring IRQ r= aised before DRIVER_OK"); > > > > > > > > > > + return IRQ_NONE; > > > > > > > > > > + } > > > > > > > > > > + > > > > > > > > > > if (!more_used(vq)) { > > > > > > > > > > pr_debug("virtqueue interrupt with no= work for %p\n", vq); > > > > > > > > > > return IRQ_NONE; > > > > > > > > > > diff --git a/include/linux/virtio.h b/include/linux/vir= tio.h > > > > > > > > > > index 5464f398912a..957d6ad604ac 100644 > > > > > > > > > > --- a/include/linux/virtio.h > > > > > > > > > > +++ b/include/linux/virtio.h > > > > > > > > > > @@ -95,6 +95,8 @@ dma_addr_t virtqueue_get_used_addr(st= ruct virtqueue *vq); > > > > > > > > > > * @failed: saved value for VIRTIO_CONFIG_S_FAILED bi= t (for restore) > > > > > > > > > > * @config_enabled: configuration change reporting en= abled > > > > > > > > > > * @config_change_pending: configuration change repor= ted while disabled > > > > > > > > > > + * @irq_soft_check: whether or not to check @irq_soft_= enabled > > > > > > > > > > + * @irq_soft_enabled: callbacks enabled > > > > > > > > > > * @config_lock: protects configuration change report= ing > > > > > > > > > > * @dev: underlying device. > > > > > > > > > > * @id: the device type identification (used to match= it with a driver). > > > > > > > > > > @@ -109,6 +111,8 @@ struct virtio_device { > > > > > > > > > > bool failed; > > > > > > > > > > bool config_enabled; > > > > > > > > > > bool config_change_pending; > > > > > > > > > > + bool irq_soft_check; > > > > > > > > > > + bool irq_soft_enabled; > > > > > > > > > > spinlock_t config_lock; > > > > > > > > > > spinlock_t vqs_list_lock; /* Protects VQs lis= t access */ > > > > > > > > > > struct device dev; > > > > > > > > > > diff --git a/include/linux/virtio_config.h b/include/li= nux/virtio_config.h > > > > > > > > > > index dafdc7f48c01..9c1b61f2e525 100644 > > > > > > > > > > --- a/include/linux/virtio_config.h > > > > > > > > > > +++ b/include/linux/virtio_config.h > > > > > > > > > > @@ -174,6 +174,24 @@ static inline bool virtio_has_feat= ure(const struct virtio_device *vdev, > > > > > > > > > > return __virtio_test_bit(vdev, fbit); > > > > > > > > > > } > > > > > > > > > > +/* > > > > > > > > > > + * virtio_irq_soft_enabled: whether we can execute cal= lbacks > > > > > > > > > > + * @vdev: the device > > > > > > > > > > + */ > > > > > > > > > > +static inline bool virtio_irq_soft_enabled(const struc= t virtio_device *vdev) > > > > > > > > > > +{ > > > > > > > > > > + if (!vdev->irq_soft_check) > > > > > > > > > > + return true; > > > > > > > > > > + > > > > > > > > > > + /* > > > > > > > > > > + * Read irq_soft_enabled before reading other device = specific > > > > > > > > > > + * data. Paried with smp_store_relase() in > > > > > > > > > paired > > > > > > > > > > > > > > > > > > > > > > > > Will fix. > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > + * virtio_device_ready() and WRITE_ONCE()/synchronize= _rcu() in > > > > > > > > > > + * virtio_reset_device(). > > > > > > > > > > + */ > > > > > > > > > > + return smp_load_acquire(&vdev->irq_soft_enabled); > > > > > > > > > > +} > > > > > > > > > > + > > > > > > > > > > /** > > > > > > > > > > * virtio_has_dma_quirk - determine whether this devi= ce has the DMA quirk > > > > > > > > > > * @vdev: the device > > > > > > > > > > @@ -236,6 +254,13 @@ void virtio_device_ready(struct vi= rtio_device *dev) > > > > > > > > > > if (dev->config->enable_cbs) > > > > > > > > > > dev->config->enable_cbs(dev); > > > > > > > > > > + /* > > > > > > > > > > + * Commit the driver setup before enabling the virtqu= eue > > > > > > > > > > + * callbacks. Paried with smp_load_acuqire() in > > > > > > > > > > + * virtio_irq_soft_enabled() > > > > > > > > > > + */ > > > > > > > > > > + smp_store_release(&dev->irq_soft_enabled, true); > > > > > > > > > > + > > > > > > > > > > BUG_ON(status & VIRTIO_CONFIG_S_DRIVER_OK); > > > > > > > > > > dev->config->set_status(dev, status | VIRTIO_= CONFIG_S_DRIVER_OK); > > > > > > > > > > } > > > > > > > > > > -- > > > > > > > > > > 2.25.1 > > > > > > > > > > > > > > > >