From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbbGMUOH (ORCPT ); Mon, 13 Jul 2015 16:14:07 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33064 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbbGMUOD (ORCPT ); Mon, 13 Jul 2015 16:14:03 -0400 MIME-Version: 1.0 In-Reply-To: <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> References: <1434548543-22949-1-git-send-email-tomeu.vizoso@collabora.com> <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> Date: Mon, 13 Jul 2015 22:14:03 +0200 Message-ID: Subject: Re: [PATCH 04/13] pinctrl: tegra: Only set the gpio range if needed From: Linus Walleij To: Tomeu Vizoso , Stephen Warren , Thierry Reding , Alexandre Courbot Cc: "linux-arm-kernel@lists.infradead.org" , Alexander Holler , Andrzej Hajda , Arnd Bergmann , Dmitry Torokhov , Grant Likely , Greg Kroah-Hartman , Ian Campbell , Javier Martinez Canillas , Krzysztof Kozlowski , Kumar Gala , Len Brown , "linux-kernel@vger.kernel.org" , Lv Zheng , Mark Brown , Mark Rutland , Pawel Moll , "Rafael J. Wysocki" , Robert Moore , Rob Herring , Russell King , =?UTF-8?Q?Terje_Bergstr=C3=B6m?= Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2015 at 3:42 PM, Tomeu Vizoso wrote: > If the gpio DT node has the gpio-ranges property, the range will be > added by the gpio core and doesn't need to be added by the pinctrl > driver. > > By having the gpio-ranges property, we have an explicit dependency from > the gpio node to the pinctrl node and we can stop using the deprecated > pinctrl_add_gpio_range() function. > > Note that when the GPIO device gets probed before the associated > princtrl device, the gpio core actually won't register the gpio range. > Thus, this patch is only safe to be merged after we have in place a way > to assure that gpio devices are probed after their associated pinctrl > devices (such as ordered probing). > > Signed-off-by: Tomeu Vizoso This doesn't look like it would hurt, but need Stephen's opinion on it, and I think he's on vacation. Would check with next-in-line Tegra maintainer, Thierry/Alexandre? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Mon, 13 Jul 2015 22:14:03 +0200 Subject: [PATCH 04/13] pinctrl: tegra: Only set the gpio range if needed In-Reply-To: <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> References: <1434548543-22949-1-git-send-email-tomeu.vizoso@collabora.com> <1434548543-22949-5-git-send-email-tomeu.vizoso@collabora.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 17, 2015 at 3:42 PM, Tomeu Vizoso wrote: > If the gpio DT node has the gpio-ranges property, the range will be > added by the gpio core and doesn't need to be added by the pinctrl > driver. > > By having the gpio-ranges property, we have an explicit dependency from > the gpio node to the pinctrl node and we can stop using the deprecated > pinctrl_add_gpio_range() function. > > Note that when the GPIO device gets probed before the associated > princtrl device, the gpio core actually won't register the gpio range. > Thus, this patch is only safe to be merged after we have in place a way > to assure that gpio devices are probed after their associated pinctrl > devices (such as ordered probing). > > Signed-off-by: Tomeu Vizoso This doesn't look like it would hurt, but need Stephen's opinion on it, and I think he's on vacation. Would check with next-in-line Tegra maintainer, Thierry/Alexandre? Yours, Linus Walleij