All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE
@ 2015-12-02  1:41 Florian Fainelli
  2015-12-02 17:42 ` Ray Jui
  2015-12-10 22:54 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2015-12-02  1:41 UTC (permalink / raw
  To: linux-gpio
  Cc: sbranden, rjui, linus.walleij, bcm-kernel-feedback-list,
	Florian Fainelli

This driver is mandatory for proper operation on the platforms covered
by the ARCH_BCM_MOBILE Kconfig symbol, make sure we do that driver on
for these platforms.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/pinctrl/bcm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index cd11d4d9ad58..b63d7068f26c 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -9,6 +9,7 @@ config PINCTRL_BCM281XX
 	select PINCONF
 	select GENERIC_PINCONF
 	select REGMAP_MMIO
+	default ARCH_BCM_MOBILE
 	help
 	  Say Y here to support Broadcom BCM281xx pinctrl driver, which is used
 	  for the BCM281xx SoC family, including BCM11130, BCM11140, BCM11351,
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE
  2015-12-02  1:41 [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE Florian Fainelli
@ 2015-12-02 17:42 ` Ray Jui
  2015-12-10 22:54 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Ray Jui @ 2015-12-02 17:42 UTC (permalink / raw
  To: Florian Fainelli, linux-gpio
  Cc: sbranden, linus.walleij, bcm-kernel-feedback-list



On 12/1/2015 5:41 PM, Florian Fainelli wrote:
> This driver is mandatory for proper operation on the platforms covered
> by the ARCH_BCM_MOBILE Kconfig symbol, make sure we do that driver on
> for these platforms.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>   drivers/pinctrl/bcm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
> index cd11d4d9ad58..b63d7068f26c 100644
> --- a/drivers/pinctrl/bcm/Kconfig
> +++ b/drivers/pinctrl/bcm/Kconfig
> @@ -9,6 +9,7 @@ config PINCTRL_BCM281XX
>   	select PINCONF
>   	select GENERIC_PINCONF
>   	select REGMAP_MMIO
> +	default ARCH_BCM_MOBILE
>   	help
>   	  Say Y here to support Broadcom BCM281xx pinctrl driver, which is used
>   	  for the BCM281xx SoC family, including BCM11130, BCM11140, BCM11351,
>

pinmux and pinctrl related configurations from the bcm281xx pinctrl 
driver are indeed mandatory for ARCH_BCM_MOBILE related platforms for 
some peripherals to function properly. It looks like we are missing some 
required configurations in the DT files though, but I guess that needs 
to be addressed by separate patches.

This change looks good to me!

Reviewed-by: Ray Jui <rjui@broadcom.com>

Thanks!

Ray

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE
  2015-12-02  1:41 [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE Florian Fainelli
  2015-12-02 17:42 ` Ray Jui
@ 2015-12-10 22:54 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2015-12-10 22:54 UTC (permalink / raw
  To: Florian Fainelli
  Cc: linux-gpio@vger.kernel.org, Scott Branden, Ray Jui,
	bcm-kernel-feedback-list

On Wed, Dec 2, 2015 at 2:41 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:

> This driver is mandatory for proper operation on the platforms covered
> by the ARCH_BCM_MOBILE Kconfig symbol, make sure we do that driver on
> for these platforms.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Patch applied with Ray's Review tag.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-10 22:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-02  1:41 [PATCH] pinctrl: bcm: Default PINCTRL_BCM281XX to y for ARCH_BCM_MOBILE Florian Fainelli
2015-12-02 17:42 ` Ray Jui
2015-12-10 22:54 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.