From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31115C4320A for ; Tue, 3 Aug 2021 23:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1999160F70 for ; Tue, 3 Aug 2021 23:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232536AbhHCX26 (ORCPT ); Tue, 3 Aug 2021 19:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232242AbhHCX26 (ORCPT ); Tue, 3 Aug 2021 19:28:58 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62E7FC061757 for ; Tue, 3 Aug 2021 16:28:46 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id f42so1297198lfv.7 for ; Tue, 03 Aug 2021 16:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=26XXRzt9dXibTBs8tFcvaSA5rKWccDbOxEz0deahLF4=; b=C5cd+9Dun0iDWKDMH2yjUb09Zg5hZvakE2AeBqHmRmFbGfPnUgovMbxcX0YhcEq/Ho tD4wB+hJ7Fli0sTLQzk7H499Bd7WdS/GPgAsKHvqvgx3AZlJd1/Ifn1q9t8pMnVM3HIc wXact7CixRlJ2m89Yq8OpebQUl62rQTouFEOD7XuMJKWJTbtJEpn7Bgx4VYb/1Vnl4Q4 Uxw45eY502vRjXPBOJ0LjJevADFGlDvuvjCX07XgmFUeiaD2TMd80vIJZ89De3TIz1nd HNlXnwNdhgrsiXsFNEVSAgCQckRjikKdFRpc10M+wu8xvSZ5sb2IR3KrEsnbSuDgFQpd 7DOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=26XXRzt9dXibTBs8tFcvaSA5rKWccDbOxEz0deahLF4=; b=PNf9YOmuWa8VY9JAroeloJ10RSfP1BIIhB4HZm/dzanCvktTxjNTsOHitbKtLYlZhC W498HfIJiu8g1zZybHer0n772Bwe6ELBXgWDpds3RsF1dbqmTguLw//u1SbyfxZvcg/u KNFnvdIhvr0GMGo8ednY0qU9RGl+5psWguaNpSArTHO2R0ptObGV8fWFOUyRq1xPUNGV sadxh5M67/smnrwCSea05wSSyPh8db6MZlAMu9WA3Hi02DdKpTIomQ89DZ07HM7P//lA FkpsRKIuB0rTd08GFYk6F6caEla8SwbTdDVevxwVqE6qBGuzGcrNAdgY+uGV5x3eiuOn 9upA== X-Gm-Message-State: AOAM53317Zf/CY9Ivald6pstislyZHA1Ptvd8SuAnajoCfrXNrIA5NNq TQbLx2j57xQRp46AP0wHTAW4h0PxJfJZxa4TFVQKug== X-Google-Smtp-Source: ABdhPJyUZc6BNBI0g+05v2LArwJXGf05Uy0k4jQGGIY7noISjUX1nEzdSTvUisUviEzTga1wB5mdbVNef6eJ2488dMQ= X-Received: by 2002:a05:6512:1084:: with SMTP id j4mr6458477lfg.586.1628033321709; Tue, 03 Aug 2021 16:28:41 -0700 (PDT) MIME-Version: 1.0 References: <20210711231659.255479-1-linus.walleij@linaro.org> <02415358-6635-a974-7682-a721912ca4fc@gmail.com> In-Reply-To: <02415358-6635-a974-7682-a721912ca4fc@gmail.com> From: Linus Walleij Date: Wed, 4 Aug 2021 01:28:30 +0200 Message-ID: Subject: Re: [PATCH] brcmfmac: firmware: Allow per-board firmware binaries To: Dmitry Osipenko Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , linux-wireless , Kalle Valo , phone-devel@vger.kernel.org, newbyte@disroot.org, Stephan Gerhold Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Aug 3, 2021 at 5:53 PM Dmitry Osipenko wrote: > >> + ret = request_firmware_nowait(THIS_MODULE, true, alt_path, > >> + fwctx->dev, GFP_KERNEL, fwctx, > >> + brcmf_fw_request_done); > > This return 0 immediately, despite of the missing firmware file. It's > not a blocking FW request. Ooops I see the bug. I've sent a patch, please test! Thanks for finding this! Linus Walleij