From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbbGMMHs (ORCPT ); Mon, 13 Jul 2015 08:07:48 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:34048 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbbGMMHq (ORCPT ); Mon, 13 Jul 2015 08:07:46 -0400 MIME-Version: 1.0 In-Reply-To: <55925EB1.1030500@atmel.com> References: <1433948699-19800-1-git-send-email-ludovic.desroches@atmel.com> <1433948699-19800-2-git-send-email-ludovic.desroches@atmel.com> <557EF60D.8020007@wwwdotorg.org> <20150617123816.GB12295@odux.rfo.atmel.com> <5581988C.50000@wwwdotorg.org> <55925EB1.1030500@atmel.com> Date: Mon, 13 Jul 2015 14:07:45 +0200 Message-ID: Subject: Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers From: Linus Walleij To: Nicolas Ferre Cc: Stephen Warren , Ludovic Desroches , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre wrote: > - no agreement on 3 points: > 1/ ways to use groups in generic pinctrl > 2/ ways to describe a comprehensive configuration in device tree > 3/ readability of a sysfs information > > - no way out on the generic pinctrl little changes that Ludovic proposed > as Linus W. never gave his point of view (RFC posts on April the 2nd). Yeah I know. I am battling with this, it is one of those topics where you feel "eeeehhhh" and try to avoid looking at it. Sadly I have to... I refer to Documentation/ManagementStyle, chapter 1, "Decisions". What makes me feel uneasy about these things is that the decisions are irreversible due to the nature of the device tree bindings. I am not a manager, but a maintainer... > Ludovic explained at length our point of view and gave detailed > technical arguments. We don't intend to convince you, we just would like > the harmless modifications to be integrated. So is it universally agreed that the changes are harmless? If they are harmless, I would be able to revert the patch and nothing breaks in the world, I don't think that is the case. The case is a piece of code and functionality that is not AT91-specific but has to be maintained in the core pinctrl code forever. That is basically the big problem with anything device tree. It etches stuff in stone so it can't be changed, like ever. Further, the decision on whether to etch this or that is pushed to Linux subsystem maintainers, who are clearly unsuited for the task. :( > As we preferred to give a chance to the generic pinconf/pinctrl for our > use by adding a little bit of flexibility, we are now in a situation > where we are nearly obliged to give up this approach and write a new > driver without the use of the generic facilities: what a pity! > We lost several months of useless work to match what we thought the > maintainer would prefer. > > So Linus, do you confirm that we won't go further with this approach? > > We are pretty disappointed by the way this interaction with the pinctrl > sub-system went. I'm sorry, I am just trying to wait for consensus but it seems to be hard for that to happen. Things I need: - More DT bindings people to look at this patch. - More other driver maintainers to look at this patch. Sacha is one of those I'd like to get an opinion from for example. ACKs, Reviewed-by's are always good. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers Date: Mon, 13 Jul 2015 14:07:45 +0200 Message-ID: References: <1433948699-19800-1-git-send-email-ludovic.desroches@atmel.com> <1433948699-19800-2-git-send-email-ludovic.desroches@atmel.com> <557EF60D.8020007@wwwdotorg.org> <20150617123816.GB12295@odux.rfo.atmel.com> <5581988C.50000@wwwdotorg.org> <55925EB1.1030500@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <55925EB1.1030500-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Ferre Cc: Stephen Warren , Ludovic Desroches , Sascha Hauer , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre wrote: > - no agreement on 3 points: > 1/ ways to use groups in generic pinctrl > 2/ ways to describe a comprehensive configuration in device tree > 3/ readability of a sysfs information > > - no way out on the generic pinctrl little changes that Ludovic proposed > as Linus W. never gave his point of view (RFC posts on April the 2nd). Yeah I know. I am battling with this, it is one of those topics where you feel "eeeehhhh" and try to avoid looking at it. Sadly I have to... I refer to Documentation/ManagementStyle, chapter 1, "Decisions". What makes me feel uneasy about these things is that the decisions are irreversible due to the nature of the device tree bindings. I am not a manager, but a maintainer... > Ludovic explained at length our point of view and gave detailed > technical arguments. We don't intend to convince you, we just would like > the harmless modifications to be integrated. So is it universally agreed that the changes are harmless? If they are harmless, I would be able to revert the patch and nothing breaks in the world, I don't think that is the case. The case is a piece of code and functionality that is not AT91-specific but has to be maintained in the core pinctrl code forever. That is basically the big problem with anything device tree. It etches stuff in stone so it can't be changed, like ever. Further, the decision on whether to etch this or that is pushed to Linux subsystem maintainers, who are clearly unsuited for the task. :( > As we preferred to give a chance to the generic pinconf/pinctrl for our > use by adding a little bit of flexibility, we are now in a situation > where we are nearly obliged to give up this approach and write a new > driver without the use of the generic facilities: what a pity! > We lost several months of useless work to match what we thought the > maintainer would prefer. > > So Linus, do you confirm that we won't go further with this approach? > > We are pretty disappointed by the way this interaction with the pinctrl > sub-system went. I'm sorry, I am just trying to wait for consensus but it seems to be hard for that to happen. Things I need: - More DT bindings people to look at this patch. - More other driver maintainers to look at this patch. Sacha is one of those I'd like to get an opinion from for example. ACKs, Reviewed-by's are always good. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Mon, 13 Jul 2015 14:07:45 +0200 Subject: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers In-Reply-To: <55925EB1.1030500@atmel.com> References: <1433948699-19800-1-git-send-email-ludovic.desroches@atmel.com> <1433948699-19800-2-git-send-email-ludovic.desroches@atmel.com> <557EF60D.8020007@wwwdotorg.org> <20150617123816.GB12295@odux.rfo.atmel.com> <5581988C.50000@wwwdotorg.org> <55925EB1.1030500@atmel.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre wrote: > - no agreement on 3 points: > 1/ ways to use groups in generic pinctrl > 2/ ways to describe a comprehensive configuration in device tree > 3/ readability of a sysfs information > > - no way out on the generic pinctrl little changes that Ludovic proposed > as Linus W. never gave his point of view (RFC posts on April the 2nd). Yeah I know. I am battling with this, it is one of those topics where you feel "eeeehhhh" and try to avoid looking at it. Sadly I have to... I refer to Documentation/ManagementStyle, chapter 1, "Decisions". What makes me feel uneasy about these things is that the decisions are irreversible due to the nature of the device tree bindings. I am not a manager, but a maintainer... > Ludovic explained at length our point of view and gave detailed > technical arguments. We don't intend to convince you, we just would like > the harmless modifications to be integrated. So is it universally agreed that the changes are harmless? If they are harmless, I would be able to revert the patch and nothing breaks in the world, I don't think that is the case. The case is a piece of code and functionality that is not AT91-specific but has to be maintained in the core pinctrl code forever. That is basically the big problem with anything device tree. It etches stuff in stone so it can't be changed, like ever. Further, the decision on whether to etch this or that is pushed to Linux subsystem maintainers, who are clearly unsuited for the task. :( > As we preferred to give a chance to the generic pinconf/pinctrl for our > use by adding a little bit of flexibility, we are now in a situation > where we are nearly obliged to give up this approach and write a new > driver without the use of the generic facilities: what a pity! > We lost several months of useless work to match what we thought the > maintainer would prefer. > > So Linus, do you confirm that we won't go further with this approach? > > We are pretty disappointed by the way this interaction with the pinctrl > sub-system went. I'm sorry, I am just trying to wait for consensus but it seems to be hard for that to happen. Things I need: - More DT bindings people to look at this patch. - More other driver maintainers to look at this patch. Sacha is one of those I'd like to get an opinion from for example. ACKs, Reviewed-by's are always good. Yours, Linus Walleij