From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD337C4332F for ; Sun, 2 Jan 2022 05:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbiABF67 (ORCPT ); Sun, 2 Jan 2022 00:58:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229954AbiABF65 (ORCPT ); Sun, 2 Jan 2022 00:58:57 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD1B9C06173F for ; Sat, 1 Jan 2022 21:58:56 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id i31so68408026lfv.10 for ; Sat, 01 Jan 2022 21:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bSBWxZAgSh0F54j/W0JNACuedJrvZPCXn3NUacLAWAs=; b=xfg8suVrm9P/SE7AdiXsHlWDQCgV9QerWMwbs5J0qaaL+q/cGzNmaNHkektSHPxENR tpVgAnxYTk9dDyswvuLhRGdUtI+FZS2VAKb6Rg7eo8lrin5WIIRobA58muB02Xa1PoY1 c1iqEWaCH3ifdI3cESwDq05BrLIkNWWwFIfIj95iHy5Sq8pw0ygefiVkbwTehPbijY5k 5f+NPB7kzk0BEN9dyY8B9x2Ef2SkVMMslQv03bQdhFg7ocJResUC0zlWkxcS91GukjN5 cmfJwQlMIEbO1TQTm7JYSCqc4MBan5hzFYmhviEjeKPzf0jZ3N8quph+T9Yl4YfqJg4I xINw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bSBWxZAgSh0F54j/W0JNACuedJrvZPCXn3NUacLAWAs=; b=2XFNWnfGKw/R6N+lJYu8qFghbL60seGoSGTPR1ZZglkrjRveEolC4YKODWODl7gDTS IoPP/egJhFDi4B4Mp5rVqOJl8rqdkqIx2IGsxqBapFiKEiUttNIQZ17lkdTqS7J84De7 OaU3ZXuM+UEBQSGVaJVLLHpGIGr9wd+Zk8gjsIAuyMqW3KA8HMTHxnpr5ca5eNPXoS8/ cCJoUN+XI1MhAgwlldaNhVxBe6cK7gmIjZ3se5ZYxlOo8JIBhYY72MW5w4S0RzQUZ7a2 0gQum4AQDVl26NorzPrrP2oVIHWlXwNO1mvaSCVUYIxR/kUjqAGzsAcu6LHcQYQ37ym8 ps0w== X-Gm-Message-State: AOAM5334ABIUH5EBc9R6ncaIaG518Ga9QlSfRBFv91TvuUpD+3JLPTGi cfatXtvu0k4/DRWFAYLEOZQYT8iGe8DzRKJZIYGW4g== X-Google-Smtp-Source: ABdhPJynY3yVg7Hfnyy1ssZ5OlY8mA09ggXgxRHaHInLiaVgaTCb83EMZe0WSHeP+X1H4U22LXxCPkKiJpBEMn8zasg= X-Received: by 2002:a05:6512:39ce:: with SMTP id k14mr19031566lfu.508.1641103135050; Sat, 01 Jan 2022 21:58:55 -0800 (PST) MIME-Version: 1.0 References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-17-marcan@marcan.st> In-Reply-To: <20211226153624.162281-17-marcan@marcan.st> From: Linus Walleij Date: Sun, 2 Jan 2022 06:58:42 +0100 Message-ID: Subject: Re: [PATCH 16/34] brcmfmac: acpi: Add support for fetching Apple ACPI properties To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "Daniel (Deognyoun) Kim" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 26, 2021 at 4:38 PM Hector Martin wrote: > On DT platforms, the module-instance and antenna-sku-info properties > are passed in the DT. On ACPI platforms, module-instance is passed via > the analogous Apple device property mechanism, while the antenna SKU > info is instead obtained via an ACPI method that grabs it from > non-volatile storage. > > Add support for this, to allow proper firmware selection on Apple > platforms. > > Signed-off-by: Hector Martin If the strings treated here are exactly the same as for the device tree, you should be able to just use "devprops" (firmware node) to handle it abstractly, and then the respective DT and ACPI backend will provide the properties. I don't know if this patch I made recently is enough of an examples: https://lore.kernel.org/linux-hwmon/20211206020423.62402-2-linus.walleij@linaro.org/ If the ACPI and DT differs a lot in format and strings etc it may not be worth it. Yours, Linus Walleij