From: Linus Walleij <linus.walleij@linaro.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] gpio: pca953x: make inclusion of <linux/of_platform.h> unconditional
Date: Thu, 10 Dec 2015 19:30:30 +0100 [thread overview]
Message-ID: <CACRpkdbu9ccfiSZFqpYBveh0ShND5fA1zTCzxURcJLeTnu2JQw@mail.gmail.com> (raw)
In-Reply-To: <56680830.8010607@codethink.co.uk>
On Wed, Dec 9, 2015 at 11:53 AM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> On 09/12/15 10:06, Linus Walleij wrote:
>> After adding the DT matching in
>> commit 6f29c9afbe636fc0e35c82a11eaf45c3b85eb07a
>> "gpio: pca935x: fix of-only probed devices"
>> compilation fails like this:
>>
>> CC [M] drivers/gpio/gpio-pca953x.o
>> gpio-pca953x.c: In function ‘pca953x_probe’:
>> gpio-pca953x.c:693:11: error: implicit declaration of
>> function ‘of_match_device’ [-Werror=implicit-function-declaration]
>> match = of_match_device(pca953x_dt_ids, &client->dev);
>
> Thanks, given the driver makes no other attempt to remove OF
> lists if there is no OF present then this may as well be
> unconditionally included.
Hm it seems to fail compilation on a few defconfigs still...
Need to think about adding deps or reintroducing these ifdefs.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-10 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 10:06 [PATCH] gpio: pca953x: make inclusion of <linux/of_platform.h> unconditional Linus Walleij
2015-12-09 10:53 ` Ben Dooks
2015-12-10 18:30 ` Linus Walleij [this message]
2015-12-11 9:05 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbu9ccfiSZFqpYBveh0ShND5fA1zTCzxURcJLeTnu2JQw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.