From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1FC9C433B4 for ; Wed, 19 May 2021 23:38:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABDC1610A2 for ; Wed, 19 May 2021 23:38:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229518AbhESXjk (ORCPT ); Wed, 19 May 2021 19:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhESXjh (ORCPT ); Wed, 19 May 2021 19:39:37 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B913C061574 for ; Wed, 19 May 2021 16:38:15 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id v5so17521246ljg.12 for ; Wed, 19 May 2021 16:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H838k+WFWmKb6rty2DL9eIaIrsjQLnVxjk3iXslgoWI=; b=aGvisEXveeJl32Smasmj3dD6Oc3D9XgGV87Ml8Hngzlt8gSn/f2y6nn0IiVR/bvgIv qXnJBsNTVjzOXZZL1rATfW8/TCGL1zMi9+6C2MzUWoCtZMkWUNgKIFOtWLXU5xlFjKZv zdblZAw24ERKcOB6MKsCHUZuuFyUbew33g315iQ2Gmxb0ehz2v1Ug2rTUUm70tjfluEw YoOsDyFfQSympUSwhvUD5wQunnokDD52x/zDABZgniU59lYt50LSsbIP6aLrdD4YDoig cSqlHIWNbTuiFLAa7Gf7SkiAFS4gapEBVeqMzdT82K8AY31pp8c2nBVazYghs/CBffWY buow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H838k+WFWmKb6rty2DL9eIaIrsjQLnVxjk3iXslgoWI=; b=qijuZSZlwTSGeesUaefxVdlO7LSgs6Wb/k8AAwJEx1aq0uJt7g9PCFUONcIVPcSKXR +P4kT/qOlsBtev29ifWOLmELRW9WEdT/Y5Mm8ezVRdp666UW83ikqP1KcRKhEoisFpKA Dz4kRTL/9cZZ5QKQ8VrA9QNvupMLUuj8puCruWyrHuWN9scLOl9cc+iQ5C3/15vN/cvW RtQqthUhd6x+Q784KgPZxYghpldNrf3ek1Ic6wwxHKyPEceK1eMxjJQVLJjmk8nGklKE fr0yFtXp/THWxwMz/10Ys/1e0OUqFS4xhruZLOU2WhmsH/o604R0OZxLQEJpwfhWylEF AXxw== X-Gm-Message-State: AOAM531IogRJRT5SoHtIE4mlphDKMDX+HXW2usIlEBxvWRFqRREmDzyd mEjawhdyt+tmn/BB9av28pzcVrF8KBNjkfVcipwvnA== X-Google-Smtp-Source: ABdhPJy9LqmYfXGE9cDr+sBaI3InXu0gfmyltLcrcJdcJWLuUignT9jF0UHKFrvXKxe7T+VneXgAO5CF1iskleK/KVU= X-Received: by 2002:a2e:90c7:: with SMTP id o7mr1148791ljg.368.1621467493484; Wed, 19 May 2021 16:38:13 -0700 (PDT) MIME-Version: 1.0 References: <20210511085126.4287-1-thunder.leizhen@huawei.com> In-Reply-To: <20210511085126.4287-1-thunder.leizhen@huawei.com> From: Linus Walleij Date: Thu, 20 May 2021 01:38:02 +0200 Message-ID: Subject: Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe() To: Zhen Lei Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-gpio , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, May 11, 2021 at 10:51 AM Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Patch applied! Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB48C433B4 for ; Wed, 19 May 2021 23:40:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 595AD61004 for ; Wed, 19 May 2021 23:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 595AD61004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x1not7hswy7qyUxSrlZB7Bi558q7Sm76xAf06FioduQ=; b=YyM37LnvOI6xk/4vhJuOcjXXJ GBRBBh/hhnNRaEmkzWCg2FCF76AquLANHUpiARuGdGqBDXwclQWlDD8ZwjqVKvsD42rGde6jGTA1q qJXPbeAC224hsykSZg8sUFBNanOO5Tg1bJctdg/StNAUarq0j9RnQMENB412KQAlDqiBNoLxzV+/0 P81dYzqWL9GMUnC6hYTkW8ylMohD5VwfMVA1AAbkUogzwge2EU267axV1kP6SpIftH9fDGuONw/u2 mHQ4XfbP1QEBYmdixKiGJXBOP9FT0bwawgD/RRsz6xC1tgv1XuDngOmoRbeIkFQfeXOEEPxRj20Tq jLWiAkaFw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljVle-005MVy-9N; Wed, 19 May 2021 23:38:22 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljVlb-005MVo-F2 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 23:38:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=H838k+WFWmKb6rty2DL9eIaIrsjQLnVxjk3iXslgoWI=; b=sjA7drZ2Hxi1/OXbgq0ndBPYhm t1tK13JHQbWrRrx2eXATMiWwFPU6Vrssj3k7O4u+3PHZbWhNfpDFdbyzlR5N47ftdYJ5CLY98JxcH 4FXoPv02fW0wtwteRwk527qQybYlxNOejDk8Ko9k4RwzCiBCWr4jqTppPvt7zDORpwmjPq378M67O GdyRk3hjyXeChVX3s86s1EYTeT4MrDXWINDC2xBwiZ14AlweZrxRGyxs0ksBmLiZA9cnwA2nOC8gY GI5+xYzGF907V36Wo7UmJ3DrXgTtAeIVKJRtg6Txe9aei2+TgUrcISOdcdiO7ILeIgzFj1MTg3T9G jBtH9ysA==; Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljVlY-00FqdK-JZ for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 23:38:17 +0000 Received: by mail-lj1-x22d.google.com with SMTP id o8so17605878ljp.0 for ; Wed, 19 May 2021 16:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H838k+WFWmKb6rty2DL9eIaIrsjQLnVxjk3iXslgoWI=; b=aGvisEXveeJl32Smasmj3dD6Oc3D9XgGV87Ml8Hngzlt8gSn/f2y6nn0IiVR/bvgIv qXnJBsNTVjzOXZZL1rATfW8/TCGL1zMi9+6C2MzUWoCtZMkWUNgKIFOtWLXU5xlFjKZv zdblZAw24ERKcOB6MKsCHUZuuFyUbew33g315iQ2Gmxb0ehz2v1Ug2rTUUm70tjfluEw YoOsDyFfQSympUSwhvUD5wQunnokDD52x/zDABZgniU59lYt50LSsbIP6aLrdD4YDoig cSqlHIWNbTuiFLAa7Gf7SkiAFS4gapEBVeqMzdT82K8AY31pp8c2nBVazYghs/CBffWY buow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H838k+WFWmKb6rty2DL9eIaIrsjQLnVxjk3iXslgoWI=; b=G0flppww/j0/CujI15iwpKiaMJrBpz2xJMTPzICKxX0TbOjlmvzR7RXaajdvtik4sA oOu0ueTYjDkcBdzOWUFAz5+3EC7c0EUW4Zx2DtY7kmfUFbdJK2o8N+qfJbE5Is4HopMN i4p49VE0kskh+8JXt2j65asHGxQzgRkeqDyFLHbaxAHipvm6q3VlTjWwSXhlYaPR3L76 vciutqC45uxsnbOOWWutwid46A3YHTYz71HAVa4DIhCZXIJK871LfjZDhChgRl3u9tJ/ pW3pDtlIqcU9TUMSBhu0V1d5IP3ivnkaKLm21JkHa+Ibx0unTKimfMf2rXN6UYNpetH2 RzbQ== X-Gm-Message-State: AOAM531KFZlg7708t2AMqFEkAEWYz4FtSRxfkirtbMNyGoNrB8TsoudA /YAbYSe4X92U8upf/DSX1RgmAU7NeRvQoqp8MdaFmA== X-Google-Smtp-Source: ABdhPJy9LqmYfXGE9cDr+sBaI3InXu0gfmyltLcrcJdcJWLuUignT9jF0UHKFrvXKxe7T+VneXgAO5CF1iskleK/KVU= X-Received: by 2002:a2e:90c7:: with SMTP id o7mr1148791ljg.368.1621467493484; Wed, 19 May 2021 16:38:13 -0700 (PDT) MIME-Version: 1.0 References: <20210511085126.4287-1-thunder.leizhen@huawei.com> In-Reply-To: <20210511085126.4287-1-thunder.leizhen@huawei.com> From: Linus Walleij Date: Thu, 20 May 2021 01:38:02 +0200 Message-ID: Subject: Re: [PATCH 1/1] pinctrl: iproc-gpio: Remove redundant error printing in iproc_gpio_probe() To: Zhen Lei Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-gpio , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210519_163816_670269_B011194E X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 11, 2021 at 10:51 AM Zhen Lei wrote: > When devm_ioremap_resource() fails, a clear enough error message will be > printed by its subfunction __devm_ioremap_resource(). The error > information contains the device name, failure cause, and possibly resource > information. > > Therefore, remove the error printing here to simplify code and reduce the > binary size. > > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Patch applied! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel