From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489F1C433EF for ; Sun, 2 Jan 2022 05:38:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230405AbiABFip (ORCPT ); Sun, 2 Jan 2022 00:38:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230355AbiABFil (ORCPT ); Sun, 2 Jan 2022 00:38:41 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE25C06173F for ; Sat, 1 Jan 2022 21:38:39 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id x7so68436456lfu.8 for ; Sat, 01 Jan 2022 21:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NKM5pDpKGo5CtAH2kaYK05iHThvnh/g8xXIKQdgPzT4=; b=Jaa78xZz4Ef1rWk+5+c+lsETsvvfUKfaFf2NdHyTLKUbozrIHly0Eb9oAX2cbexbA6 JfqMuVuwGZ7a2wmeOJkQUblcPzxM4WjQxcztd2DRYI5dsNnvbK1fAsK1Osvniu0eptPf jX+lqvjCrkef75juC+FtShWUq8RsfAI/eiChjMHu8God82rZ5elKzIuJ5Pcx7hjdR9/G Szd3hPGvTv6CVGJnnMejGdd5GAB2UuxdVLgTaJHCvuCEjUOJgbdMImQrFFLjPEUcC3dJ n8mS+18IpE93eTslSNobZIPTClvNekn6UV1EOKyZ28XCVO0dTYNVzfMMJBnKlG7nXRf/ ykrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NKM5pDpKGo5CtAH2kaYK05iHThvnh/g8xXIKQdgPzT4=; b=3lb6NZFGidb5rzZVK9PqUAyv6r1JL5/Fs4f9AcSE/14dzYxWkCoV+ghSu/h1vSnDb9 EBGaVyb+GnaVp5Wtj5+bnmVZu/kKEc4hilcVDBPvVR4IeAo//L4kZQZ/jA2lPJbnCesH 8tYxlYkGBR5mUEeydCG4AbRDM25b0W4eh9EgEAWUBXCIVGSUHYo+uztTrQagYO+/Vjvg AkK546uVg+S1JbPZgHVVg4UAsoUGt6NMtWl3BOwm/F1UUsMRIvqWpuysbjudsN6U35sH ROJG7Mpo/LlArWKTtw15YoFArsldlTs4foI1AfbJ/7w65Vb7DGc8RaUx6XwL7sYszRjg QNdA== X-Gm-Message-State: AOAM531F5pBy2XrfbDjdBax31qrvfyQoK6OhDOTbk8rItoRg8OGoCukU SisyJSoGpCvV0NjqtDkaboZHy3ObefULhF64hkZXTg== X-Google-Smtp-Source: ABdhPJwScD+cSe/FoT2vC+ARQMc7NMM24G1QSYXN5N9jDj/84sI63A0trDPqp1K62en32Eo/3RO6hb6S+ag/FDiF8VA= X-Received: by 2002:a05:6512:750:: with SMTP id c16mr37581258lfs.622.1641101917347; Sat, 01 Jan 2022 21:38:37 -0800 (PST) MIME-Version: 1.0 References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-8-marcan@marcan.st> In-Reply-To: <20211226153624.162281-8-marcan@marcan.st> From: Linus Walleij Date: Sun, 2 Jan 2022 06:38:25 +0100 Message-ID: Subject: Re: [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "Daniel (Deognyoun) Kim" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 26, 2021 at 4:37 PM Hector Martin wrote: > On Apple platforms, the One Time Programmable ROM in the Broadcom chips > contains information about the specific board design (module, vendor, > version) that is required to select the correct NVRAM file. Parse this > OTP ROM and extract the required strings. > > Note that the user OTP offset/size is per-chip. This patch does not add > any chips yet. > > Signed-off-by: Hector Martin Overall looks fine! > + const char *chip_params; > + const char *module_params; This variable name "module_params" is a bit confusing since loadable kernel modules have params... Can we think of another name and just put a comment that this refers to the WiFi module building block? Sometimes people talk about SoM:s (system-on-modules), so maybe som_params or brcm_som_params? Yours, Linus Walleij