From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbGNO3W (ORCPT ); Tue, 14 Jul 2015 10:29:22 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:36054 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbbGNO3U convert rfc822-to-8bit (ORCPT ); Tue, 14 Jul 2015 10:29:20 -0400 MIME-Version: 1.0 In-Reply-To: References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> Date: Tue, 14 Jul 2015 10:29:19 -0400 Message-ID: Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set From: Alex Deucher To: Alexander Kuleshov Cc: David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jammy Zhou , yanyang1 , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Maninder Singh , LKML , Maling list - DRI developers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2015 at 4:18 AM, Alexander Kuleshov wrote: > Hello Alex, > > 2015-07-14 11:11 GMT+06:00 Alex Deucher : >> >> This patch breaks the build with debugfs enabled. >> > > I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds > successfully. Did I miss something? > Maybe I need to enable/disable anything else CONFIG_*? > > Thank you. Here's the error: CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_debugfs_regs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1984:2: error: implicit declaration of function ‘debugfs_create_file’ [-Werror=implicit-function-declaration] ent = debugfs_create_file("amdgpu_regs", S_IFREG | S_IRUGO, root, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1984:6: warning: assignment makes pointer from integer without a cast [enabled by default] ent = debugfs_create_file("amdgpu_regs", S_IFREG | S_IRUGO, root, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function ‘amdgpu_debugfs_regs_cleanup’: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1996:2: error: implicit declaration of function ‘debugfs_remove’ [-Werror=implicit-function-declaration] debugfs_remove(adev->debugfs_regs); ^ cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_device.o] Error 1 make[3]: *** [drivers/gpu/drm/amd/amdgpu] Error 2 make[2]: *** [drivers/gpu/drm] Error 2 make[1]: *** [drivers/gpu] Error 2 make: *** [drivers] Error 2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set Date: Tue, 14 Jul 2015 10:29:19 -0400 Message-ID: References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f180.google.com (mail-yk0-f180.google.com [209.85.160.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id C203789C08 for ; Tue, 14 Jul 2015 07:29:20 -0700 (PDT) Received: by ykax123 with SMTP id x123so9296041yka.1 for ; Tue, 14 Jul 2015 07:29:19 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexander Kuleshov Cc: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , LKML , Maling list - DRI developers , Maninder Singh , yanyang1 , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMTQsIDIwMTUgYXQgNDoxOCBBTSwgQWxleGFuZGVyIEt1bGVzaG92CjxrdWxl c2hvdm1haWxAZ21haWwuY29tPiB3cm90ZToKPiBIZWxsbyBBbGV4LAo+Cj4gMjAxNS0wNy0xNCAx MToxMSBHTVQrMDY6MDAgQWxleCBEZXVjaGVyIDxhbGV4ZGV1Y2hlckBnbWFpbC5jb20+Ogo+Pgo+ PiBUaGlzIHBhdGNoIGJyZWFrcyB0aGUgYnVpbGQgd2l0aCBkZWJ1Z2ZzIGVuYWJsZWQuCj4+Cj4K PiBJJ3ZlIHRyaWVkIHRvIGJ1aWx0IHdpdGggQ09ORklHX0RFQlVHX0ZTPXt5L259IGFuZCBpdCBi dWlsZHMKPiBzdWNjZXNzZnVsbHkuIERpZCBJIG1pc3Mgc29tZXRoaW5nPwo+IE1heWJlIEkgbmVl ZCB0byBlbmFibGUvZGlzYWJsZSBhbnl0aGluZyBlbHNlIENPTkZJR18qPwo+Cj4gVGhhbmsgeW91 LgoKSGVyZSdzIHRoZSBlcnJvcjoKICBDQyBbTV0gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9kZXZpY2Uubwpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNl LmM6IEluIGZ1bmN0aW9uCuKAmGFtZGdwdV9kZWJ1Z2ZzX3JlZ3NfaW5pdOKAmToKZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jOjE5ODQ6MjogZXJyb3I6IGltcGxpY2l0 CmRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uIOKAmGRlYnVnZnNfY3JlYXRlX2ZpbGXigJkKWy1XZXJy b3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCiAgZW50ID0gZGVidWdmc19jcmVhdGVf ZmlsZSgiYW1kZ3B1X3JlZ3MiLCBTX0lGUkVHIHwgU19JUlVHTywgcm9vdCwKICBeCmRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYzoxOTg0OjY6IHdhcm5pbmc6IGFzc2ln bm1lbnQKbWFrZXMgcG9pbnRlciBmcm9tIGludGVnZXIgd2l0aG91dCBhIGNhc3QgW2VuYWJsZWQg YnkgZGVmYXVsdF0KICBlbnQgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJhbWRncHVfcmVncyIsIFNf SUZSRUcgfCBTX0lSVUdPLCByb290LAogICAgICBeCmRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9kZXZpY2UuYzogSW4gZnVuY3Rpb24K4oCYYW1kZ3B1X2RlYnVnZnNfcmVnc19jbGVh bnVw4oCZOgpkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmM6MTk5Njoy OiBlcnJvcjogaW1wbGljaXQKZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYZGVidWdmc19yZW1v dmXigJkKWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCiAgZGVidWdmc19y ZW1vdmUoYWRldi0+ZGVidWdmc19yZWdzKTsKICBeCmNjMTogc29tZSB3YXJuaW5ncyBiZWluZyB0 cmVhdGVkIGFzIGVycm9ycwptYWtlWzRdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9kZXZpY2Uub10gRXJyb3IgMQptYWtlWzNdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1XSBFcnJvciAyCm1ha2VbMl06ICoqKiBbZHJpdmVycy9ncHUvZHJtXSBFcnJvciAy Cm1ha2VbMV06ICoqKiBbZHJpdmVycy9ncHVdIEVycm9yIDIKbWFrZTogKioqIFtkcml2ZXJzXSBF cnJvciAyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==