From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbbGNFMB (ORCPT ); Tue, 14 Jul 2015 01:12:01 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:35959 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751628AbbGNFL7 (ORCPT ); Tue, 14 Jul 2015 01:11:59 -0400 MIME-Version: 1.0 In-Reply-To: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> Date: Tue, 14 Jul 2015 01:11:59 -0400 Message-ID: Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set From: Alex Deucher To: Alexander Kuleshov Cc: David Airlie , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Jammy Zhou , yanyang1 , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Maninder Singh , LKML , Maling list - DRI developers Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2015 at 7:03 AM, Alexander Kuleshov wrote: > We have no need to include if the CONFIG_DEBUG_FS option > is not set. > This patch breaks the build with debugfs enabled. Alex > Signed-off-by: Alexander Kuleshov > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index ba46be3..23dbfa4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -27,7 +27,6 @@ > */ > #include > #include > -#include > #include > #include > #include > @@ -44,2 +43,2 @@ > #include "vi.h" > #include "bif/bif_4_1_d.h" > > +#ifdef CONFIG_DEBUG_FS > +#include > +#endif > + > static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev); > static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev); > > -- > 2.5.0-rc1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] gpu/drm/amdgpu: Include only if CONFIG_DEBUG_FS is set Date: Tue, 14 Jul 2015 01:11:59 -0400 Message-ID: References: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com [209.85.160.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97EA36E4B8 for ; Mon, 13 Jul 2015 22:12:00 -0700 (PDT) Received: by ykay190 with SMTP id y190so58048910yka.3 for ; Mon, 13 Jul 2015 22:11:59 -0700 (PDT) In-Reply-To: <1436785437-3457-1-git-send-email-kuleshovmail@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexander Kuleshov Cc: =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , LKML , Maling list - DRI developers , Maninder Singh , yanyang1 , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKdWwgMTMsIDIwMTUgYXQgNzowMyBBTSwgQWxleGFuZGVyIEt1bGVzaG92CjxrdWxl c2hvdm1haWxAZ21haWwuY29tPiB3cm90ZToKPiBXZSBoYXZlIG5vIG5lZWQgdG8gaW5jbHVkZSA8 bGludXgvZGVidWdmcy5oPiBpZiB0aGUgQ09ORklHX0RFQlVHX0ZTIG9wdGlvbgo+IGlzIG5vdCBz ZXQuCj4KClRoaXMgcGF0Y2ggYnJlYWtzIHRoZSBidWlsZCB3aXRoIGRlYnVnZnMgZW5hYmxlZC4K CkFsZXgKCj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEt1bGVzaG92IDxrdWxlc2hvdm1haWxA Z21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2 aWNlLmMgfCA1ICsrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMK PiBpbmRleCBiYTQ2YmUzLi4yM2RiZmE0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYwo+IEBAIC0yNyw3ICsyNyw2IEBACj4gICAqLwo+ICAjaW5jbHVk ZSA8bGludXgvY29uc29sZS5oPgo+ICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+IC0jaW5jbHVk ZSA8bGludXgvZGVidWdmcy5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybVAuaD4KPiAgI2luY2x1ZGUg PGRybS9kcm1fY3J0Y19oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9hbWRncHVfZHJtLmg+Cj4g QEAgLTQ0LDIgKzQzLDIgQEAKPiAgI2luY2x1ZGUgInZpLmgiCj4gICNpbmNsdWRlICJiaWYvYmlm XzRfMV9kLmgiCj4KPiArI2lmZGVmIENPTkZJR19ERUJVR19GUwo+ICsjaW5jbHVkZSA8bGludXgv ZGVidWdmcy5oPgo+ICsjZW5kaWYKPiArCj4gIHN0YXRpYyBpbnQgYW1kZ3B1X2RlYnVnZnNfcmVn c19pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsKPiAgc3RhdGljIHZvaWQgYW1kZ3B1 X2RlYnVnZnNfcmVnc19jbGVhbnVwKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsKPgo+IC0t Cj4gMi41LjAtcmMxCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=