From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v3 0/4] arm64: Add Xen boot support (via fdt) Date: Thu, 29 Oct 2015 14:06:01 +0800 Message-ID: References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: Stefano Stabellini Cc: The development of GNU GRUB , xen-devel@lists.xensource.com, Ian Campbell , Andrei Borzenkov , Vladimir Serbinenko , Leif Lindholm , Ryan Harkin , Linaro UEFI Mailman List , Jon Masters List-Id: xen-devel@lists.xenproject.org Hi Stefano, I have tried my grub on Foundation model, but I did not get this error, I guess that is the UEFI problem ? On 1 October 2015 at 00:00, Stefano Stabellini wrote: > Hi Fu, > > I backported your patches to the CentOS aarch64 grub2 rpm. I am testing > it on X-Gene with EFI firmware. It works fine when booting Xen, but > booting native kernels (no Xen) doesn't work anymore. Grub prints > > error: out of memory. > > Press any key to continue... > > grub is still able to continue and load Linux, but then the kernel fails > to boot with "Cannot open root device", even though the grub config is > still same as before and the rootfs (which is xfs) hasn't changed. > Reverting the patches solved the problem. > > Do you have any ideas on what is causing the issue? Maybe the initramfs > hasn't been properly loaded? > > > Thanks, > > Stefano > > > On Tue, 8 Sep 2015, Fu Wei wrote: >> Hi Vladimir, >> >> Do you have any suggestion on this patchset? >> Do I need to improve anything? >> >> Great thanks for your help. >> >> On 4 August 2015 at 16:34, Fu Wei wrote: >> > Hi Vladimir, >> > >> > this patchset follows all your comment of v2 patchset. >> > Do you have any suggestion on this patchset? >> > >> > Great thanks for your help. >> > >> > >> > On 23 July 2015 at 13:16, wrote: >> >> From: Fu Wei >> >> >> >> - This adds support for the Xen boot on ARM specification for arm64. >> >> >> >> - Add and export some accessor functions of "loaded" flag and >> >> grub_linux_get_fdt function in include/grub/arm64/linux.h for xen boot. >> >> >> >> - Introduce xen_hypervisor, xen_linux, xen_initrd and xen_xsm >> >> to load different binaries for xen boot. >> >> Introduce xen_module to load common or custom module for xen boot. >> >> >> >> - This Xen boot support is a separated module for aarch64, >> >> but reuse the existing code of devicetree in linux module. >> >> >> >> - Add the support of xen_hypervisor, xen_linux and xen_initrd >> >> in util/grub.d/20_linux_xen.in >> >> >> >> - Add the introduction of all xen boot commands in docs/grub.texi >> >> >> >> - The example of this support is >> >> https://wiki.linaro.org/LEG/Engineering/Grub2/Xen_booting_on_Foundation_FVP_model_by_GRUB >> >> >> >> Changelog: >> >> v3: create separate module for xen boot: xen_boot >> >> create separate commands for different types of module >> >> delete order-dependent for commands of xen module >> >> simplify the code >> >> >> >> v2: remove the patches which have been accepted. >> >> according to Vladimir's suggestion, change the command manes >> >> and relevant code: >> >> multiboot-->xen_hypervisor >> >> module-->xen_module >> >> improve the option parsing support for xen_hypervisor/xen_module commands. >> >> add a patch for adding xen_hypervisor/xen_module support >> >> in util/grub.d/20_linux_xen.in. >> >> update docs/grub.texi patch for the new command names. >> >> >> >> v1: The first version upstream patchset to grub-devel mailing list >> >> >> >> >> >> Fu Wei (4): >> >> arm64: Add and export some accessor functions for xen boot >> >> arm64: Add xen_boot module file >> >> * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 >> >> arm64: Add the introduction of xen boot commands in docs/grub.texi >> >> >> >> docs/grub.texi | 56 ++++ >> >> grub-core/Makefile.core.def | 7 + >> >> grub-core/loader/arm64/linux.c | 13 + >> >> grub-core/loader/arm64/xen_boot.c | 685 ++++++++++++++++++++++++++++++++++++++ >> >> include/grub/arm64/linux.h | 6 +- >> >> util/grub.d/20_linux_xen.in | 16 +- >> >> 6 files changed, 779 insertions(+), 4 deletions(-) >> >> create mode 100644 grub-core/loader/arm64/xen_boot.c >> >> >> >> -- >> >> 1.8.3.1 >> >> >> > >> > >> > >> > -- >> > Best regards, >> > >> > Fu Wei >> > Software Engineer >> > Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch >> > Ph: +86 21 61221326(direct) >> > Ph: +86 186 2020 4684 (mobile) >> > Room 1512, Regus One Corporate Avenue,Level 15, >> > One Corporate Avenue,222 Hubin Road,Huangpu District, >> > Shanghai,China 200021 >> >> >> >> -- >> Best regards, >> >> Fu Wei >> Software Engineer >> Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch >> Ph: +86 21 61221326(direct) >> Ph: +86 186 2020 4684 (mobile) >> Room 1512, Regus One Corporate Avenue,Level 15, >> One Corporate Avenue,222 Hubin Road,Huangpu District, >> Shanghai,China 200021 >> -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021