From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740AbbEOOOj (ORCPT ); Fri, 15 May 2015 10:14:39 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34338 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754359AbbEOOOg (ORCPT ); Fri, 15 May 2015 10:14:36 -0400 MIME-Version: 1.0 In-Reply-To: <8715806.mTJfA5WAcP@wuerfel> References: <=fu.wei@linaro.org> <1431688090-2145-1-git-send-email-fu.wei@linaro.org> <1431688090-2145-2-git-send-email-fu.wei@linaro.org> <8715806.mTJfA5WAcP@wuerfel> Date: Fri, 15 May 2015 22:14:36 +0800 Message-ID: Subject: Re: [PATCH 1/6] Documentation: add sbsa-gwdt.txt documentation From: Fu Wei To: Arnd Bergmann Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Guenter Roeck , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Great thanks, np, will do so On 15 May 2015 at 22:06, Arnd Bergmann wrote: > On Friday 15 May 2015 19:08:05 fu.wei@linaro.org wrote: >> From: Fu Wei >> >> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for >> introducing SBSA(Server Base System Architecture) Generic Watchdog >> device node info into FDT >> >> Signed-off-by: Fu Wei > > Looks good, just one minor comment: > >> +Optional properties >> +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). >> + The first is timeout values, then pre-timeout. > > Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to > mention the second number in the timeout-sec property. > > Arnd > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH 1/6] Documentation: add sbsa-gwdt.txt documentation Date: Fri, 15 May 2015 22:14:36 +0800 Message-ID: References: <=fu.wei@linaro.org> <1431688090-2145-1-git-send-email-fu.wei@linaro.org> <1431688090-2145-2-git-send-email-fu.wei@linaro.org> <8715806.mTJfA5WAcP@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <8715806.mTJfA5WAcP@wuerfel> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Guenter Roeck , vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jon Masters , Leo Duran , Jon Corbet List-Id: devicetree@vger.kernel.org Hi Arnd, Great thanks, np, will do so On 15 May 2015 at 22:06, Arnd Bergmann wrote: > On Friday 15 May 2015 19:08:05 fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: >> From: Fu Wei >> >> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for >> introducing SBSA(Server Base System Architecture) Generic Watchdog >> device node info into FDT >> >> Signed-off-by: Fu Wei > > Looks good, just one minor comment: > >> +Optional properties >> +- timeout-sec : Watchdog pre-timeout and timeout values (in seconds). >> + The first is timeout values, then pre-timeout. > > Please update Documentation/watchdog/watchdog-kernel-api.txt as well, to > mention the second number in the timeout-sec property. > > Arnd > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html