From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751500AbbEXQ3u (ORCPT ); Sun, 24 May 2015 12:29:50 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:35414 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbEXQ3p (ORCPT ); Sun, 24 May 2015 12:29:45 -0400 MIME-Version: 1.0 In-Reply-To: <5561F8A8.4080607@codeaurora.org> References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> <1432197156-16947-7-git-send-email-fu.wei@linaro.org> <555DFCD4.3040701@codeaurora.org> <5560D7AC.50009@codeaurora.org> <5560DCB6.3090008@roeck-us.net> <5561E7EA.5090702@codeaurora.org> <5561F8A8.4080607@codeaurora.org> Date: Mon, 25 May 2015 00:29:44 +0800 Message-ID: Subject: Re: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver From: Fu Wei To: Timur Tabi Cc: Guenter Roeck , Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Timur, Sorry, how do you trigger a panic if WS1 ties to reset ?? don't know what is your question could you make it simple: 1) calling panic() on pre-timeout (WS0????) 2) calling panic() on timeout (WS1????) in "first version" , I just print the timeleft for WS1 or panic when WS0 occurs. On 25 May 2015 at 00:13, Timur Tabi wrote: > Fu Wei wrote: >> >> in the first timeout, just panic() maybe not enough, in [RFC] >> version of my patchset, I offer some option as "preaction" to use, but >> for simplifying the first version of driver, I have deleted them. >> but at least, panic() is far more useful than a simple reset. at >> least, it can provide the context of the crashed system to admin. > > > My point is that there is very little difference between > > 1) calling panic() on pre-timeout > 2) calling panic() on timeout > > In both cases, the system will panic. The watchdog API says that the system > should reset when a timeout occurs, so you cannot call panic() before the > timeout expires. > >> If you want to warn user space, that will make driver more >> complicated, I don't think that is a good choose for a first version. >> but we can find a way to improve this later > > In my opinion, this "first version" is not useful. I would like to see a > pre-timeout feature that does not panic or reset when a pre-timeout occurs. > > > -- > Sent by an employee of the Qualcomm Innovation Center, Inc. > The Qualcomm Innovation Center, Inc. is a member of the > Code Aurora Forum, hosted by The Linux Foundation. -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021