From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753536AbbEUItj (ORCPT ); Thu, 21 May 2015 04:49:39 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34487 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbbEUItg (ORCPT ); Thu, 21 May 2015 04:49:36 -0400 MIME-Version: 1.0 In-Reply-To: <10436688.ghBfa0dkUg@wuerfel> References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> <1432197156-16947-4-git-send-email-fu.wei@linaro.org> <10436688.ghBfa0dkUg@wuerfel> Date: Thu, 21 May 2015 16:49:35 +0800 Message-ID: Subject: Re: [PATCH v2 3/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts From: Fu Wei To: Arnd Bergmann Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Guenter Roeck , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet , "mark.rutland" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, yes, you are right , will delete it :-) On 21 May 2015 at 16:45, Arnd Bergmann wrote: > On Thursday 21 May 2015 16:32:32 fu.wei@linaro.org wrote: >> + watchdog0: watchdog@2a450000 { >> + compatible = "arm,sbsa-gwdt"; >> + reg = <0x0 0x2a450000 0 0x10000>, >> + <0x0 0x2a440000 0 0x10000>; >> + reg-names = "refresh", >> + "control"; >> + interrupts = <0 27 4>; >> + interrupt-names = "ws0"; >> + timeout-sec = <10 5>; >> + }; >> }; >> > > just one tiny comment: you can drop the 'watchdog0:' label here, there > is normally no reason to assign a label to a watchdog device, especially > if it's in a .dts file rather than a .dtsi. > > The same is true for the example in the binding documentation. > > Arnd -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v2 3/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts Date: Thu, 21 May 2015 16:49:35 +0800 Message-ID: References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> <1432197156-16947-4-git-send-email-fu.wei@linaro.org> <10436688.ghBfa0dkUg@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <10436688.ghBfa0dkUg@wuerfel> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Guenter Roeck , vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jon Masters , Leo Duran , Jon Corbet , "mark.rutland" List-Id: devicetree@vger.kernel.org Hi Arnd, yes, you are right , will delete it :-) On 21 May 2015 at 16:45, Arnd Bergmann wrote: > On Thursday 21 May 2015 16:32:32 fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: >> + watchdog0: watchdog@2a450000 { >> + compatible = "arm,sbsa-gwdt"; >> + reg = <0x0 0x2a450000 0 0x10000>, >> + <0x0 0x2a440000 0 0x10000>; >> + reg-names = "refresh", >> + "control"; >> + interrupts = <0 27 4>; >> + interrupt-names = "ws0"; >> + timeout-sec = <10 5>; >> + }; >> }; >> > > just one tiny comment: you can drop the 'watchdog0:' label here, there > is normally no reason to assign a label to a watchdog device, especially > if it's in a .dts file rather than a .dtsi. > > The same is true for the example in the binding documentation. > > Arnd -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html