From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755938AbbE2LNx (ORCPT ); Fri, 29 May 2015 07:13:53 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33733 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755712AbbE2LNk (ORCPT ); Fri, 29 May 2015 07:13:40 -0400 MIME-Version: 1.0 In-Reply-To: <20150527104408.GB29002@arm.com> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> <20150526122858.GJ1565@arm.com> <20150526151842.GP1565@arm.com> <20150526153613.GA22487@roeck-us.net> <20150527104408.GB29002@arm.com> Date: Fri, 29 May 2015 19:13:39 +0800 Message-ID: Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device From: Fu Wei To: Will Deacon Cc: Guenter Roeck , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "linaro-acpi@lists.linaro.org" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "tekkamanninja@gmail.com" , "graeme.gregory@linaro.org" , "al.stone@linaro.org" , "hanjun.guo@linaro.org" , "timur@codeaurora.org" , "arnd@arndb.de" , "vgandhi@codeaurora.org" , "wim@iguana.be" , "jcm@redhat.com" , "leo.duran@amd.com" , "corbet@lwn.net" , Mark Rutland , Catalin Marinas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, As you know, I have moved all the GTDT code to ACPI driver , and simplify the GTDT relevant code in arm_arch_timer.c. That will be in my next patchset. but you can check here : https://git.linaro.org/people/fu.wei/linux.git/shortlog/refs/heads/acpi-topic-sbsa-watchdog_upstream_v4_devel Great thanks for your suggestion! On 27 May 2015 at 18:44, Will Deacon wrote: > On Tue, May 26, 2015 at 05:27:33PM +0100, Fu Wei wrote: >> On 26 May 2015 at 23:36, Guenter Roeck wrote: >> > On Tue, May 26, 2015 at 04:18:42PM +0100, Will Deacon wrote: >> >> Sure, the device it describes may only ever exist on ARM systems, but by >> >> that logic then we should be moving lots of drivers back under arch/arm[64]. >> >> >> > It is nt the driver, but its instantiation. The question here would be >> > how and where to instantiate the driver, not where the driver itself >> > is located. The driver itself is ACPI agnostic. >> >> I really don't mind to refactor the code, If we can make this patch better. >> >> But for now, I can't see the good reason to move ACPI-relevant code >> into a watchdog driver. > > I don't really mind where you move it, just as long as it's outside of > arch/arm64. > >> The reasons I put the code here are >> (1)SBSA watchdog only for ARM64 >> (2)GTDT only for ARM, design for ARM, >> (3)For ARM Architecture, only ARM64 support ACPI. >> >> For minimizing arch/arm64/kernel/acpi.c, we can't put the code here, >> and we had better keep these code outside the driver, >> >> So do you have any suggestion for the better location of the GTDT code? > > I don't understand why you can't do the same as > drivers/clocksource/arm_arch_timer.c and parse the table directly in the > driver. If there are objections from the driver/subsystem maintainers then > it sounds like we need a mechanical ACPI table -> platform device > conversion in the core, like we have for device-tree. > > Will -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device Date: Fri, 29 May 2015 19:13:39 +0800 Message-ID: References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> <20150526122858.GJ1565@arm.com> <20150526151842.GP1565@arm.com> <20150526153613.GA22487@roeck-us.net> <20150527104408.GB29002@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150527104408.GB29002-5wv7dgnIgG8@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Will Deacon Cc: Guenter Roeck , Ashwin Chaugule , "suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org" , "linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "tekkamanninja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org" , "jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Will, As you know, I have moved all the GTDT code to ACPI driver , and simplify the GTDT relevant code in arm_arch_timer.c. That will be in my next patchset. but you can check here : https://git.linaro.org/people/fu.wei/linux.git/shortlog/refs/heads/acpi-topic-sbsa-watchdog_upstream_v4_devel Great thanks for your suggestion! On 27 May 2015 at 18:44, Will Deacon wrote: > On Tue, May 26, 2015 at 05:27:33PM +0100, Fu Wei wrote: >> On 26 May 2015 at 23:36, Guenter Roeck wrote: >> > On Tue, May 26, 2015 at 04:18:42PM +0100, Will Deacon wrote: >> >> Sure, the device it describes may only ever exist on ARM systems, but by >> >> that logic then we should be moving lots of drivers back under arch/arm[64]. >> >> >> > It is nt the driver, but its instantiation. The question here would be >> > how and where to instantiate the driver, not where the driver itself >> > is located. The driver itself is ACPI agnostic. >> >> I really don't mind to refactor the code, If we can make this patch better. >> >> But for now, I can't see the good reason to move ACPI-relevant code >> into a watchdog driver. > > I don't really mind where you move it, just as long as it's outside of > arch/arm64. > >> The reasons I put the code here are >> (1)SBSA watchdog only for ARM64 >> (2)GTDT only for ARM, design for ARM, >> (3)For ARM Architecture, only ARM64 support ACPI. >> >> For minimizing arch/arm64/kernel/acpi.c, we can't put the code here, >> and we had better keep these code outside the driver, >> >> So do you have any suggestion for the better location of the GTDT code? > > I don't understand why you can't do the same as > drivers/clocksource/arm_arch_timer.c and parse the table directly in the > driver. If there are objections from the driver/subsystem maintainers then > it sounds like we need a mechanical ACPI table -> platform device > conversion in the core, like we have for device-tree. > > Will -- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021 -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html