From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707DCC433ED for ; Tue, 11 May 2021 16:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2964161260 for ; Tue, 11 May 2021 16:51:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231769AbhEKQxD (ORCPT ); Tue, 11 May 2021 12:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231476AbhEKQxC (ORCPT ); Tue, 11 May 2021 12:53:02 -0400 Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB48C06174A for ; Tue, 11 May 2021 09:51:55 -0700 (PDT) Received: by mail-oo1-xc2e.google.com with SMTP id p6-20020a4adc060000b02901f9a8fc324fso4338667oov.10 for ; Tue, 11 May 2021 09:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=+RJRJaIHaSSStueEp7c4C/AdKDnf+CbyhjFANCnCZTE=; b=e6jUzMAKZwJO6OMOqbd2AF4AK2OBjS+IYl4Reeg8VX0j44W/gvqifH15lQJQzXdrOH VfH3edlfHMDq/PAjZZR2aNO9EmR5l7ay1rhZhv5cj+23A9KXwFk3HuF2PsTAIdr65vow lTM6szYHV402N153dIlmvxF5pVjZ/19745/6M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=+RJRJaIHaSSStueEp7c4C/AdKDnf+CbyhjFANCnCZTE=; b=NKep5rj3/wZMWpsU7kKBcxTvWlXUe+zFRBg3JEQb6qxsZh/JbZNUQXvA9jVVDdrNGC uZTXr+rboLP3P5RbdqSmKeo3f6y+qlysx2QdhLo/htfM8fCRFJiKkITPg2fJT0UMDw4O 0M/lICYWkC3r4a4wmfF2N2UEaGdc/83ITXplqgezEDFp2+ZWlLC7Iqxn0lGaBz6kwMwu AMR1Nwm13Yt8edBIDGrfjKZ9Z6Kbeyq0nMBg0LabaP40Gqwx8StpxKmtmgPbPZDG/lnZ 9xHhlh1FC0fGoil8788MIveALn9Ui4GwXhZ+XCIcAPW1+yXnfXL4vcJuqAp9aDRfQxkm KNdw== X-Gm-Message-State: AOAM532wuwo84Tctjr6FqmgO9xWtcTK8PmDi989LtEaUBOg6vx1TCPeg K2jeh1FP1hg6R61KNvfB5920i/AKibicdpBMtdKLE0JOHGs= X-Google-Smtp-Source: ABdhPJyj2ahEw7C14zjVPw1sfYmwYktfujxVMpaVk9ux+m+l6dUS8yBsvja4qov19tkkiOKjCUmb1rnMw4jrGo3vtSk= X-Received: by 2002:a4a:dc5:: with SMTP id 188mr24189409oob.80.1620751915341; Tue, 11 May 2021 09:51:55 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 11 May 2021 09:51:54 -0700 MIME-Version: 1.0 In-Reply-To: References: <20210511003845.2429846-1-swboyd@chromium.org> <20210511003845.2429846-6-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 11 May 2021 09:51:54 -0700 Message-ID: Subject: Re: [PATCH v6 05/13] module: Add printk formats to add module build ID to stacktraces To: Petr Mladek Cc: Andrew Morton , linux-kernel@vger.kernel.org, Jiri Olsa , Alexei Starovoitov , Jessica Yu , Evan Green , Hsin-Yi Wang , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , linux-doc@vger.kernel.org, Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Petr Mladek (2021-05-11 04:35:21) > On Mon 2021-05-10 17:38:37, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > > --- a/include/linux/module.h > > +++ b/include/linux/module.h > > @@ -11,6 +11,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -364,6 +365,11 @@ struct module { > > /* Unique handle for this module */ > > char name[MODULE_NAME_LEN]; > > > > +#ifdef CONFIG_STACKTRACE_BUILD_ID > > + /* Module build ID */ > > + unsigned char build_id[BUILD_ID_SIZE_MAX]; > > +#endif > > + > > /* Sysfs stuff. */ > > struct module_kobject mkobj; > > struct module_attribute *modinfo_attrs; > > @@ -627,7 +633,7 @@ void *dereference_module_function_descriptor(struct module *mod, void *ptr); > > const char *module_address_lookup(unsigned long addr, > > unsigned long *symbolsize, > > unsigned long *offset, > > - char **modname, > > + char **modname, const unsigned char **modbuildid, > > Nit: It would have been better to follow the existing style and put only one > parameter per-line. > > Please, fix it in the next version if there is any. But no need > to resend it just because of this unless Jessica asks for it. Thanks. akpm already picked this series up and fixed this problem.