* [RFC PATCH 3/3] fs: dax.c: correct terminology used in DAX bit definitions
@ 2020-11-29 4:36 ` Amy Parker
0 siblings, 0 replies; 2+ messages in thread
From: Amy Parker @ 2020-11-29 4:36 UTC (permalink / raw
To: linux-fsdevel, linux-nvdimm; +Cc: dan.j.williams, Jan Kara, Matthew Wilcox
DAX_ZERO_ENTRY is no longer the bit for zero entries - XA_ZERO_ENTRY is.
The documentation above should be accurate to the definitions used accordingly.
Signed-off-by: Amy Parker <enbyamy@gmail.com>
---
fs/dax.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index c2bdccef3140..ec23a4f9edd5 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -66,13 +66,13 @@ fs_initcall(init_dax_wait_table);
/*
* DAX pagecache entries use XArray value entries so they can't be mistaken
- * for pages. We use one bit for locking, one bit for the entry size (PMD)
- * and two more to tell us if the entry is a zero page or an empty entry that
- * is just used for locking. In total four special bits.
+ * for pages. We use one bit for locking, one bit for the entry size (PMD),
+ * and one to tell if the entry is an empty entry just for locking. We use
+ * XArray's ZERO_ENTRY to tell us if the entry is a zero page.
*
- * If the PMD bit isn't set the entry has size PAGE_SIZE, and if the ZERO_PAGE
- * and EMPTY bits aren't set the entry is a normal DAX entry with a filesystem
- * block allocation.
+ * If the PMD bit isn't set the entry has size PAGE_SIZE, and if the EMPTY
+ * and ZERO_ENTRY bits aren't set the entry is a normal DAX entry with a
+ * filesystem block allocation.
*/
#define DAX_SHIFT (4)
#define DAX_LOCKED (1UL << 0)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFC PATCH 3/3] fs: dax.c: correct terminology used in DAX bit definitions
@ 2020-11-29 4:36 ` Amy Parker
0 siblings, 0 replies; 2+ messages in thread
From: Amy Parker @ 2020-11-29 4:36 UTC (permalink / raw
To: linux-fsdevel, linux-nvdimm; +Cc: Jan Kara, Matthew Wilcox
DAX_ZERO_ENTRY is no longer the bit for zero entries - XA_ZERO_ENTRY is.
The documentation above should be accurate to the definitions used accordingly.
Signed-off-by: Amy Parker <enbyamy@gmail.com>
---
fs/dax.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/dax.c b/fs/dax.c
index c2bdccef3140..ec23a4f9edd5 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -66,13 +66,13 @@ fs_initcall(init_dax_wait_table);
/*
* DAX pagecache entries use XArray value entries so they can't be mistaken
- * for pages. We use one bit for locking, one bit for the entry size (PMD)
- * and two more to tell us if the entry is a zero page or an empty entry that
- * is just used for locking. In total four special bits.
+ * for pages. We use one bit for locking, one bit for the entry size (PMD),
+ * and one to tell if the entry is an empty entry just for locking. We use
+ * XArray's ZERO_ENTRY to tell us if the entry is a zero page.
*
- * If the PMD bit isn't set the entry has size PAGE_SIZE, and if the ZERO_PAGE
- * and EMPTY bits aren't set the entry is a normal DAX entry with a filesystem
- * block allocation.
+ * If the PMD bit isn't set the entry has size PAGE_SIZE, and if the EMPTY
+ * and ZERO_ENTRY bits aren't set the entry is a normal DAX entry with a
+ * filesystem block allocation.
*/
#define DAX_SHIFT (4)
#define DAX_LOCKED (1UL << 0)
--
2.29.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-29 4:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-29 4:36 [RFC PATCH 3/3] fs: dax.c: correct terminology used in DAX bit definitions Amy Parker
2020-11-29 4:36 ` Amy Parker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.