* [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()
@ 2015-01-30 23:30 Chris Rorvick
2015-01-30 23:36 ` Chris Rorvick
0 siblings, 1 reply; 2+ messages in thread
From: Chris Rorvick @ 2015-01-30 23:30 UTC (permalink / raw
To: Greg Kroah-Hartman, Vincenzo Scotti
Cc: Chris Rorvick, Dan Carpenter, Rickard Strandqvist,
Roberta Dobrescu, Sachin Kamat, Simon Horman, Ebru Akagunduz,
Magnus Damm, devel, linux-kernel
This function is an awkward helper for nbu2ss_drv_ep_init(). Most of
its logic is devoted to determining if the current endpoint is ep0,
something the caller can easily do in a single line. And there is not
a lot going on beyond that.
Move this logic up into nbu2ss_drv_ep_init(). The result is much easier
to understand and the resulting function is still viewable within a
single screen.
Signed-off-by: Chris Rorvick <chris@rorvick.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 52 ++++++++++---------------------------
1 file changed, 14 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index eb178fc..46864b0 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -3249,42 +3249,6 @@ static const char *gp_ep_name[NUM_ENDPOINTS] = {
};
/*-------------------------------------------------------------------------*/
-static void __init nbu2ss_drv_set_ep_info(
- struct nbu2ss_udc *udc,
- struct nbu2ss_ep *ep,
- const char *name)
-{
- ep->udc = udc;
- ep->desc = NULL;
-
- ep->ep.driver_data = NULL;
- ep->ep.name = name;
- ep->ep.ops = &nbu2ss_ep_ops;
-
- if (isdigit(name[2])) {
-
- long num;
- int res;
- char tempbuf[2];
-
- tempbuf[0] = name[2];
- tempbuf[1] = '\0';
- res = kstrtol(tempbuf, 16, &num);
-
- if (num == 0)
- ep->ep.maxpacket = EP0_PACKETSIZE;
- else
- ep->ep.maxpacket = EP_PACKETSIZE;
-
- } else {
- ep->ep.maxpacket = EP_PACKETSIZE;
- }
-
- list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
- INIT_LIST_HEAD(&ep->queue);
-}
-
-/*-------------------------------------------------------------------------*/
static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc)
{
int i;
@@ -3292,9 +3256,21 @@ static void __init nbu2ss_drv_ep_init(struct nbu2ss_udc *udc)
INIT_LIST_HEAD(&udc->gadget.ep_list);
udc->gadget.ep0 = &udc->ep[0].ep;
+ for (i = 0; i < NUM_ENDPOINTS; i++) {
+ struct nbu2ss_ep *ep = &udc->ep[i];
- for (i = 0; i < NUM_ENDPOINTS; i++)
- nbu2ss_drv_set_ep_info(udc, &udc->ep[i], gp_ep_name[i]);
+ ep->udc = udc;
+ ep->desc = NULL;
+
+ ep->ep.driver_data = NULL;
+ ep->ep.name = gp_ep_name[i];
+ ep->ep.ops = &nbu2ss_ep_ops;
+
+ ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE);
+
+ list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
+ INIT_LIST_HEAD(&ep->queue);
+ }
list_del_init(&udc->ep[0].ep.ep_list);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info()
2015-01-30 23:30 [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info() Chris Rorvick
@ 2015-01-30 23:36 ` Chris Rorvick
0 siblings, 0 replies; 2+ messages in thread
From: Chris Rorvick @ 2015-01-30 23:36 UTC (permalink / raw
To: Greg Kroah-Hartman, Vincenzo Scotti
Cc: Chris Rorvick, Dan Carpenter, Rickard Strandqvist,
Roberta Dobrescu, Sachin Kamat, Simon Horman, Ebru Akagunduz,
Magnus Damm, devel, linux-kernel
On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick <chris@rorvick.com> wrote:
> +
> + ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE);
> +
Damn. I looked this over twice before sending this and still only
noticed this stupid typo after sending it. Will send a v2 shortly.
Sorry for the noise,
Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-30 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-30 23:30 [PATCH] staging: emxx_udc: Remove nbu2ss_drv_set_dp_info() Chris Rorvick
2015-01-30 23:36 ` Chris Rorvick
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.