From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 011FDC49EA4 for ; Tue, 22 Jun 2021 19:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DED9A6100B for ; Tue, 22 Jun 2021 19:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbhFVUAB (ORCPT ); Tue, 22 Jun 2021 16:00:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232464AbhFVT77 (ORCPT ); Tue, 22 Jun 2021 15:59:59 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B22DC061574; Tue, 22 Jun 2021 12:57:41 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id l1so240528ejb.6; Tue, 22 Jun 2021 12:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=ofg0zEesjw/TVIggXvcIPH9DhGxXKSu3YWaBmok3qYhCzDJdLDF2FsMeqpMBwexpQ/ ksHDL089XVMVKt9O40sZVVDvQBckA/2cpF9IeuFFXqS4ubOEH3x1LiIXWt8x5IdqEw2n rVm53TetQoqR93n+1YkQuSikga5VtiWvaGy+qQg5lQkmI1y9gFFwmxC17kfi+TejkrGV 6JS26EHtHAtIs2d54h/qG0RYACCtShPOI2ByFu6zYIdaDcQ9n6pfJPTaAw8zqNCk4YE6 t8BGqlqrkWWaTQN2Gk3MI9chqPSmFQC0tIYlhYPAykP7D7bGVQ+rOC4+OH97GwnxU6Tu uwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=avJXnHK9E561N/ve6Lz4fEx7STvcheORLl4U4hFSv+2qQJkcomifg6AI9tTg35PNOp PIZa9cvLbiNRZAwii7+CH8fFn8zYgkbZlCwimIrLeRigWa7sVaaIb4b6kI1q51Rr3Snz 8zADe0o6x9hIi0qCwsHzje5CAOx1d9ONiS+3wWRORJdLgo91RtKaQLKbfeaCMZlfSb5E qASDmw+kP/qgX3dT1WDqwowoEz85pi1CelCKeAgYOU/1NyuvljF31YlCI57TA6eLys8Y wAaXPlsYbk7TVt2Qvy8OUqZaBUoOQjngPKnLKbjXmsiAb54rnwyLZcxwxj3H7pilgAZ7 bnxw== X-Gm-Message-State: AOAM532UMWigkEQUvktdopd8qWewluqjxTZByJC0YkS3pjsx/xoujA6J bz4b0P/hwqqZyIFGOraPpL3up4cErqascaVijio= X-Google-Smtp-Source: ABdhPJyKd7e5C4Ph84g4B35RZoEdjwc6rb5o8Q7KdW9xfBBwAEDRGr7WOP7Jo/YB2xiUfT0KiK2lMC5guhRIKZ2smks= X-Received: by 2002:a17:906:f188:: with SMTP id gs8mr5734432ejb.527.1624391859989; Tue, 22 Jun 2021 12:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com> <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Tue, 22 Jun 2021 21:57:28 +0200 Message-ID: Subject: Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 To: Vinod Koul Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl > > 2021.. good catch, I'll fix this in v2 Best regards, Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595DCC48BE5 for ; Tue, 22 Jun 2021 19:57:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 040EB610C7 for ; Tue, 22 Jun 2021 19:57:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 040EB610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=drnpGNRYSCzHRhGbzFG9o9rIhfGCTJ/R/CTSyLyZQ5s=; b=iYwUExGdWeRMVT NtXRcMmJt2YWNos3ugySw1nVP3zn4qO3FgwnE97sojG3sKAhlt1Td/Bj6Rt3zcm9xu3keerP/BYJj rti961yNYbVvUSvNKC8glnqXKPWUNtaVm8P6Bz6H8uOclbDVIDQqbGVNeD2ElOK3VVm16yr8lYFYE qeFWhYH1vyTfLM8el9dfBXQKYLO/kUz7kMWOOoEA1ydeIwwfi13flc6gMx9qqPAM5w97VpVH0ZF+Y xqcgYL58p6W53V/L8+DdVUoiX9dPxQB+Ud2TgWoF8HVG7d4rPrho/QfRXhR5r9Dd5zI8uDCIAS1B6 DhizKbLFkpVkBJ55m+tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWm-008GyE-BV; Tue, 22 Jun 2021 19:57:44 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWk-008Gxi-Bk; Tue, 22 Jun 2021 19:57:43 +0000 Received: by mail-ej1-x634.google.com with SMTP id my49so234832ejc.7; Tue, 22 Jun 2021 12:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=ofg0zEesjw/TVIggXvcIPH9DhGxXKSu3YWaBmok3qYhCzDJdLDF2FsMeqpMBwexpQ/ ksHDL089XVMVKt9O40sZVVDvQBckA/2cpF9IeuFFXqS4ubOEH3x1LiIXWt8x5IdqEw2n rVm53TetQoqR93n+1YkQuSikga5VtiWvaGy+qQg5lQkmI1y9gFFwmxC17kfi+TejkrGV 6JS26EHtHAtIs2d54h/qG0RYACCtShPOI2ByFu6zYIdaDcQ9n6pfJPTaAw8zqNCk4YE6 t8BGqlqrkWWaTQN2Gk3MI9chqPSmFQC0tIYlhYPAykP7D7bGVQ+rOC4+OH97GwnxU6Tu uwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=m3eMXls8X1rQ3Rh1SbveEQ2X1D/fL/z8IneQu1dpLNXMT0SPOXKsOiF5LdvGyKpK+q 1jbXByn/Yg5HpANWYVLKH86/o5Oddc+9Ba/zoq6kWhDsKM2xAMQNa1QUg6flT7QbL2tW 1o9+CS2u8aVynxKR435saefahasRXPUJ4JTDvTeISbAzuz2n7RjImwKe9B5rsgTir9UK i75Y6LuL8rC2JjQuqC/KaQUa/c3m8FUhW3pgbXpnumm3O076FeAmLlYklcFpfyzAY0+N aiSn2jp4MrRwGqQmVCykjFU9Iz15VNxOUjnQevV27m38UqlDNKvlK2sse+zdrqIaazBh hw+w== X-Gm-Message-State: AOAM5323o2Jq/ehqir0DmMcaHwmjegcKLLN+IZVoZTYZ/22VCHg81212 5BPicJe61IKTN+zB6M7uxL7fkKzn4j7w4kEZGUiFpBqQhZo= X-Google-Smtp-Source: ABdhPJyKd7e5C4Ph84g4B35RZoEdjwc6rb5o8Q7KdW9xfBBwAEDRGr7WOP7Jo/YB2xiUfT0KiK2lMC5guhRIKZ2smks= X-Received: by 2002:a17:906:f188:: with SMTP id gs8mr5734432ejb.527.1624391859989; Tue, 22 Jun 2021 12:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com> <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Tue, 22 Jun 2021 21:57:28 +0200 Message-ID: Subject: Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 To: Vinod Koul Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_125742_464518_51F1C378 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl > > 2021.. good catch, I'll fix this in v2 Best regards, Martin -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA7B3C2B9F4 for ; Tue, 22 Jun 2021 19:57:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B7176100B for ; Tue, 22 Jun 2021 19:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B7176100B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=koJazCDSwYvcZu5BuaXFJH5C9CExPKwoCBm/nsHgXug=; b=UlgExmeEb704uP Sin60ujmB4nsL/V5IW2kLtAkZRLOB6U2p94NUFDiqdxCcEEiO/+jVtbpKUY+9kTwnePf2CtKD7u2m +yxpmSFh+JoC5Z9EhkQlpvWDX3lAbTIlvX7pjeYp6GCPI/KtQ8wXxVldLrs//9Kc8s5DnV5wg8dTN tTWfCQA6w4ai/Rlp5TQSm6SLqNAo2f1T1kY4loC7rYZio+EQAuqBaXaXfivdZY4yBBHc0KAe8rKVr +Lnu0mDvO6R+RFVlxpr96ZNv2E+4h6wdsHUne3J6YdRxw/EeAuBayvmU+tvm43ubNwrYgOrePGTgJ uVhVWhk/LPjToc0ULBQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWm-008GyJ-IG; Tue, 22 Jun 2021 19:57:44 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWk-008Gxi-Bk; Tue, 22 Jun 2021 19:57:43 +0000 Received: by mail-ej1-x634.google.com with SMTP id my49so234832ejc.7; Tue, 22 Jun 2021 12:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=ofg0zEesjw/TVIggXvcIPH9DhGxXKSu3YWaBmok3qYhCzDJdLDF2FsMeqpMBwexpQ/ ksHDL089XVMVKt9O40sZVVDvQBckA/2cpF9IeuFFXqS4ubOEH3x1LiIXWt8x5IdqEw2n rVm53TetQoqR93n+1YkQuSikga5VtiWvaGy+qQg5lQkmI1y9gFFwmxC17kfi+TejkrGV 6JS26EHtHAtIs2d54h/qG0RYACCtShPOI2ByFu6zYIdaDcQ9n6pfJPTaAw8zqNCk4YE6 t8BGqlqrkWWaTQN2Gk3MI9chqPSmFQC0tIYlhYPAykP7D7bGVQ+rOC4+OH97GwnxU6Tu uwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=m3eMXls8X1rQ3Rh1SbveEQ2X1D/fL/z8IneQu1dpLNXMT0SPOXKsOiF5LdvGyKpK+q 1jbXByn/Yg5HpANWYVLKH86/o5Oddc+9Ba/zoq6kWhDsKM2xAMQNa1QUg6flT7QbL2tW 1o9+CS2u8aVynxKR435saefahasRXPUJ4JTDvTeISbAzuz2n7RjImwKe9B5rsgTir9UK i75Y6LuL8rC2JjQuqC/KaQUa/c3m8FUhW3pgbXpnumm3O076FeAmLlYklcFpfyzAY0+N aiSn2jp4MrRwGqQmVCykjFU9Iz15VNxOUjnQevV27m38UqlDNKvlK2sse+zdrqIaazBh hw+w== X-Gm-Message-State: AOAM5323o2Jq/ehqir0DmMcaHwmjegcKLLN+IZVoZTYZ/22VCHg81212 5BPicJe61IKTN+zB6M7uxL7fkKzn4j7w4kEZGUiFpBqQhZo= X-Google-Smtp-Source: ABdhPJyKd7e5C4Ph84g4B35RZoEdjwc6rb5o8Q7KdW9xfBBwAEDRGr7WOP7Jo/YB2xiUfT0KiK2lMC5guhRIKZ2smks= X-Received: by 2002:a17:906:f188:: with SMTP id gs8mr5734432ejb.527.1624391859989; Tue, 22 Jun 2021 12:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com> <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Tue, 22 Jun 2021 21:57:28 +0200 Message-ID: Subject: Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 To: Vinod Koul Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_125742_464518_51F1C378 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl > > 2021.. good catch, I'll fix this in v2 Best regards, Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0323C2B9F4 for ; Tue, 22 Jun 2021 20:00:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C77610C7 for ; Tue, 22 Jun 2021 20:00:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C77610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EtP0qDkiLSwz1vRj7UBsxAuktZEYSG4Kn3gbyuw6JOw=; b=WBrKw+zom9Id3A GnGk/8SWz/lNkBcCn7mpY+YmAPeOIKhu2sR/tbOeiRsnZ/j0ZUyOIXyt0NLP1opPZ5835HpOlQH20 Tw6y87wViE8oCeE9Ew7yfxRQ58uSSYgwj4mw3xX68RBRig2Po+0xwBYlSJecUapOU3R8aWKupHgp1 G6BfSxIEKuUVf7MllcLvTjdZ/mulT/Scw+MZx7b7UO/z8MWOoElAEnZCJeWFIZDC7uYYKH7enWGYB 6lN/C9EDtKUrx8Lrny9RhvneOs8Pk0KZJPKYvhzBadI5mcYXKzmMW5jTOZUp87ZS8kvsbVPd6Ccka J5k7aBOxY+hxpx3bYKxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWy-008GyW-AW; Tue, 22 Jun 2021 19:57:56 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvmWk-008Gxi-Bk; Tue, 22 Jun 2021 19:57:43 +0000 Received: by mail-ej1-x634.google.com with SMTP id my49so234832ejc.7; Tue, 22 Jun 2021 12:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=ofg0zEesjw/TVIggXvcIPH9DhGxXKSu3YWaBmok3qYhCzDJdLDF2FsMeqpMBwexpQ/ ksHDL089XVMVKt9O40sZVVDvQBckA/2cpF9IeuFFXqS4ubOEH3x1LiIXWt8x5IdqEw2n rVm53TetQoqR93n+1YkQuSikga5VtiWvaGy+qQg5lQkmI1y9gFFwmxC17kfi+TejkrGV 6JS26EHtHAtIs2d54h/qG0RYACCtShPOI2ByFu6zYIdaDcQ9n6pfJPTaAw8zqNCk4YE6 t8BGqlqrkWWaTQN2Gk3MI9chqPSmFQC0tIYlhYPAykP7D7bGVQ+rOC4+OH97GwnxU6Tu uwBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Eovzw/udn4hicrC407R2X9SrTc2QGxyjor98KY9344o=; b=m3eMXls8X1rQ3Rh1SbveEQ2X1D/fL/z8IneQu1dpLNXMT0SPOXKsOiF5LdvGyKpK+q 1jbXByn/Yg5HpANWYVLKH86/o5Oddc+9Ba/zoq6kWhDsKM2xAMQNa1QUg6flT7QbL2tW 1o9+CS2u8aVynxKR435saefahasRXPUJ4JTDvTeISbAzuz2n7RjImwKe9B5rsgTir9UK i75Y6LuL8rC2JjQuqC/KaQUa/c3m8FUhW3pgbXpnumm3O076FeAmLlYklcFpfyzAY0+N aiSn2jp4MrRwGqQmVCykjFU9Iz15VNxOUjnQevV27m38UqlDNKvlK2sse+zdrqIaazBh hw+w== X-Gm-Message-State: AOAM5323o2Jq/ehqir0DmMcaHwmjegcKLLN+IZVoZTYZ/22VCHg81212 5BPicJe61IKTN+zB6M7uxL7fkKzn4j7w4kEZGUiFpBqQhZo= X-Google-Smtp-Source: ABdhPJyKd7e5C4Ph84g4B35RZoEdjwc6rb5o8Q7KdW9xfBBwAEDRGr7WOP7Jo/YB2xiUfT0KiK2lMC5guhRIKZ2smks= X-Received: by 2002:a17:906:f188:: with SMTP id gs8mr5734432ejb.527.1624391859989; Tue, 22 Jun 2021 12:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604190338.2248295-1-martin.blumenstingl@googlemail.com> <20210604190338.2248295-3-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Tue, 22 Jun 2021 21:57:28 +0200 Message-ID: Subject: Re: [PATCH 2/2] phy: amlogic: Add a new driver for the HDMI TX PHY on Meson8/8b/8m2 To: Vinod Koul Cc: robh+dt@kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, kishon@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_125742_464518_51F1C378 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vinod, thanks for taking the time to review this! On Mon, Jun 21, 2021 at 8:18 AM Vinod Koul wrote: > > On 04-06-21, 21:03, Martin Blumenstingl wrote: > > Amlogic Meson8/8b/8m2 have a built-in HDMI PHY in the HHI register > > region. Unfortunately only few register bits are documented. For > > HHI_HDMI_PHY_CNTL0 the magic numbers are taken from the 3.10 vendor > > kernel. > > > > Signed-off-by: Martin Blumenstingl > > --- > > drivers/phy/amlogic/Kconfig | 11 ++ > > drivers/phy/amlogic/Makefile | 1 + > > drivers/phy/amlogic/phy-meson8-hdmi-tx.c | 150 +++++++++++++++++++++++ > > 3 files changed, 162 insertions(+) > > create mode 100644 drivers/phy/amlogic/phy-meson8-hdmi-tx.c > > > > diff --git a/drivers/phy/amlogic/Kconfig b/drivers/phy/amlogic/Kconfig > > index db5d0cd757e3..e6c3a2a8b769 100644 > > --- a/drivers/phy/amlogic/Kconfig > > +++ b/drivers/phy/amlogic/Kconfig > > @@ -2,6 +2,17 @@ > > # > > # Phy drivers for Amlogic platforms > > # > > +config PHY_MESON8_HDMI_TX > > + tristate "Meson8, Meson8b and Meson8m2 HDMI TX PHY driver" > > + default ARCH_MESON > > + depends on (ARCH_MESON && ARM) || COMPILE_TEST > > depends on ARM seems redundant.. config ARCH_MESON exists in arch/arm as well as arch/arm64 my idea was to hide it from the 64-bit SoCs since it's not used there While reading your comment I spotted something for myself: I think "default ARCH_MESON" should not be there. > > + * Meson8, Meson8b and Meson8m2 HDMI TX PHY. > > + * > > + * Copyright (C) 2020 Martin Blumenstingl > > 2021.. good catch, I'll fix this in v2 Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel