From: Peter Maydell <peter.maydell@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C"
Date: Wed, 14 Apr 2021 19:50:41 +0100 [thread overview]
Message-ID: <CAFEAcA-Wu8c=TyNd0T4mocvy4=Fh=xqoAAuOtg7NcF2i38YiqA@mail.gmail.com> (raw)
In-Reply-To: <YHchNfXnhyzZBTg5@redhat.com>
On Wed, 14 Apr 2021 at 18:26, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Tue, Apr 13, 2021 at 06:08:49PM +0200, Paolo Bonzini wrote:
> > #ifdef _WIN32
> > #include "sysemu/os-win32.h"
>
> This and os-posix.h both include other system headers. We don't currently
> have problem, so this is ok as the minimal fix for 6.0, but long term we
> need more work on this header to further narrow the extern {} block.
Maybe we should just move all the system header includes out of
both os-posix.h and os-win32.h ? We already have one header file
we've treated that way (sys/wait.h).
Alternatively we could leave os-win32.h and os-posix.h outside
osdep.h's extern block, and require that they both use an
extern block themselves for their declarations.
thanks
-- PMM
next prev parent reply other threads:[~2021-04-14 18:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 16:08 [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 Paolo Bonzini
2021-04-13 16:08 ` [PULL v2 1/3] osdep: include glib-compat.h before other QEMU headers Paolo Bonzini
2021-04-14 16:51 ` Philippe Mathieu-Daudé
2021-04-14 17:00 ` Daniel P. Berrangé
2021-04-13 16:08 ` [PULL v2 2/3] osdep: protect qemu/osdep.h with extern "C" Paolo Bonzini
2021-04-14 17:07 ` Daniel P. Berrangé
2021-04-14 18:39 ` Peter Maydell
2021-04-14 18:50 ` Peter Maydell [this message]
2021-04-15 9:20 ` Daniel P. Berrangé
2021-04-13 16:08 ` [PULL v2 3/3] qapi/qom.json: Do not use CONFIG_VIRTIO_CRYPTO in common code Paolo Bonzini
2021-04-13 17:05 ` [PULL v2 0/3] osdep.h + QOM changes for QEMU 6.0-rc3 no-reply
2021-04-13 20:15 ` Peter Maydell
2021-04-14 12:10 ` Peter Maydell
2021-04-14 18:22 ` Peter Maydell
2021-04-15 5:57 ` Markus Armbruster
2021-04-15 10:48 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Wu8c=TyNd0T4mocvy4=Fh=xqoAAuOtg7NcF2i38YiqA@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.