From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36599)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZbWFt-0001dn-J8
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:05:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZbWFl-00063p-4J
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:05:21 -0400
Received: from mail-vk0-f54.google.com ([209.85.213.54]:36134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1ZbWFk-00061u-SE
	for qemu-devel@nongnu.org; Mon, 14 Sep 2015 12:05:12 -0400
Received: by vkfp126 with SMTP id p126so61791480vkf.3
	for <qemu-devel@nongnu.org>; Mon, 14 Sep 2015 09:05:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <55F6EEF2.3090409@redhat.com>
References: <1442240110-26006-1-git-send-email-leon.alrae@imgtec.com>
	<55F6EEF2.3090409@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Date: Mon, 14 Sep 2015 17:04:52 +0100
Message-ID: <CAFEAcA88kHop8iADiYU7iC_SMDRLsVJvzrSSiUS-WW5ErHRfLQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] vfio: change the order of includes to fix
 build on CentOS 5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>, Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>

On 14 September 2015 at 16:59, Eric Blake <eblake@redhat.com> wrote:
> On 09/14/2015 08:15 AM, Leon Alrae wrote:
>> Include linux/vfio.h after sys/ioctl.h, just like in hw/vfio/common.c and
>> hw/vfio/platform.c.
>>
>> This fixes the regression caused by the change in commit d7646f2:
>
> How much longer are we planning on building on CentOS 5? Didn't we
> already break things with a glib minimum requirement in qemu 2.5, plus
> the now-pending bump to python 2.6?

It's not supported by us (upstream) any more (since 2.4).

> While I'm not opposed to this patch, I'm wondering if it will make any
> real difference.

Anybody wanting to build on Centos 5 is going to need to start
building/backporting their dependent libraries and build tools,
yes. But where the changes to fix compilation issues are trivial,
like this one, I don't see any reason for us not to accept them.

thanks
-- PMM