From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F206FC432BE for ; Thu, 12 Aug 2021 09:45:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6036C61038 for ; Thu, 12 Aug 2021 09:45:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6036C61038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE7HO-0004yx-5X for qemu-devel@archiver.kernel.org; Thu, 12 Aug 2021 05:45:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE7Fl-0002Eu-KI for qemu-devel@nongnu.org; Thu, 12 Aug 2021 05:43:57 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:44744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mE7Fk-0007Oq-7r for qemu-devel@nongnu.org; Thu, 12 Aug 2021 05:43:57 -0400 Received: by mail-ed1-x52a.google.com with SMTP id z11so8672459edb.11 for ; Thu, 12 Aug 2021 02:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B1ya+lOPAftXHg70ZivKItvcqHOrmRz+N0DNnsBV42Y=; b=HZ58bwOQC0nM1t0M4kT3Eb++nhiGZZJyJRo6kNf/PxF1XwQm5/BpLlOf1I12iEidna LUAf3A8pnQCTxGWS8Xze7XO1C30ozf0EfhO2nTxBxQnmUrO/PhKfYFEiSi3WA2aaElwi 4BcLtv5DWXqYOD8j9IB05KFqkJyaS2x0Aj8lC0S1uffKLhqj52f+jgCg/dFxodskKuAk F9SrVGCE+/0rjSmeYUc4tJe6/x95wtYy3HlqHJfRbI06SBCJoCzpq9sBTKwY9luzweM7 HO4Xao3q35wj7Oevg/sKK7dzOxcNNyyB0ilPCE89VSNXRlQAHCbxDEIyrdxTdEmF9Yk4 5SYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B1ya+lOPAftXHg70ZivKItvcqHOrmRz+N0DNnsBV42Y=; b=ZTZm6Hb2aUaG8wOXtMs65ovjnJcLRRltPRQlD17x18AGnW2BOi4H2Fbuc4woAN/qwr JRMd7VcocQ3MVoiZc28TmgDO7ba0UH2eMGzTZNL93Nbvlc3EkJnK8OCxTraqW7DtZNM9 bnuOPzUs/dph+vxBqm0e2CeN0ukatrZ3B2DZKJzf0uJMGRJBJ0zUUp3X9HyLeDdgBB/z vSVd77TEV3Yxe3OEdAydK+df7QNQ1ufzrXrTq0iy5PH90QgT5NmgEWnOqjXeZUB9w951 aDRU1yrP67dXJ0Gn14x206QX4z21H5+OcpF31DkqVSBZh32JGyDEovSDUrAjLY6BrWS6 zEqA== X-Gm-Message-State: AOAM533iCdML3yqkvgoN8H1NRgq4FtdCW4gDc7dUsZkVyeZgLPcHD2px 73TikoeA4FmDSeE1aP8nBqaF8FzXsg4YKeKpnDsC9w== X-Google-Smtp-Source: ABdhPJwbJyxauFwhzfPr7cGH4HxxkPl0oHC9IYJRF8ZdxXkwqT+OOz+ZqKj5oFJpNAVi5SvB0KtS/Xl5oSwdS3mxaqQ= X-Received: by 2002:aa7:c4cd:: with SMTP id p13mr2587975edr.251.1628761434841; Thu, 12 Aug 2021 02:43:54 -0700 (PDT) MIME-Version: 1.0 References: <20210729111512.16541-1-peter.maydell@linaro.org> <20210729111512.16541-8-peter.maydell@linaro.org> In-Reply-To: From: Peter Maydell Date: Thu, 12 Aug 2021 10:43:09 +0100 Message-ID: Subject: Re: [PATCH for-6.2 07/53] target/arm: Fix MVE 48-bit SQRSHRL for small right shifts To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 30 Jul 2021 at 20:07, Richard Henderson wrote: > I'll note two things: > > (1) The val == extval check could be sunk to the end of the function and shared with the > left shift, > > (2) sat will never be unset, as #48 is encoded as sat=1 in the insn. True; I'm kind of aiming for parity with the other sqrshl utility routines, which is why the unused no-saturation code is in there. -- PMM