From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.maydell@linaro.org (Peter Maydell) Date: Wed, 17 Jun 2015 14:21:59 +0100 Subject: [PATCH 04/10] KVM: arm/arm64: vgic: Allow HW irq to be encoded in LR In-Reply-To: <55815FA5.4010203@linaro.org> References: <1433783045-8002-1-git-send-email-marc.zyngier@arm.com> <1433783045-8002-5-git-send-email-marc.zyngier@arm.com> <55815FA5.4010203@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17 June 2015 at 12:53, Eric Auger wrote: > shouldn't we test somewhere that the hwirq is between 16 and 1019. Not directly related, but that reminds me that I noticed the other day that we have VGIC_MAX_IRQS = 1024 (and use that as a guard on how many irqs we let userspace configure and ask us to deliver), but that doesn't account for the couple of magic numbers at the top of the range. I think that lets userspace cause us to do UNPREDICTABLE things to the GIC... -- PMM From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Maydell Subject: Re: [PATCH 04/10] KVM: arm/arm64: vgic: Allow HW irq to be encoded in LR Date: Wed, 17 Jun 2015 14:21:59 +0100 Message-ID: References: <1433783045-8002-1-git-send-email-marc.zyngier@arm.com> <1433783045-8002-5-git-send-email-marc.zyngier@arm.com> <55815FA5.4010203@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <55815FA5.4010203@linaro.org> Sender: kvm-owner@vger.kernel.org To: Eric Auger Cc: Marc Zyngier , kvm-devel , "kvmarm@lists.cs.columbia.edu" , arm-mail-list , Andre Przywara List-Id: kvmarm@lists.cs.columbia.edu On 17 June 2015 at 12:53, Eric Auger wrote: > shouldn't we test somewhere that the hwirq is between 16 and 1019. Not directly related, but that reminds me that I noticed the other day that we have VGIC_MAX_IRQS = 1024 (and use that as a guard on how many irqs we let userspace configure and ask us to deliver), but that doesn't account for the couple of magic numbers at the top of the range. I think that lets userspace cause us to do UNPREDICTABLE things to the GIC... -- PMM